Date: Sat, 24 Mar 2012 21:04:19 +0530 From: Dhiru Kholia <dhiru.kholia@...il.com> To: john-dev@...ts.openwall.com Subject: Re: [JtR patch] Fast cracker for Mozilla Firefox, Thunderbird and SeaMonkey master passwords. On Sat, Mar 24, 2012 at 8:37 PM, magnum <john.magnum@...hmail.com> wrote: > On 03/24/2012 02:26 PM, Dhiru Kholia wrote: >> Also, even if we disable "HAVE_NSS" in Makefile, mozilla2john symlink >> in run/ is created. Can we somehow avoid this? > > Enclosed patch seems to do the trick. Thanks. Applied. > I think the messages when not enabled (below) should include the fact > that you need to uncomment HAVE_NSS in Makefile. Also, the mozilla2john > warning could be completely muted IMHO - it's enough with one notice. > Alternatively, you could leave the mozilla_fmt warning as-is and change > the mozilla2john warning to say "If NSS is installed, you need to define > HAVE_NSS in Makefile" > > mozilla_fmt.c:182:2: warning: #warning Note: Mozilla format disabled - > it needs NSS (and NSPR) installed [-Wcpp] > mozilla2john.c:59:2: warning: #warning Note: mozilla2john utility > disabled - it needs NSS (and NSPR) installed [-Wcpp] Will take of both points in the next release of the patch. Thinking of pushing to magnum-jumbo. Do you think the patch is ready? -- Cheers, Dhiru
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.