Date: Sat, 17 Mar 2012 08:54:29 +0530 From: Dhiru Kholia <dhiru.kholia@...il.com> To: john-dev@...ts.openwall.com Subject: Re: SSH thread-safety On Sat, Mar 17, 2012 at 7:38 AM, Dhiru Kholia <dhiru.kholia@...il.com> wrote: > On Sat, Mar 17, 2012 at 5:35 AM, Solar Designer <solar@...nwall.com> wrote: >> I am testing the new code now (in magnum-jumbo). No segfaults yet, but >> the first thing I noticed is that this does not scale beyond the speed >> of two threads anymore. :-( > > Heh, the Cure Is Worse Than the Disease it seems!. On my system > multi-core performance is worse than single-core performance. I have removed the callbacks now. > I have an (untested idea). Why not copy PEM_do_header function from > OpenSSL and remove all thread-unsafe error handling which we don't use > anyway? I have implemented this idea. Performance is back and no random segfaults :-). Please give the latest code a shot. Thanks! -- Cheers, Dhiru
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.