Date: Mon, 19 Dec 2011 23:18:01 +0400 From: Solar Designer <solar@...nwall.com> To: john-dev@...ts.openwall.com Subject: Re: 1.7.9-jumbo On Mon, Dec 19, 2011 at 06:58:31PM +0100, magnum wrote: > There are no uninitialized variables in the NT code if that is what you > meant. Anyway, it turns out the version that does truncate correctly > regained its speed just by changing the order of conditions, ie. from > > if (md4_size < (PLAINTEXT_LENGTH - 1) && (temp = key[++md4_size])) > > to > > if ((temp = key[++md4_size]) && md4_size < PLAINTEXT_LENGTH) > > Please try the version at > https://github.com/magnumripper/magnum-jumbo/raw/bfb40805651e53ea4cd8b02ef00fcf4056763061/src/NT_fmt_plug.c > and see how this performs on your gear compared to 1.7.8-j8. This provides the same performance that 1.7.8-j8 did, yes. :-) > It's actually 2% faster on my laptop so I'd be surprised if this is not > the definite fix. It is. (I am not seeing a 2% speedup compared to 1.7.8-j8, though. There might be a 0.5% speedup here, but this might be "compiler randomness" as you say.) Thanks, Alexander
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.