Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sat, 17 Dec 2011 12:45:59 -0600
From: "jfoug" <jfoug@....net>
To: <john-dev@...ts.openwall.com>
Subject: RE: Test results for 179 jumbo-4

>
>BTW, why aren't you testing -jumbo-5 yet?

I will, but my time is short. 

>> testing: 'john -test=0 -enc:cp1253
>> form=dynamic_27                   guesses:    0 unk unk : Expected
>count(s)
>> (1500)  [!!!FAILED!!!]
>
>Hmm.  Aren't dynamic_27 and _28 duplicates of "md5"?  Do we need them?

Good question.  At one time, they were much faster for some builds.  I think
they are still faster if all you have is md5-mmx.S (i.e. 32 bit early asm).
However, the MD5 format since it now has intrinsic md5 is faster for most
builds.
>
>In -jumbo-4 (as compared to -jumbo-3), I added:
>
>diff -u john-1.7.9/src/dynamic_preloads.c john-
>1.7.9/src/dynamic_preloads.c
>--- john-1.7.9/src/dynamic_preloads.c   2011-12-15 22:26:02 +0000
>+++ john-1.7.9/src/dynamic_preloads.c   2011-12-16 15:41:53 +0000
>@@ -659,6 +659,7 @@
>        {NULL}
> };
>
>+#if ARCH_LITTLE_ENDIAN
> //dynamic_27 --> FreeBSD MD5
> static DYNAMIC_primitive_funcp _Funcs_27[] =
> {
>@@ -707,6 +708,7 @@
>        {"$apr1$"},
>        {NULL}
> };
>+#endif
>
> //dynamic_29 --> raw-md5-unicode  md5(unicode($p))
> static DYNAMIC_primitive_funcp _Funcs_29[] =
>
>because otherwise I was getting "defined but not used" warnings on a
>big-endian build (macosx-ppc32).
>
>Thus, I am puzzled as to why you're getting them defined on SPARC, which
>is also big-endian.

They are NOT defined.  However, the code within the -subformat:LIST function
was broken.  It was walking an int, printing it out. So if things were
properly sequential, this int, and the format name 'lined' up.  On the BE
builds, it was listing this:

dynamic_27  dynamic_29: Unicode(md5($s))

which within the new test suite, was causing it to think dynamic_27 was a
valid format on the BE systems, and also NOT making dynamic_29 a valid
format on the same build.


I have put a patch on the wiki. It is based on jumbo-4, but I am 99% sure it
will be just fine, applied to jumbo-5.

Jim.

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.