Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 16 Dec 2011 22:57:27 +0400
From: Solar Designer <>
Subject: Re: External mode (lack of) truncation

magnum, Jim -

On Fri, Dec 16, 2011 at 06:58:38PM +0100, magnum wrote:
> On 12/15/2011 10:53 PM, magnum wrote:
> >I just noticed external.c does not truncate at format's max length. I
> >thought it did, because I believe all other modes do.

It never did, and it was not supposed to.  Wordlist mode does this only
because it tries to eliminate some effective duplicates.  Incremental
mode does it in a smart way (printing a warning and effectively reducing
MaxLen) starting with a certain version - as a usability enhancement.

Formats are/were supposed to make no assumptions about supplied
plaintext length in set_key().

Maybe we want to reconsider this convention.  Maybe not.

> >Some formats (like
> >nt2) die from, for example, --ext:repeats because of this and I am
> >guilty of some (or all) of them doing so :-/
> >
> >Should/could this be fixed in external.c or should I produce a patch
> >that fixes the affected formats? I believe doing it in external.c might
> >be better for performance because we can do it blindly vs having a test
> >inside the key setup loops.
> Patch 0001 fixes external mode.

OK, I don't mind applying it in -jumbo for now.



Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.