Date: Thu, 24 Nov 2011 01:36:56 +0100 From: magnum <john.magnum@...hmail.com> To: john-dev@...ts.openwall.com Subject: Re: 1.7.9-jumbo 2011-11-23 21:01, magnum wrote: > 2011-11-23 19:41, magnum wrote: >> Done, to http://openwall.info/wiki/john/patches#Jumbo-rebase-for-1.7.9 >> >> Note: I'm not sure all Makefile targets ended up 100% OK (where they >> were changed in core). Other than that, I'm not aware of any problems, >> but this should be reviewed/tested of course. > > More notes: > > - I think the relbench.pl ended up as patched by Jim, not the newer > version by Solar. > - And on that matter, was the Windows time output changed in base? I > might have reverted that unintentionally, not sure. I did not > intentionally do the right thing anywhere :) > - The various arch.h's need to be double checked after these patches, so > they match core. Most notably x86-ssei.h. Yet some: - I don't even know what "undrop" is for, but it looks like it was lost from main() during rebasing. - Shouldn't targets like linux-x86-64 have this? CFLAGS_MAIN="$(CFLAGS) -DHAVE_CRYPT" \ If not, john.c will be compiled without HAVE_CRYPT, no? This applies even to core John. But I may misunderstand the whole thing. magnum
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.