Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sat, 27 Aug 2011 18:20:54 +0400
From: Solar Designer <>
Subject: Re: #include "john.conf2"  (a wish list item)

On Fri, Aug 26, 2011 at 07:24:57PM -0400, David Jones wrote:
> I think it would be better to establish a formal escape syntax to identify comments that aren't really comments, such as ##!include rather than just #include.

I am not sure whether we want these directives to look like comments at
all or maybe not.  What are our reasons to make them comment-like?  Just
that it's the way it's done in the C preprocessor?  OK, I identified one
more reason - not introducing a new character that may sometimes need to
be escaped.

What do we want older versions of JtR to do when they see an include
directive - silently ignore it (treat as comment) or complain about it?
If it's the latter, then we need to use a different syntax, not
comment-like.  But what syntax?  If we use something like:


it will just be treated as a new section start by an older version of
JtR - not what we want.  If we use some new syntax like:

include "file"
include [section]


{Include "file"}
{Include [section]}

it will not always be detected as an error by older versions of JtR -
depending on what section it's in.  Also, it might introduce a new
character that may sometimes need to be escaped.

Yet this might be the best we can do.  Any other ideas?


Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.