Date: Wed, 17 Aug 2011 17:02:34 +0200 From: magnum <rawsmooth@...dband.net> To: john-dev@...ts.openwall.com Subject: Re: 45% wordlist boost just waiting to happen On 2011-08-17 13:30, Solar Designer wrote: > On Mon, Aug 15, 2011 at 09:35:44PM +0200, magnum wrote: >> These lines in wordlist.c always nagged me: >> >> #if 0&& ARCH_ALLOWS_UNALIGNED >> /* XXX: somehow this breaks things - why? */ >> line = words[nCurLine++]; >> #else >> strcpy(line, words[nCurLine++]); >> #endif > > As far as I recall, JimF's original patch adding in-memory wordlists > only had the strcpy() here. When merging the patch, I noticed that this > was inefficient, so I added the #if ARCH_ALLOWS_UNALIGNED and pointer > assignment. However, somehow this did not work right. I did not > investigate, and simply added the "0&&" then. That's all. I believe I found the problem. You actually had another XXX comment hinting about it, but I didn't fully understand the issue until seeing in valgrind what happened. Easy fix then. >> This made for a stunning 45% boost running a wordlist + rules against LM. > > That's impressive. Perhaps when you apply the -fast-des-key-setup-3 > patch, the boost for LM may be even higher. Yes, I think I used omp4. I tried again now, using nsk3: LM, 1 hash, rockyou -ru: 57% boost! NT, 1 hash, rockyou -ru: 38% boost Patch posted to wiki soon. It's a pity I didn't find this before the contest :( magnum
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.