Date: Sat, 16 Jul 2011 02:59:38 +0400 From: Solar Designer <solar@...nwall.com> To: john-dev@...ts.openwall.com Subject: md5_gen inconsistencies Jim - With all the recent interest in sha1(md5($p)) hashes (did some database of those leak?), I noticed that md5_gen_preloads.c: md5_gen_IS_VALID() skips many ex-subformats under x86-64 builds, but those are nevertheless printed by --subformat=LIST in those builds - this is very confusing to users. Perhaps at least fix --subformat=LIST? And maybe also rename this option to something closer to its current meaning, like --list-generic-formats? Also, the braces in md5_gen(...) are annoying, and the reference to "md5" is wrong for some of them. Maybe these all should be renamed to simply gen0 and so on, with no underscore and no braces? In john.pot, we could use $gen0$ and so on. For backwards compatibility, the old names could be recognized in valid(), though. Thanks, Alexander
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.