Openwall GNU/*/Linux - a small security-enhanced Linux distro for servers
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 10 Apr 2015 08:57:20 +0800
From: Kai Zhao <loverszhao@...il.com>
To: john-dev@...ts.openwall.com
Subject: Re: Coding Style

> Please attach the 130 KB file for core.  I might actually make changes
> based on it.  Thanks!

Sorry. The original output is not exactly 130KB which I have removed
several same problems. The original output is 323KB and I attach them
to three emails.

This is part 3.


Thanks,

Kai

[ CONTENT OF TYPE text/html SKIPPED ]

ERROR: do not use assignment in if condition
#125: FILE: john_core/src/misc.c:125:
+				if (!(*dptr++ = *sptr++)) break;

ERROR: trailing statements should be on next line
#125: FILE: john_core/src/misc.c:125:
+				if (!(*dptr++ = *sptr++)) break;

WARNING: suspect code indent for conditional statements (8, 8)
#136: FILE: john_core/src/misc.c:136:
+	while (*ptr)
+	if (*ptr >= 'A' && *ptr <= 'Z')

total: 12 errors, 2 warnings, 143 lines checked

john_core/src/misc.c has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
WARNING: storage class should be at the beginning of the declaration
#56: FILE: john_core/src/nonstd.c:56:
+MAYBE_INLINE static void

WARNING: please, no spaces at the start of a line
#58: FILE: john_core/src/nonstd.c:58:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)$

ERROR: "foo * bar" should be "foo *bar"
#58: FILE: john_core/src/nonstd.c:58:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#58: FILE: john_core/src/nonstd.c:58:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#58: FILE: john_core/src/nonstd.c:58:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#58: FILE: john_core/src/nonstd.c:58:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

WARNING: storage class should be at the beginning of the declaration
#135: FILE: john_core/src/nonstd.c:135:
+MAYBE_INLINE static void

WARNING: please, no spaces at the start of a line
#137: FILE: john_core/src/nonstd.c:137:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)$

ERROR: "foo * bar" should be "foo *bar"
#137: FILE: john_core/src/nonstd.c:137:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#137: FILE: john_core/src/nonstd.c:137:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#137: FILE: john_core/src/nonstd.c:137:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#137: FILE: john_core/src/nonstd.c:137:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

WARNING: storage class should be at the beginning of the declaration
#213: FILE: john_core/src/nonstd.c:213:
+MAYBE_INLINE static void

WARNING: please, no spaces at the start of a line
#215: FILE: john_core/src/nonstd.c:215:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)$

ERROR: "foo * bar" should be "foo *bar"
#215: FILE: john_core/src/nonstd.c:215:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#215: FILE: john_core/src/nonstd.c:215:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#215: FILE: john_core/src/nonstd.c:215:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#215: FILE: john_core/src/nonstd.c:215:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

WARNING: storage class should be at the beginning of the declaration
#293: FILE: john_core/src/nonstd.c:293:
+MAYBE_INLINE static void

WARNING: please, no spaces at the start of a line
#295: FILE: john_core/src/nonstd.c:295:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)$

ERROR: "foo * bar" should be "foo *bar"
#295: FILE: john_core/src/nonstd.c:295:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#295: FILE: john_core/src/nonstd.c:295:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#295: FILE: john_core/src/nonstd.c:295:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#295: FILE: john_core/src/nonstd.c:295:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

WARNING: storage class should be at the beginning of the declaration
#367: FILE: john_core/src/nonstd.c:367:
+MAYBE_INLINE static void

WARNING: please, no spaces at the start of a line
#369: FILE: john_core/src/nonstd.c:369:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)$

ERROR: "foo * bar" should be "foo *bar"
#369: FILE: john_core/src/nonstd.c:369:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#369: FILE: john_core/src/nonstd.c:369:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#369: FILE: john_core/src/nonstd.c:369:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#369: FILE: john_core/src/nonstd.c:369:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

WARNING: storage class should be at the beginning of the declaration
#442: FILE: john_core/src/nonstd.c:442:
+MAYBE_INLINE static void

WARNING: please, no spaces at the start of a line
#444: FILE: john_core/src/nonstd.c:444:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)$

ERROR: "foo * bar" should be "foo *bar"
#444: FILE: john_core/src/nonstd.c:444:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#444: FILE: john_core/src/nonstd.c:444:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#444: FILE: john_core/src/nonstd.c:444:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#444: FILE: john_core/src/nonstd.c:444:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

WARNING: storage class should be at the beginning of the declaration
#516: FILE: john_core/src/nonstd.c:516:
+MAYBE_INLINE static void

WARNING: please, no spaces at the start of a line
#518: FILE: john_core/src/nonstd.c:518:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)$

ERROR: "foo * bar" should be "foo *bar"
#518: FILE: john_core/src/nonstd.c:518:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#518: FILE: john_core/src/nonstd.c:518:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#518: FILE: john_core/src/nonstd.c:518:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#518: FILE: john_core/src/nonstd.c:518:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

WARNING: storage class should be at the beginning of the declaration
#591: FILE: john_core/src/nonstd.c:591:
+MAYBE_INLINE static void

WARNING: please, no spaces at the start of a line
#593: FILE: john_core/src/nonstd.c:593:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)$

ERROR: "foo * bar" should be "foo *bar"
#593: FILE: john_core/src/nonstd.c:593:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#593: FILE: john_core/src/nonstd.c:593:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#593: FILE: john_core/src/nonstd.c:593:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#593: FILE: john_core/src/nonstd.c:593:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

WARNING: storage class should be at the beginning of the declaration
#668: FILE: john_core/src/nonstd.c:668:
+MAYBE_INLINE static void

WARNING: please, no spaces at the start of a line
#670: FILE: john_core/src/nonstd.c:670:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)$

ERROR: "foo * bar" should be "foo *bar"
#670: FILE: john_core/src/nonstd.c:670:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#670: FILE: john_core/src/nonstd.c:670:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#670: FILE: john_core/src/nonstd.c:670:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#670: FILE: john_core/src/nonstd.c:670:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

WARNING: storage class should be at the beginning of the declaration
#743: FILE: john_core/src/nonstd.c:743:
+MAYBE_INLINE static void

WARNING: please, no spaces at the start of a line
#745: FILE: john_core/src/nonstd.c:745:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)$

ERROR: "foo * bar" should be "foo *bar"
#745: FILE: john_core/src/nonstd.c:745:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#745: FILE: john_core/src/nonstd.c:745:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#745: FILE: john_core/src/nonstd.c:745:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#745: FILE: john_core/src/nonstd.c:745:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

WARNING: storage class should be at the beginning of the declaration
#817: FILE: john_core/src/nonstd.c:817:
+MAYBE_INLINE static void

WARNING: please, no spaces at the start of a line
#819: FILE: john_core/src/nonstd.c:819:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)$

ERROR: "foo * bar" should be "foo *bar"
#819: FILE: john_core/src/nonstd.c:819:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#819: FILE: john_core/src/nonstd.c:819:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#819: FILE: john_core/src/nonstd.c:819:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#819: FILE: john_core/src/nonstd.c:819:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

WARNING: storage class should be at the beginning of the declaration
#891: FILE: john_core/src/nonstd.c:891:
+MAYBE_INLINE static void

WARNING: please, no spaces at the start of a line
#893: FILE: john_core/src/nonstd.c:893:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)$

ERROR: "foo * bar" should be "foo *bar"
#893: FILE: john_core/src/nonstd.c:893:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#893: FILE: john_core/src/nonstd.c:893:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#893: FILE: john_core/src/nonstd.c:893:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#893: FILE: john_core/src/nonstd.c:893:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

WARNING: storage class should be at the beginning of the declaration
#965: FILE: john_core/src/nonstd.c:965:
+MAYBE_INLINE static void

WARNING: please, no spaces at the start of a line
#967: FILE: john_core/src/nonstd.c:967:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)$

ERROR: "foo * bar" should be "foo *bar"
#967: FILE: john_core/src/nonstd.c:967:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#967: FILE: john_core/src/nonstd.c:967:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#967: FILE: john_core/src/nonstd.c:967:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#967: FILE: john_core/src/nonstd.c:967:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

WARNING: storage class should be at the beginning of the declaration
#1039: FILE: john_core/src/nonstd.c:1039:
+MAYBE_INLINE static void

WARNING: please, no spaces at the start of a line
#1041: FILE: john_core/src/nonstd.c:1041:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)$

ERROR: "foo * bar" should be "foo *bar"
#1041: FILE: john_core/src/nonstd.c:1041:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#1041: FILE: john_core/src/nonstd.c:1041:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#1041: FILE: john_core/src/nonstd.c:1041:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#1041: FILE: john_core/src/nonstd.c:1041:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

WARNING: storage class should be at the beginning of the declaration
#1114: FILE: john_core/src/nonstd.c:1114:
+MAYBE_INLINE static void

WARNING: please, no spaces at the start of a line
#1116: FILE: john_core/src/nonstd.c:1116:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)$

ERROR: "foo * bar" should be "foo *bar"
#1116: FILE: john_core/src/nonstd.c:1116:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#1116: FILE: john_core/src/nonstd.c:1116:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#1116: FILE: john_core/src/nonstd.c:1116:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#1116: FILE: john_core/src/nonstd.c:1116:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

WARNING: storage class should be at the beginning of the declaration
#1172: FILE: john_core/src/nonstd.c:1172:
+MAYBE_INLINE static void

WARNING: please, no spaces at the start of a line
#1174: FILE: john_core/src/nonstd.c:1174:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)$

ERROR: "foo * bar" should be "foo *bar"
#1174: FILE: john_core/src/nonstd.c:1174:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#1174: FILE: john_core/src/nonstd.c:1174:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#1174: FILE: john_core/src/nonstd.c:1174:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#1174: FILE: john_core/src/nonstd.c:1174:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

WARNING: storage class should be at the beginning of the declaration
#1249: FILE: john_core/src/nonstd.c:1249:
+MAYBE_INLINE static void

WARNING: please, no spaces at the start of a line
#1251: FILE: john_core/src/nonstd.c:1251:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)$

ERROR: "foo * bar" should be "foo *bar"
#1251: FILE: john_core/src/nonstd.c:1251:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#1251: FILE: john_core/src/nonstd.c:1251:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#1251: FILE: john_core/src/nonstd.c:1251:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#1251: FILE: john_core/src/nonstd.c:1251:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

WARNING: storage class should be at the beginning of the declaration
#1326: FILE: john_core/src/nonstd.c:1326:
+MAYBE_INLINE static void

WARNING: please, no spaces at the start of a line
#1328: FILE: john_core/src/nonstd.c:1328:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)$

ERROR: "foo * bar" should be "foo *bar"
#1328: FILE: john_core/src/nonstd.c:1328:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#1328: FILE: john_core/src/nonstd.c:1328:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#1328: FILE: john_core/src/nonstd.c:1328:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#1328: FILE: john_core/src/nonstd.c:1328:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

WARNING: storage class should be at the beginning of the declaration
#1405: FILE: john_core/src/nonstd.c:1405:
+MAYBE_INLINE static void

WARNING: please, no spaces at the start of a line
#1407: FILE: john_core/src/nonstd.c:1407:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)$

ERROR: "foo * bar" should be "foo *bar"
#1407: FILE: john_core/src/nonstd.c:1407:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#1407: FILE: john_core/src/nonstd.c:1407:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#1407: FILE: john_core/src/nonstd.c:1407:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#1407: FILE: john_core/src/nonstd.c:1407:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

WARNING: storage class should be at the beginning of the declaration
#1482: FILE: john_core/src/nonstd.c:1482:
+MAYBE_INLINE static void

WARNING: please, no spaces at the start of a line
#1484: FILE: john_core/src/nonstd.c:1484:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)$

ERROR: "foo * bar" should be "foo *bar"
#1484: FILE: john_core/src/nonstd.c:1484:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#1484: FILE: john_core/src/nonstd.c:1484:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#1484: FILE: john_core/src/nonstd.c:1484:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#1484: FILE: john_core/src/nonstd.c:1484:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

WARNING: storage class should be at the beginning of the declaration
#1558: FILE: john_core/src/nonstd.c:1558:
+MAYBE_INLINE static void

WARNING: please, no spaces at the start of a line
#1560: FILE: john_core/src/nonstd.c:1560:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)$

ERROR: "foo * bar" should be "foo *bar"
#1560: FILE: john_core/src/nonstd.c:1560:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#1560: FILE: john_core/src/nonstd.c:1560:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#1560: FILE: john_core/src/nonstd.c:1560:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#1560: FILE: john_core/src/nonstd.c:1560:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

WARNING: storage class should be at the beginning of the declaration
#1634: FILE: john_core/src/nonstd.c:1634:
+MAYBE_INLINE static void

WARNING: please, no spaces at the start of a line
#1636: FILE: john_core/src/nonstd.c:1636:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)$

ERROR: "foo * bar" should be "foo *bar"
#1636: FILE: john_core/src/nonstd.c:1636:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#1636: FILE: john_core/src/nonstd.c:1636:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#1636: FILE: john_core/src/nonstd.c:1636:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#1636: FILE: john_core/src/nonstd.c:1636:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

WARNING: storage class should be at the beginning of the declaration
#1712: FILE: john_core/src/nonstd.c:1712:
+MAYBE_INLINE static void

WARNING: please, no spaces at the start of a line
#1714: FILE: john_core/src/nonstd.c:1714:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)$

ERROR: "foo * bar" should be "foo *bar"
#1714: FILE: john_core/src/nonstd.c:1714:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#1714: FILE: john_core/src/nonstd.c:1714:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#1714: FILE: john_core/src/nonstd.c:1714:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#1714: FILE: john_core/src/nonstd.c:1714:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

WARNING: storage class should be at the beginning of the declaration
#1786: FILE: john_core/src/nonstd.c:1786:
+MAYBE_INLINE static void

WARNING: please, no spaces at the start of a line
#1788: FILE: john_core/src/nonstd.c:1788:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)$

ERROR: "foo * bar" should be "foo *bar"
#1788: FILE: john_core/src/nonstd.c:1788:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#1788: FILE: john_core/src/nonstd.c:1788:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#1788: FILE: john_core/src/nonstd.c:1788:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#1788: FILE: john_core/src/nonstd.c:1788:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

WARNING: storage class should be at the beginning of the declaration
#1860: FILE: john_core/src/nonstd.c:1860:
+MAYBE_INLINE static void

WARNING: please, no spaces at the start of a line
#1862: FILE: john_core/src/nonstd.c:1862:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)$

ERROR: "foo * bar" should be "foo *bar"
#1862: FILE: john_core/src/nonstd.c:1862:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#1862: FILE: john_core/src/nonstd.c:1862:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#1862: FILE: john_core/src/nonstd.c:1862:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#1862: FILE: john_core/src/nonstd.c:1862:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

WARNING: storage class should be at the beginning of the declaration
#1934: FILE: john_core/src/nonstd.c:1934:
+MAYBE_INLINE static void

WARNING: please, no spaces at the start of a line
#1936: FILE: john_core/src/nonstd.c:1936:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)$

ERROR: "foo * bar" should be "foo *bar"
#1936: FILE: john_core/src/nonstd.c:1936:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#1936: FILE: john_core/src/nonstd.c:1936:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#1936: FILE: john_core/src/nonstd.c:1936:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#1936: FILE: john_core/src/nonstd.c:1936:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

WARNING: storage class should be at the beginning of the declaration
#2008: FILE: john_core/src/nonstd.c:2008:
+MAYBE_INLINE static void

WARNING: please, no spaces at the start of a line
#2010: FILE: john_core/src/nonstd.c:2010:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)$

ERROR: "foo * bar" should be "foo *bar"
#2010: FILE: john_core/src/nonstd.c:2010:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#2010: FILE: john_core/src/nonstd.c:2010:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#2010: FILE: john_core/src/nonstd.c:2010:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#2010: FILE: john_core/src/nonstd.c:2010:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

WARNING: storage class should be at the beginning of the declaration
#2082: FILE: john_core/src/nonstd.c:2082:
+MAYBE_INLINE static void

WARNING: please, no spaces at the start of a line
#2084: FILE: john_core/src/nonstd.c:2084:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)$

ERROR: "foo * bar" should be "foo *bar"
#2084: FILE: john_core/src/nonstd.c:2084:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#2084: FILE: john_core/src/nonstd.c:2084:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#2084: FILE: john_core/src/nonstd.c:2084:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#2084: FILE: john_core/src/nonstd.c:2084:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

WARNING: storage class should be at the beginning of the declaration
#2156: FILE: john_core/src/nonstd.c:2156:
+MAYBE_INLINE static void

WARNING: please, no spaces at the start of a line
#2158: FILE: john_core/src/nonstd.c:2158:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)$

ERROR: "foo * bar" should be "foo *bar"
#2158: FILE: john_core/src/nonstd.c:2158:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#2158: FILE: john_core/src/nonstd.c:2158:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#2158: FILE: john_core/src/nonstd.c:2158:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#2158: FILE: john_core/src/nonstd.c:2158:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

WARNING: storage class should be at the beginning of the declaration
#2230: FILE: john_core/src/nonstd.c:2230:
+MAYBE_INLINE static void

WARNING: please, no spaces at the start of a line
#2232: FILE: john_core/src/nonstd.c:2232:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)$

ERROR: "foo * bar" should be "foo *bar"
#2232: FILE: john_core/src/nonstd.c:2232:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#2232: FILE: john_core/src/nonstd.c:2232:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#2232: FILE: john_core/src/nonstd.c:2232:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#2232: FILE: john_core/src/nonstd.c:2232:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

WARNING: storage class should be at the beginning of the declaration
#2304: FILE: john_core/src/nonstd.c:2304:
+MAYBE_INLINE static void

WARNING: please, no spaces at the start of a line
#2306: FILE: john_core/src/nonstd.c:2306:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)$

ERROR: "foo * bar" should be "foo *bar"
#2306: FILE: john_core/src/nonstd.c:2306:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#2306: FILE: john_core/src/nonstd.c:2306:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#2306: FILE: john_core/src/nonstd.c:2306:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#2306: FILE: john_core/src/nonstd.c:2306:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

WARNING: storage class should be at the beginning of the declaration
#2378: FILE: john_core/src/nonstd.c:2378:
+MAYBE_INLINE static void

WARNING: please, no spaces at the start of a line
#2380: FILE: john_core/src/nonstd.c:2380:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)$

ERROR: "foo * bar" should be "foo *bar"
#2380: FILE: john_core/src/nonstd.c:2380:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#2380: FILE: john_core/src/nonstd.c:2380:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#2380: FILE: john_core/src/nonstd.c:2380:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#2380: FILE: john_core/src/nonstd.c:2380:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

WARNING: storage class should be at the beginning of the declaration
#2452: FILE: john_core/src/nonstd.c:2452:
+MAYBE_INLINE static void

WARNING: please, no spaces at the start of a line
#2454: FILE: john_core/src/nonstd.c:2454:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)$

ERROR: "foo * bar" should be "foo *bar"
#2454: FILE: john_core/src/nonstd.c:2454:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#2454: FILE: john_core/src/nonstd.c:2454:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#2454: FILE: john_core/src/nonstd.c:2454:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#2454: FILE: john_core/src/nonstd.c:2454:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

WARNING: storage class should be at the beginning of the declaration
#2526: FILE: john_core/src/nonstd.c:2526:
+MAYBE_INLINE static void

WARNING: please, no spaces at the start of a line
#2528: FILE: john_core/src/nonstd.c:2528:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)$

ERROR: "foo * bar" should be "foo *bar"
#2528: FILE: john_core/src/nonstd.c:2528:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#2528: FILE: john_core/src/nonstd.c:2528:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#2528: FILE: john_core/src/nonstd.c:2528:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#2528: FILE: john_core/src/nonstd.c:2528:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

WARNING: storage class should be at the beginning of the declaration
#2601: FILE: john_core/src/nonstd.c:2601:
+MAYBE_INLINE static void

WARNING: please, no spaces at the start of a line
#2603: FILE: john_core/src/nonstd.c:2603:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)$

ERROR: "foo * bar" should be "foo *bar"
#2603: FILE: john_core/src/nonstd.c:2603:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#2603: FILE: john_core/src/nonstd.c:2603:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#2603: FILE: john_core/src/nonstd.c:2603:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#2603: FILE: john_core/src/nonstd.c:2603:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

WARNING: storage class should be at the beginning of the declaration
#2676: FILE: john_core/src/nonstd.c:2676:
+MAYBE_INLINE static void

WARNING: please, no spaces at the start of a line
#2678: FILE: john_core/src/nonstd.c:2678:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)$

ERROR: "foo * bar" should be "foo *bar"
#2678: FILE: john_core/src/nonstd.c:2678:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#2678: FILE: john_core/src/nonstd.c:2678:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#2678: FILE: john_core/src/nonstd.c:2678:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#2678: FILE: john_core/src/nonstd.c:2678:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

WARNING: storage class should be at the beginning of the declaration
#2753: FILE: john_core/src/nonstd.c:2753:
+MAYBE_INLINE static void

WARNING: please, no spaces at the start of a line
#2755: FILE: john_core/src/nonstd.c:2755:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)$

ERROR: "foo * bar" should be "foo *bar"
#2755: FILE: john_core/src/nonstd.c:2755:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#2755: FILE: john_core/src/nonstd.c:2755:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#2755: FILE: john_core/src/nonstd.c:2755:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#2755: FILE: john_core/src/nonstd.c:2755:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

WARNING: storage class should be at the beginning of the declaration
#2820: FILE: john_core/src/nonstd.c:2820:
+MAYBE_INLINE static void

WARNING: please, no spaces at the start of a line
#2822: FILE: john_core/src/nonstd.c:2822:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)$

ERROR: "foo * bar" should be "foo *bar"
#2822: FILE: john_core/src/nonstd.c:2822:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#2822: FILE: john_core/src/nonstd.c:2822:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#2822: FILE: john_core/src/nonstd.c:2822:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#2822: FILE: john_core/src/nonstd.c:2822:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

WARNING: storage class should be at the beginning of the declaration
#2887: FILE: john_core/src/nonstd.c:2887:
+MAYBE_INLINE static void

WARNING: please, no spaces at the start of a line
#2889: FILE: john_core/src/nonstd.c:2889:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)$

ERROR: "foo * bar" should be "foo *bar"
#2889: FILE: john_core/src/nonstd.c:2889:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#2889: FILE: john_core/src/nonstd.c:2889:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#2889: FILE: john_core/src/nonstd.c:2889:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#2889: FILE: john_core/src/nonstd.c:2889:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

WARNING: storage class should be at the beginning of the declaration
#2955: FILE: john_core/src/nonstd.c:2955:
+MAYBE_INLINE static void

WARNING: please, no spaces at the start of a line
#2957: FILE: john_core/src/nonstd.c:2957:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)$

ERROR: "foo * bar" should be "foo *bar"
#2957: FILE: john_core/src/nonstd.c:2957:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#2957: FILE: john_core/src/nonstd.c:2957:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#2957: FILE: john_core/src/nonstd.c:2957:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#2957: FILE: john_core/src/nonstd.c:2957:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

WARNING: storage class should be at the beginning of the declaration
#3022: FILE: john_core/src/nonstd.c:3022:
+MAYBE_INLINE static void

WARNING: please, no spaces at the start of a line
#3024: FILE: john_core/src/nonstd.c:3024:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)$

ERROR: "foo * bar" should be "foo *bar"
#3024: FILE: john_core/src/nonstd.c:3024:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#3024: FILE: john_core/src/nonstd.c:3024:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#3024: FILE: john_core/src/nonstd.c:3024:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#3024: FILE: john_core/src/nonstd.c:3024:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

total: 164 errors, 82 warnings, 3087 lines checked

john_core/src/nonstd.c has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
WARNING: Missing a blank line after declarations
#139: FILE: john_core/src/options.c:139:
+		int length = strlen(label) + (format->next != NULL);
+		column += length;

WARNING: Missing a blank line after declarations
#214: FILE: john_core/src/options.c:214:
+			unsigned int i;
+			for (i = 2; i <= options.fork; i++) {

WARNING: suspect code indent for conditional statements (8, 8)
#232: FILE: john_core/src/options.c:232:
+	if (options.flags & FLG_SALTS)
+	if (options.loader.min_pps < 0) {

ERROR: trailing statements should be on next line
#246: FILE: john_core/src/options.c:246:
+	if (options.flags & FLG_STDOUT) options.flags &= ~FLG_PWD_REQ;

WARNING: Missing a blank line after declarations
#259: FILE: john_core/src/options.c:259:
+		int n;
+		if ((n = sscanf(options.node_str, "%u-%u/%u",

ERROR: do not use assignment in if condition
#259: FILE: john_core/src/options.c:259:
+		if ((n = sscanf(options.node_str, "%u-%u/%u",

WARNING: quoted string split across lines
#304: FILE: john_core/src/options.c:304:
+		fprintf(stderr, "Password files required, "
+			"but none specified\n");

WARNING: quoted string split across lines
#310: FILE: john_core/src/options.c:310:
+		fprintf(stderr, "Password files specified, "
+			"but no option would use them\n");

total: 2 errors, 6 warnings, 316 lines checked

john_core/src/options.c has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 0 warnings, 31 lines checked

john_core/src/params.c has no obvious style problems and is ready for submission.
ERROR: do not initialise statics to 0 or NULL
#18: FILE: john_core/src/path.c:18:
+static char *john_home_path = NULL;

ERROR: do not initialise statics to 0 or NULL
#28: FILE: john_core/src/path.c:28:
+static char *user_home_path = NULL;

ERROR: trailing statements should be on next line
#48: FILE: john_core/src/path.c:48:
+	if (user_home_path) return;

ERROR: trailing statements should be on next line
#51: FILE: john_core/src/path.c:51:
+	if (!pw) return;

ERROR: trailing statements should be on next line
#54: FILE: john_core/src/path.c:54:
+	if (user_home_length >= PATH_BUFFER_SIZE) return;

ERROR: trailing statements should be on next line
#63: FILE: john_core/src/path.c:63:
+		if (errno != EEXIST) pexit("mkdir: %s", private);

WARNING: suspect code indent for conditional statements (8, 8)
#68: FILE: john_core/src/path.c:68:
+	if (argv[0])
+	if (!john_home_path && (pos = strrchr(argv[0], '/'))) {

ERROR: do not use assignment in if condition
#69: FILE: john_core/src/path.c:69:
+	if (!john_home_path && (pos = strrchr(argv[0], '/'))) {

ERROR: trailing statements should be on next line
#71: FILE: john_core/src/path.c:71:
+		if (john_home_length >= PATH_BUFFER_SIZE) return;

ERROR: do not use assignment in if condition
#113: FILE: john_core/src/path.c:113:
+	if ((p = strchr(session, '.')))

total: 9 errors, 1 warnings, 136 lines checked

john_core/src/path.c has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
WARNING: externs should be avoided in .c files
#29: FILE: john_core/src/recovery.c:29:
+extern int ftruncate(int fd, size_t length);

ERROR: do not initialise statics to 0 or NULL
#53: FILE: john_core/src/recovery.c:53:
+static FILE *rec_file = NULL;

WARNING: Missing a blank line after declarations
#64: FILE: john_core/src/recovery.c:64:
+		char *suffix = mem_alloc(1 + 20 + strlen(RECOVERY_SUFFIX) + 1);
+		sprintf(suffix, ".%u%s", options.node_min, RECOVERY_SUFFIX);

ERROR: trailing statements should be on next line
#102: FILE: john_core/src/recovery.c:102:
+	if (!rec_argc) return;

ERROR: do not use assignment in if condition
#106: FILE: john_core/src/recovery.c:106:
+	if ((rec_fd = open(path_expand(rec_name), O_RDWR | O_CREAT, 0600)) < 0)

ERROR: do not use assignment in if condition
#109: FILE: john_core/src/recovery.c:109:
+	if (!(rec_file = fdopen(rec_fd, "w"))) pexit("fdopen");

ERROR: trailing statements should be on next line
#109: FILE: john_core/src/recovery.c:109:
+	if (!(rec_file = fdopen(rec_fd, "w"))) pexit("fdopen");

ERROR: trailing statements should be on next line
#123: FILE: john_core/src/recovery.c:123:
+	if (!rec_file) return;

ERROR: trailing statements should be on next line
#125: FILE: john_core/src/recovery.c:125:
+	if (fseek(rec_file, 0, SEEK_SET)) pexit("fseek");

ERROR: trailing statements should be on next line
#127: FILE: john_core/src/recovery.c:127:
+	if (ftruncate(rec_fd, 0)) pexit("ftruncate");

ERROR: trailing statements should be on next line
#159: FILE: john_core/src/recovery.c:159:
+	if (rec_save_mode) rec_save_mode(rec_file);

ERROR: trailing statements should be on next line
#161: FILE: john_core/src/recovery.c:161:
+	if (ferror(rec_file)) pexit("fprintf");

ERROR: do not use assignment in if condition
#163: FILE: john_core/src/recovery.c:163:
+	if ((size = ftell(rec_file)) < 0) pexit("ftell");

ERROR: trailing statements should be on next line
#163: FILE: john_core/src/recovery.c:163:
+	if ((size = ftell(rec_file)) < 0) pexit("ftell");

ERROR: trailing statements should be on next line
#164: FILE: john_core/src/recovery.c:164:
+	if (fflush(rec_file)) pexit("fflush");

ERROR: trailing statements should be on next line
#165: FILE: john_core/src/recovery.c:165:
+	if (ftruncate(rec_fd, size)) pexit("ftruncate");

ERROR: do not use assignment in if condition
#220: FILE: john_core/src/recovery.c:220:
+	if (!(rec_file = fopen(path_expand(rec_name), "r+"))) {

ERROR: trailing statements should be on next line
#234: FILE: john_core/src/recovery.c:234:
+	if (lock) rec_lock();

ERROR: trailing statements should be on next line
#236: FILE: john_core/src/recovery.c:236:
+	if (!fgetl(line, sizeof(line), rec_file)) rec_format_error("fgets");

ERROR: trailing statements should be on next line
#239: FILE: john_core/src/recovery.c:239:
+	if (!strcmp(line, RECOVERY_V4)) rec_version = 4; else

ERROR: trailing statements should be on next line
#240: FILE: john_core/src/recovery.c:240:
+	if (!strcmp(line, RECOVERY_V3)) rec_version = 3; else

ERROR: trailing statements should be on next line
#241: FILE: john_core/src/recovery.c:241:
+	if (!strcmp(line, RECOVERY_V2)) rec_version = 2; else

ERROR: trailing statements should be on next line
#242: FILE: john_core/src/recovery.c:242:
+	if (!strcmp(line, RECOVERY_V1)) rec_version = 1; else

ERROR: trailing statements should be on next line
#243: FILE: john_core/src/recovery.c:243:
+	if (strcmp(line, RECOVERY_V0)) rec_format_error(NULL);

WARNING: suspect code indent for conditional statements (8, 8)
#253: FILE: john_core/src/recovery.c:253:
+	for (index = 1; index < argc; index++)
+	if (fgetl(line, sizeof(line), rec_file))

ERROR: trailing statements should be on next line
#313: FILE: john_core/src/recovery.c:313:
+	if (!rec_file) return;

WARNING: suspect code indent for conditional statements (8, 8)
#315: FILE: john_core/src/recovery.c:315:
+	if (restore_mode)
+	if (restore_mode(rec_file)) rec_format_error("fscanf");

ERROR: trailing statements should be on next line
#316: FILE: john_core/src/recovery.c:316:
+	if (restore_mode(rec_file)) rec_format_error("fscanf");

ERROR: trailing statements should be on next line
#328: FILE: john_core/src/recovery.c:328:
+	if (fclose(rec_file)) pexit("fclose");

total: 25 errors, 4 warnings, 332 lines checked

john_core/src/recovery.c has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
WARNING: suspect code indent for conditional statements (8, 8)
#17: FILE: john_core/src/rpp.c:17:
+	if ((list = cfg_get_list(SECTION_RULES, subsection)))
+	if ((ctx->input = list->head)) {

ERROR: do not use assignment in if condition
#17: FILE: john_core/src/rpp.c:17:
+	if ((list = cfg_get_list(SECTION_RULES, subsection)))

ERROR: do not use assignment in if condition
#18: FILE: john_core/src/rpp.c:18:
+	if ((ctx->input = list->head)) {

ERROR: trailing statements should be on next line
#29: FILE: john_core/src/rpp.c:29:
+		if (range->count >= 0x100) return;

ERROR: trailing statements should be on next line
#34: FILE: john_core/src/rpp.c:34:
+		if (range->mask[index] & mask) return;

WARNING: suspect code indent for conditional statements (8, 8)
#55: FILE: john_core/src/rpp.c:55:
+	while (*input && output < end)
+	switch (*input) {

ERROR: do not use assignment in if condition
#58: FILE: john_core/src/rpp.c:58:
+		if (!(c = *++input)) break;

ERROR: trailing statements should be on next line
#58: FILE: john_core/src/rpp.c:58:
+		if (!(c = *++input)) break;

WARNING: Missing a blank line after declarations
#63: FILE: john_core/src/rpp.c:63:
+			struct rpp_ref *ref = &ctx->refs[ctx->refs_count++];
+			ref->pos = (char *)output;

WARNING: suspect code indent for conditional statements (16, 16)
#67: FILE: john_core/src/rpp.c:67:
+		if (ctx->count < RULE_RANGES_MAX)
+		switch (c) {

ERROR: do not use assignment in if condition
#70: FILE: john_core/src/rpp.c:70:
+			if ((c2 = *input) == '[' || c2 == '\\') {

WARNING: suspect code indent for conditional statements (16, 16)
#107: FILE: john_core/src/rpp.c:107:
+		while (*input && *input != ']')
+		switch (*input) {

ERROR: trailing statements should be on next line
#110: FILE: john_core/src/rpp.c:110:
+			if (*++input) rpp_add_char(range, c1 = *input++);

ERROR: do not use assignment in if condition
#114: FILE: john_core/src/rpp.c:114:
+			if ((c2 = *++input)) {

WARNING: Too many leading tabs - consider code refactoring
#118: FILE: john_core/src/rpp.c:118:
+						for (c = c1 - 1; c >= c2; c--)

WARNING: Too many leading tabs - consider code refactoring
#121: FILE: john_core/src/rpp.c:121:
+						for (c = c1 + 1; c <= c2; c++)

ERROR: trailing statements should be on next line
#131: FILE: john_core/src/rpp.c:131:
+		if (*input) input++;

ERROR: trailing statements should be on next line
#148: FILE: john_core/src/rpp.c:148:
+		if (!ctx->input) return NULL;

ERROR: do not use assignment in if condition
#153: FILE: john_core/src/rpp.c:153:
+	if ((index = ctx->count - 1) >= 0) {

WARNING: Missing a blank line after declarations
#190: FILE: john_core/src/rpp.c:190:
+		int ref_index = ctx->refs_count - 1;
+		do {

total: 12 errors, 8 warnings, 205 lines checked

john_core/src/rpp.c has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
ERROR: do not initialise statics to 0 or NULL
#55: FILE: john_core/src/rules.c:55:
+static int rules_max_length = 0;

WARNING: Avoid line continuations in quoted strings
#98: FILE: john_core/src/rules.c:98:
+	"~!@...^&*()_+|QWERTYUIOP{}ASDFGHJKL:\"ZXCVBNM<>?" \

WARNING: Macros with flow control statements should be avoided
#131: FILE: john_core/src/rules.c:131:
+#define REJECT { \
+	if (!rules_pass) goto out_NULL; \
+}
+

ERROR: trailing statements should be on next line
#132: FILE: john_core/src/rules.c:132:
+	if (!rules_pass) goto out_NULL; \

WARNING: Macros with flow control statements should be avoided
#135: FILE: john_core/src/rules.c:135:
+#define VALUE(value) { \
+	if (!((value) = RULE)) goto out_ERROR_END; \
+}
+

ERROR: do not use assignment in if condition
#136: FILE: john_core/src/rules.c:136:
+	if (!((value) = RULE)) goto out_ERROR_END; \

ERROR: trailing statements should be on next line
#136: FILE: john_core/src/rules.c:136:
+	if (!((value) = RULE)) goto out_ERROR_END; \

WARNING: Macros with flow control statements should be avoided
#139: FILE: john_core/src/rules.c:139:
+#define POSITION(pos) { \
+	if (((pos) = rules_vars[ARCH_INDEX(RULE)]) == INVALID_LENGTH) \
+		goto out_ERROR_POSITION; \
+}
+

ERROR: do not use assignment in if condition
#140: FILE: john_core/src/rules.c:140:
+	if (((pos) = rules_vars[ARCH_INDEX(RULE)]) == INVALID_LENGTH) \

WARNING: Macros with flow control statements should be avoided
#144: FILE: john_core/src/rules.c:144:
+#define CLASS_export_pos(start, true, false) { \
+	char value, *class; \
+	if ((value = RULE) == '?') { \
+		if (!(class = rules_classes[ARCH_INDEX(RULE)])) \
+			goto out_ERROR_CLASS; \
+		for (pos = (start); ARCH_INDEX(in[pos]); pos++) \
+		if (class[ARCH_INDEX(in[pos])]) { \
+			true; \
+		} else { \
+			false; \
+		} \
+	} else { \
+		if (!value) goto out_ERROR_END; \
+		for (pos = (start); ARCH_INDEX(in[pos]); pos++) \
+		if (in[pos] == value) { \
+			true; \
+		} else { \
+			false; \
+		} \
+	} \
+}
+

ERROR: do not use assignment in if condition
#146: FILE: john_core/src/rules.c:146:
+	if ((value = RULE) == '?') { \

ERROR: do not use assignment in if condition
#147: FILE: john_core/src/rules.c:147:
+		if (!(class = rules_classes[ARCH_INDEX(RULE)])) \

WARNING: suspect code indent for conditional statements (16, 16)
#149: FILE: john_core/src/rules.c:149:
+		for (pos = (start); ARCH_INDEX(in[pos]); pos++) \
+		if (class[ARCH_INDEX(in[pos])]) { \

ERROR: trailing statements should be on next line
#156: FILE: john_core/src/rules.c:156:
+		if (!value) goto out_ERROR_END; \

WARNING: suspect code indent for conditional statements (16, 16)
#157: FILE: john_core/src/rules.c:157:
+		for (pos = (start); ARCH_INDEX(in[pos]); pos++) \
+		if (in[pos] == value) { \

ERROR: trailing statements should be on next line
#174: FILE: john_core/src/rules.c:174:
+	if (value == '?') VALUE(value) \

ERROR: trailing statements should be on next line
#179: FILE: john_core/src/rules.c:179:
+	for (pos = 0; (in[pos] = (conv)[ARCH_INDEX(in[pos])]); pos++); \

ERROR: trailing statements should be on next line
#231: FILE: john_core/src/rules.c:231:
+	for (pos = 0; pos < 0x100; pos++) conv[pos] = pos;

ERROR: trailing statements should be on next line
#257: FILE: john_core/src/rules.c:257:
+	for (c = '0'; c <= '9'; c++) rules_vars[c] = c - '0';

ERROR: trailing statements should be on next line
#258: FILE: john_core/src/rules.c:258:
+	for (c = 'A'; c <= 'Z'; c++) rules_vars[c] = c - ('A' - 10);

ERROR: trailing statements should be on next line
#275: FILE: john_core/src/rules.c:275:
+	if (max_length == rules_max_length) return;

WARNING: suspect code indent for conditional statements (8, 8)
#288: FILE: john_core/src/rules.c:288:
+	while (RULE)
+	switch (LAST) {

ERROR: trailing statements should be on next line
#301: FILE: john_core/src/rules.c:301:
+			if (!db) continue;

ERROR: trailing statements should be on next line
#302: FILE: john_core/src/rules.c:302:
+			if (db->format->params.flags & FMT_CASE) continue;

ERROR: trailing statements should be on next line
#306: FILE: john_core/src/rules.c:306:
+			if (!db) continue;

ERROR: trailing statements should be on next line
#307: FILE: john_core/src/rules.c:307:
+			if (db->format->params.flags & FMT_8_BIT) continue;

ERROR: trailing statements should be on next line
#311: FILE: john_core/src/rules.c:311:
+			if (!db) continue;

ERROR: trailing statements should be on next line
#312: FILE: john_core/src/rules.c:312:
+			if (db->options->flags & DB_SPLIT) continue;

ERROR: trailing statements should be on next line
#316: FILE: john_core/src/rules.c:316:
+			if (split >= 0) continue;

ERROR: do not use assignment in if condition
#353: FILE: john_core/src/rules.c:353:
+		if (!(in[length] = word[length]))

ERROR: trailing statements should be on next line
#365: FILE: john_core/src/rules.c:365:
+	if (!length) REJECT

WARNING: Missing a blank line after declarations
#397: FILE: john_core/src/rules.c:397:
+				int pos;
+				POSITION(pos)

ERROR: trailing statements should be on next line
#398: FILE: john_core/src/rules.c:398:
+				if (length >= pos) REJECT

WARNING: Missing a blank line after declarations
#405: FILE: john_core/src/rules.c:405:
+				int pos;
+				POSITION(pos)

ERROR: trailing statements should be on next line
#406: FILE: john_core/src/rules.c:406:
+				if (length <= pos) REJECT

WARNING: Missing a blank line after declarations
#421: FILE: john_core/src/rules.c:421:
+				int pos = 0;
+				if ((in[0] = conv_toupper[ARCH_INDEX(in[0])]))

WARNING: suspect code indent for conditional statements (32, 32)
#421: FILE: john_core/src/rules.c:421:
+				if ((in[0] = conv_toupper[ARCH_INDEX(in[0])]))
+				while (in[++pos])

ERROR: do not use assignment in if condition
#421: FILE: john_core/src/rules.c:421:
+				if ((in[0] = conv_toupper[ARCH_INDEX(in[0])]))

WARNING: Missing a blank line after declarations
#435: FILE: john_core/src/rules.c:435:
+				char *out;
+				GET_OUT

WARNING: Missing a blank line after declarations
#451: FILE: john_core/src/rules.c:451:
+				int pos;
+				in[pos = (length <<= 1)] = 0;

WARNING: Missing a blank line after declarations
#454: FILE: john_core/src/rules.c:454:
+					char *p = in;
+					while (*p)

ERROR: that open brace { should be on the previous line
#461: FILE: john_core/src/rules.c:461:
+			if (length < 2) break;
+			{

ERROR: trailing statements should be on next line
#461: FILE: john_core/src/rules.c:461:
+			if (length < 2) break;

WARNING: Missing a blank line after declarations
#464: FILE: john_core/src/rules.c:464:
+				int pos = length - 1;
+				if (strchr("sxz", in[pos]) ||

WARNING: Missing a blank line after declarations
#495: FILE: john_core/src/rules.c:495:
+				char *out;
+				GET_OUT

WARNING: Missing a blank line after declarations
#506: FILE: john_core/src/rules.c:506:
+				int pos;
+				POSITION(pos)

WARNING: Missing a blank line after declarations
#509: FILE: john_core/src/rules.c:509:
+					char *out;
+					GET_OUT

WARNING: Missing a blank line after declarations
#524: FILE: john_core/src/rules.c:524:
+				int pos;
+				POSITION(pos)

WARNING: Missing a blank line after declarations
#527: FILE: john_core/src/rules.c:527:
+					char *p = in + pos;
+					memmove(p + 1, p, length++ - pos);

WARNING: Missing a blank line after declarations
#541: FILE: john_core/src/rules.c:541:
+				char value;
+				POSITION(pos)

WARNING: Missing a blank line after declarations
#552: FILE: john_core/src/rules.c:552:
+				char value;
+				VALUE(value)

WARNING: Missing a blank line after declarations
#569: FILE: john_core/src/rules.c:569:
+				int pos;
+				CLASS_export_pos(0, break, {})

ERROR: trailing statements should be on next line
#571: FILE: john_core/src/rules.c:571:
+				if (in[pos]) break;

WARNING: Missing a blank line after declarations
#579: FILE: john_core/src/rules.c:579:
+				int pos;
+				POSITION(pos)

WARNING: Missing a blank line after declarations
#593: FILE: john_core/src/rules.c:593:
+				char *out;
+				GET_OUT

WARNING: externs should be avoided in .c files
#593: FILE: john_core/src/rules.c:593:
+				GET_OUT

WARNING: Missing a blank line after declarations
#610: FILE: john_core/src/rules.c:610:
+				int pos = 0;
+				if ((in[0] = conv_tolower[ARCH_INDEX(in[0])]))

WARNING: suspect code indent for conditional statements (32, 32)
#610: FILE: john_core/src/rules.c:610:
+				if ((in[0] = conv_tolower[ARCH_INDEX(in[0])]))
+				while (in[++pos])

ERROR: do not use assignment in if condition
#610: FILE: john_core/src/rules.c:610:
+				if ((in[0] = conv_tolower[ARCH_INDEX(in[0])]))

WARNING: Missing a blank line after declarations
#640: FILE: john_core/src/rules.c:640:
+				int pos;
+				POSITION(pos)

WARNING: Missing a blank line after declarations
#649: FILE: john_core/src/rules.c:649:
+				int count = 0, required, pos;
+				POSITION(required)

ERROR: trailing statements should be on next line
#651: FILE: john_core/src/rules.c:651:
+				    if (++count >= required) break, {})

ERROR: trailing statements should be on next line
#652: FILE: john_core/src/rules.c:652:
+				if (count < required) REJECT

WARNING: Missing a blank line after declarations
#662: FILE: john_core/src/rules.c:662:
+				char term;
+				POSITION(pos)

WARNING: Missing a blank line after declarations
#666: FILE: john_core/src/rules.c:666:
+					char *start, *end, *p;
+					start = p = &in[pos = length];

WARNING: Missing a blank line after declarations
#670: FILE: john_core/src/rules.c:670:
+						char c = RULE;
+						if (c == term)

WARNING: Too many leading tabs - consider code refactoring
#670: FILE: john_core/src/rules.c:670:
+						if (c == term)

WARNING: Too many leading tabs - consider code refactoring
#672: FILE: john_core/src/rules.c:672:
+						if (p < end)

WARNING: Too many leading tabs - consider code refactoring
#674: FILE: john_core/src/rules.c:674:
+						if (c)

WARNING: Missing a blank line after declarations
#685: FILE: john_core/src/rules.c:685:
+					char *out, *start, *end, *p;
+					GET_OUT

WARNING: externs should be avoided in .c files
#685: FILE: john_core/src/rules.c:685:
+					GET_OUT

WARNING: Missing a blank line after declarations
#691: FILE: john_core/src/rules.c:691:
+						char c = RULE;
+						if (c == term)

WARNING: Too many leading tabs - consider code refactoring
#691: FILE: john_core/src/rules.c:691:
+						if (c == term)

WARNING: Too many leading tabs - consider code refactoring
#693: FILE: john_core/src/rules.c:693:
+						if (p < end)

WARNING: Too many leading tabs - consider code refactoring
#695: FILE: john_core/src/rules.c:695:
+						if (c)

WARNING: Missing a blank line after declarations
#709: FILE: john_core/src/rules.c:709:
+				int pos;
+				POSITION(pos)

WARNING: Missing a blank line after declarations
#717: FILE: john_core/src/rules.c:717:
+				int pos;
+				POSITION(pos)

WARNING: Missing a blank line after declarations
#720: FILE: john_core/src/rules.c:720:
+					char *out;
+					GET_OUT

WARNING: externs should be avoided in .c files
#720: FILE: john_core/src/rules.c:720:
+					GET_OUT

WARNING: Missing a blank line after declarations
#732: FILE: john_core/src/rules.c:732:
+				char *out;
+				GET_OUT

WARNING: externs should be avoided in .c files
#732: FILE: john_core/src/rules.c:732:
+				GET_OUT

WARNING: Missing a blank line after declarations
#746: FILE: john_core/src/rules.c:746:
+				int pos;
+				GET_OUT

WARNING: Missing a blank line after declarations
#775: FILE: john_core/src/rules.c:775:
+				int pos;
+				if ((pos = length - 1) < 2) break;

ERROR: do not use assignment in if condition
#775: FILE: john_core/src/rules.c:775:
+				if ((pos = length - 1) < 2) break;

ERROR: trailing statements should be on next line
#775: FILE: john_core/src/rules.c:775:
+				if ((pos = length - 1) < 2) break;

ERROR: trailing statements should be on next line
#776: FILE: john_core/src/rules.c:776:
+				if (in[pos] == 'd' && in[pos - 1] == 'e') break;

ERROR: trailing statements should be on next line
#777: FILE: john_core/src/rules.c:777:
+				if (in[pos] == 'y') in[pos] = 'i'; else

WARNING: Missing a blank line after declarations
#794: FILE: john_core/src/rules.c:794:
+				int pos;
+				if ((pos = length - 1) < 2) break;

ERROR: do not use assignment in if condition
#794: FILE: john_core/src/rules.c:794:
+				if ((pos = length - 1) < 2) break;

ERROR: trailing statements should be on next line
#794: FILE: john_core/src/rules.c:794:
+				if ((pos = length - 1) < 2) break;

ERROR: trailing statements should be on next line
#795: FILE: john_core/src/rules.c:795:
+				if (in[pos] == 'g' && in[pos - 1] == 'n' &&
+				    in[pos - 2] == 'i') break;

WARNING: Missing a blank line after declarations
#825: FILE: john_core/src/rules.c:825:
+				char *inp, *mp;
+				POSITION(mpos)

WARNING: Missing a blank line after declarations
#850: FILE: john_core/src/rules.c:850:
+				unsigned char a, s;
+				VALUE(var)

ERROR: trailing statements should be on next line
#864: FILE: john_core/src/rules.c:864:
+			if (!split) REJECT

ERROR: trailing statements should be on next line
#881: FILE: john_core/src/rules.c:881:
+			if (!split) REJECT

WARNING: Missing a blank line after declarations
#904: FILE: john_core/src/rules.c:904:
+					char *out;
+					GET_OUT

WARNING: externs should be avoided in .c files
#904: FILE: john_core/src/rules.c:904:
+					GET_OUT

ERROR: trailing statements should be on next line
#922: FILE: john_core/src/rules.c:922:
+		if (!length) REJECT

ERROR: trailing statements should be on next line
#1006: FILE: john_core/src/rules.c:1006:
+		if (rules_errno) break;

ERROR: trailing statements should be on next line
#1008: FILE: john_core/src/rules.c:1008:
+		if (ctx.input) rules_line = ctx.input->number;

ERROR: do not use assignment in if condition
#1020: FILE: john_core/src/rules.c:1020:
+	if (!(count = rules_check(start, split))) {

total: 45 errors, 56 warnings, 1030 lines checked

john_core/src/rules.c has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 0 warnings, 3 lines checked

john_core/src/sboxes.c has no obvious style problems and is ready for submission.
WARNING: storage class should be at the beginning of the declaration
#44: FILE: john_core/src/sboxes-s.c:44:
+MAYBE_INLINE static void

WARNING: please, no spaces at the start of a line
#46: FILE: john_core/src/sboxes-s.c:46:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)$

ERROR: "foo * bar" should be "foo *bar"
#46: FILE: john_core/src/sboxes-s.c:46:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#46: FILE: john_core/src/sboxes-s.c:46:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#46: FILE: john_core/src/sboxes-s.c:46:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#46: FILE: john_core/src/sboxes-s.c:46:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

WARNING: storage class should be at the beginning of the declaration
#109: FILE: john_core/src/sboxes-s.c:109:
+MAYBE_INLINE static void

WARNING: please, no spaces at the start of a line
#111: FILE: john_core/src/sboxes-s.c:111:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)$

ERROR: "foo * bar" should be "foo *bar"
#111: FILE: john_core/src/sboxes-s.c:111:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#111: FILE: john_core/src/sboxes-s.c:111:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#111: FILE: john_core/src/sboxes-s.c:111:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#111: FILE: john_core/src/sboxes-s.c:111:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

WARNING: storage class should be at the beginning of the declaration
#176: FILE: john_core/src/sboxes-s.c:176:
+MAYBE_INLINE static void

WARNING: please, no spaces at the start of a line
#178: FILE: john_core/src/sboxes-s.c:178:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)$

ERROR: "foo * bar" should be "foo *bar"
#178: FILE: john_core/src/sboxes-s.c:178:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#178: FILE: john_core/src/sboxes-s.c:178:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#178: FILE: john_core/src/sboxes-s.c:178:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#178: FILE: john_core/src/sboxes-s.c:178:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

WARNING: storage class should be at the beginning of the declaration
#237: FILE: john_core/src/sboxes-s.c:237:
+MAYBE_INLINE static void

WARNING: please, no spaces at the start of a line
#239: FILE: john_core/src/sboxes-s.c:239:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)$

ERROR: "foo * bar" should be "foo *bar"
#239: FILE: john_core/src/sboxes-s.c:239:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#239: FILE: john_core/src/sboxes-s.c:239:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#239: FILE: john_core/src/sboxes-s.c:239:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#239: FILE: john_core/src/sboxes-s.c:239:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

WARNING: storage class should be at the beginning of the declaration
#298: FILE: john_core/src/sboxes-s.c:298:
+MAYBE_INLINE static void

WARNING: please, no spaces at the start of a line
#300: FILE: john_core/src/sboxes-s.c:300:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)$

ERROR: "foo * bar" should be "foo *bar"
#300: FILE: john_core/src/sboxes-s.c:300:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#300: FILE: john_core/src/sboxes-s.c:300:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#300: FILE: john_core/src/sboxes-s.c:300:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#300: FILE: john_core/src/sboxes-s.c:300:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

WARNING: storage class should be at the beginning of the declaration
#361: FILE: john_core/src/sboxes-s.c:361:
+MAYBE_INLINE static void

WARNING: please, no spaces at the start of a line
#363: FILE: john_core/src/sboxes-s.c:363:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)$

ERROR: "foo * bar" should be "foo *bar"
#363: FILE: john_core/src/sboxes-s.c:363:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#363: FILE: john_core/src/sboxes-s.c:363:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#363: FILE: john_core/src/sboxes-s.c:363:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#363: FILE: john_core/src/sboxes-s.c:363:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

WARNING: storage class should be at the beginning of the declaration
#422: FILE: john_core/src/sboxes-s.c:422:
+MAYBE_INLINE static void

WARNING: please, no spaces at the start of a line
#424: FILE: john_core/src/sboxes-s.c:424:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)$

ERROR: "foo * bar" should be "foo *bar"
#424: FILE: john_core/src/sboxes-s.c:424:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#424: FILE: john_core/src/sboxes-s.c:424:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#424: FILE: john_core/src/sboxes-s.c:424:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#424: FILE: john_core/src/sboxes-s.c:424:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

WARNING: storage class should be at the beginning of the declaration
#485: FILE: john_core/src/sboxes-s.c:485:
+MAYBE_INLINE static void

WARNING: please, no spaces at the start of a line
#487: FILE: john_core/src/sboxes-s.c:487:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)$

ERROR: "foo * bar" should be "foo *bar"
#487: FILE: john_core/src/sboxes-s.c:487:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#487: FILE: john_core/src/sboxes-s.c:487:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#487: FILE: john_core/src/sboxes-s.c:487:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#487: FILE: john_core/src/sboxes-s.c:487:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

WARNING: storage class should be at the beginning of the declaration
#536: FILE: john_core/src/sboxes-s.c:536:
+MAYBE_INLINE static void

WARNING: please, no spaces at the start of a line
#538: FILE: john_core/src/sboxes-s.c:538:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)$

ERROR: "foo * bar" should be "foo *bar"
#538: FILE: john_core/src/sboxes-s.c:538:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#538: FILE: john_core/src/sboxes-s.c:538:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#538: FILE: john_core/src/sboxes-s.c:538:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#538: FILE: john_core/src/sboxes-s.c:538:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

WARNING: storage class should be at the beginning of the declaration
#589: FILE: john_core/src/sboxes-s.c:589:
+MAYBE_INLINE static void

WARNING: please, no spaces at the start of a line
#591: FILE: john_core/src/sboxes-s.c:591:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)$

ERROR: "foo * bar" should be "foo *bar"
#591: FILE: john_core/src/sboxes-s.c:591:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#591: FILE: john_core/src/sboxes-s.c:591:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#591: FILE: john_core/src/sboxes-s.c:591:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#591: FILE: john_core/src/sboxes-s.c:591:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

WARNING: storage class should be at the beginning of the declaration
#652: FILE: john_core/src/sboxes-s.c:652:
+MAYBE_INLINE static void

WARNING: please, no spaces at the start of a line
#654: FILE: john_core/src/sboxes-s.c:654:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)$

ERROR: "foo * bar" should be "foo *bar"
#654: FILE: john_core/src/sboxes-s.c:654:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#654: FILE: john_core/src/sboxes-s.c:654:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#654: FILE: john_core/src/sboxes-s.c:654:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#654: FILE: john_core/src/sboxes-s.c:654:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

WARNING: storage class should be at the beginning of the declaration
#715: FILE: john_core/src/sboxes-s.c:715:
+MAYBE_INLINE static void

WARNING: please, no spaces at the start of a line
#717: FILE: john_core/src/sboxes-s.c:717:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)$

ERROR: "foo * bar" should be "foo *bar"
#717: FILE: john_core/src/sboxes-s.c:717:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#717: FILE: john_core/src/sboxes-s.c:717:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#717: FILE: john_core/src/sboxes-s.c:717:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#717: FILE: john_core/src/sboxes-s.c:717:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

WARNING: storage class should be at the beginning of the declaration
#778: FILE: john_core/src/sboxes-s.c:778:
+MAYBE_INLINE static void

WARNING: please, no spaces at the start of a line
#780: FILE: john_core/src/sboxes-s.c:780:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)$

ERROR: "foo * bar" should be "foo *bar"
#780: FILE: john_core/src/sboxes-s.c:780:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#780: FILE: john_core/src/sboxes-s.c:780:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#780: FILE: john_core/src/sboxes-s.c:780:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#780: FILE: john_core/src/sboxes-s.c:780:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

WARNING: storage class should be at the beginning of the declaration
#841: FILE: john_core/src/sboxes-s.c:841:
+MAYBE_INLINE static void

WARNING: please, no spaces at the start of a line
#843: FILE: john_core/src/sboxes-s.c:843:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)$

ERROR: "foo * bar" should be "foo *bar"
#843: FILE: john_core/src/sboxes-s.c:843:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#843: FILE: john_core/src/sboxes-s.c:843:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#843: FILE: john_core/src/sboxes-s.c:843:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#843: FILE: john_core/src/sboxes-s.c:843:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

WARNING: storage class should be at the beginning of the declaration
#906: FILE: john_core/src/sboxes-s.c:906:
+MAYBE_INLINE static void

WARNING: please, no spaces at the start of a line
#908: FILE: john_core/src/sboxes-s.c:908:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)$

ERROR: "foo * bar" should be "foo *bar"
#908: FILE: john_core/src/sboxes-s.c:908:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#908: FILE: john_core/src/sboxes-s.c:908:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#908: FILE: john_core/src/sboxes-s.c:908:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#908: FILE: john_core/src/sboxes-s.c:908:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

WARNING: storage class should be at the beginning of the declaration
#968: FILE: john_core/src/sboxes-s.c:968:
+MAYBE_INLINE static void

WARNING: please, no spaces at the start of a line
#970: FILE: john_core/src/sboxes-s.c:970:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)$

ERROR: "foo * bar" should be "foo *bar"
#970: FILE: john_core/src/sboxes-s.c:970:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#970: FILE: john_core/src/sboxes-s.c:970:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#970: FILE: john_core/src/sboxes-s.c:970:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#970: FILE: john_core/src/sboxes-s.c:970:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

WARNING: storage class should be at the beginning of the declaration
#1030: FILE: john_core/src/sboxes-s.c:1030:
+MAYBE_INLINE static void

WARNING: please, no spaces at the start of a line
#1032: FILE: john_core/src/sboxes-s.c:1032:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)$

ERROR: "foo * bar" should be "foo *bar"
#1032: FILE: john_core/src/sboxes-s.c:1032:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#1032: FILE: john_core/src/sboxes-s.c:1032:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#1032: FILE: john_core/src/sboxes-s.c:1032:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#1032: FILE: john_core/src/sboxes-s.c:1032:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

WARNING: storage class should be at the beginning of the declaration
#1092: FILE: john_core/src/sboxes-s.c:1092:
+MAYBE_INLINE static void

WARNING: please, no spaces at the start of a line
#1094: FILE: john_core/src/sboxes-s.c:1094:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)$

ERROR: "foo * bar" should be "foo *bar"
#1094: FILE: john_core/src/sboxes-s.c:1094:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#1094: FILE: john_core/src/sboxes-s.c:1094:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#1094: FILE: john_core/src/sboxes-s.c:1094:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#1094: FILE: john_core/src/sboxes-s.c:1094:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

WARNING: storage class should be at the beginning of the declaration
#1156: FILE: john_core/src/sboxes-s.c:1156:
+MAYBE_INLINE static void

WARNING: please, no spaces at the start of a line
#1158: FILE: john_core/src/sboxes-s.c:1158:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)$

ERROR: "foo * bar" should be "foo *bar"
#1158: FILE: john_core/src/sboxes-s.c:1158:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#1158: FILE: john_core/src/sboxes-s.c:1158:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#1158: FILE: john_core/src/sboxes-s.c:1158:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#1158: FILE: john_core/src/sboxes-s.c:1158:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

WARNING: storage class should be at the beginning of the declaration
#1218: FILE: john_core/src/sboxes-s.c:1218:
+MAYBE_INLINE static void

WARNING: please, no spaces at the start of a line
#1220: FILE: john_core/src/sboxes-s.c:1220:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)$

ERROR: "foo * bar" should be "foo *bar"
#1220: FILE: john_core/src/sboxes-s.c:1220:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#1220: FILE: john_core/src/sboxes-s.c:1220:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#1220: FILE: john_core/src/sboxes-s.c:1220:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#1220: FILE: john_core/src/sboxes-s.c:1220:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

WARNING: storage class should be at the beginning of the declaration
#1282: FILE: john_core/src/sboxes-s.c:1282:
+MAYBE_INLINE static void

WARNING: please, no spaces at the start of a line
#1284: FILE: john_core/src/sboxes-s.c:1284:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)$

ERROR: "foo * bar" should be "foo *bar"
#1284: FILE: john_core/src/sboxes-s.c:1284:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#1284: FILE: john_core/src/sboxes-s.c:1284:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#1284: FILE: john_core/src/sboxes-s.c:1284:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#1284: FILE: john_core/src/sboxes-s.c:1284:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

WARNING: storage class should be at the beginning of the declaration
#1342: FILE: john_core/src/sboxes-s.c:1342:
+MAYBE_INLINE static void

WARNING: please, no spaces at the start of a line
#1344: FILE: john_core/src/sboxes-s.c:1344:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)$

ERROR: "foo * bar" should be "foo *bar"
#1344: FILE: john_core/src/sboxes-s.c:1344:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#1344: FILE: john_core/src/sboxes-s.c:1344:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#1344: FILE: john_core/src/sboxes-s.c:1344:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

ERROR: "foo * bar" should be "foo *bar"
#1344: FILE: john_core/src/sboxes-s.c:1344:
+    vtype * out1, vtype * out2, vtype * out3, vtype * out4)

total: 88 errors, 44 warnings, 1400 lines checked

john_core/src/sboxes-s.c has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt
#50: FILE: john_core/src/signals.c:50:
+volatile int event_pending = 0;

WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt
#51: FILE: john_core/src/signals.c:51:
+volatile int event_abort = 0, event_save = 0, event_status = 0;

WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt
#52: FILE: john_core/src/signals.c:52:
+volatile int event_ticksafety = 0;

ERROR: do not initialise statics to 0 or NULL
#62: FILE: john_core/src/signals.c:62:
+static clock_t timer_emu_interval = 0;

ERROR: do not initialise statics to 0 or NULL
#63: FILE: john_core/src/signals.c:63:
+static unsigned int timer_emu_count = 0, timer_emu_max = 0;

ERROR: do not initialise statics to 0 or NULL
#73: FILE: john_core/src/signals.c:73:
+	static clock_t last = 0;

ERROR: trailing statements should be on next line
#77: FILE: john_core/src/signals.c:77:
+	if (++timer_emu_count < timer_emu_max) return;

ERROR: trailing statements should be on next line
#132: FILE: john_core/src/signals.c:132:
+	if (!event_abort) return;

WARNING: Missing a blank line after declarations
#212: FILE: john_core/src/signals.c:212:
+	int i;
+	for (i = 0; i < john_child_count; i++)

ERROR: trailing statements should be on next line
#315: FILE: john_core/src/signals.c:315:
+	if (setitimer(ITIMER_REAL, &it, NULL)) perror("setitimer");

ERROR: do not use assignment in if condition
#339: FILE: john_core/src/signals.c:339:
+	if ((timer_save_interval /= TIMER_INTERVAL) <= 0)

ERROR: do not use assignment in if condition
#345: FILE: john_core/src/signals.c:345:
+	if ((timer_ticksafety_interval /= TIMER_INTERVAL) <= 0)

total: 8 errors, 4 warnings, 371 lines checked

john_core/src/signals.c has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
ERROR: do not initialise statics to 0 or NULL
#25: FILE: john_core/src/single.c:25:
+static int progress = 0;

WARNING: suspect code indent for conditional statements (8, 8)
#41: FILE: john_core/src/single.c:41:
+	if (rule_ctx)
+	for (rule_number = 0; rule_number < rec_rule; rule_number++)

WARNING: suspect code indent for conditional statements (8, 8)
#42: FILE: john_core/src/single.c:42:
+	for (rule_number = 0; rule_number < rec_rule; rule_number++)
+	if (!rpp_next(rule_ctx)) return 1;

ERROR: trailing statements should be on next line
#43: FILE: john_core/src/single.c:43:
+	if (!rpp_next(rule_ctx)) return 1;

ERROR: trailing statements should be on next line
#50: FILE: john_core/src/single.c:50:
+	if (fscanf(file, "%d\n", &rec_rule) != 1) return 1;

ERROR: trailing statements should be on next line
#57: FILE: john_core/src/single.c:57:
+	if (progress) return progress;

WARNING: suspect code indent for conditional statements (8, 8)
#128: FILE: john_core/src/single.c:128:
+	if (key_count > 1)
+	log_event("- Allocated %d buffer%s of %d candidate passwords%s",

ERROR: trailing statements should be on next line
#156: FILE: john_core/src/single.c:156:
+			if (!key[3] || pos >= length) break;

ERROR: trailing statements should be on next line
#164: FILE: john_core/src/single.c:164:
+			if (!key[3]) break;

WARNING: suspect code indent for conditional statements (8, 8)
#191: FILE: john_core/src/single.c:191:
+	if ((index = keys->hash->hash[new_hash = single_key_hash(key)]) >= 0)
+	do {

ERROR: do not use assignment in if condition
#191: FILE: john_core/src/single.c:191:
+	if ((index = keys->hash->hash[new_hash = single_key_hash(key)]) >= 0)

ERROR: do not use assignment in if condition
#297: FILE: john_core/src/single.c:297:
+	if (!(first = pw->words->head))

WARNING: suspect code indent for conditional statements (16, 16)
#302: FILE: john_core/src/single.c:302:
+		if ((key = rules_apply(first->data, rule, 0, NULL)))
+		if (ext_filter(key))

ERROR: do not use assignment in if condition
#302: FILE: john_core/src/single.c:302:
+		if ((key = rules_apply(first->data, rule, 0, NULL)))

WARNING: suspect code indent for conditional statements (16, 16)
#303: FILE: john_core/src/single.c:303:
+		if (ext_filter(key))
+		if (single_add_key(salt, key, 0))

ERROR: do not use assignment in if condition
#323: FILE: john_core/src/single.c:323:
+			if ((split = strlen(first->data)) < length) {

WARNING: line over 80 characters
#327: FILE: john_core/src/single.c:327:
+				if ((key = rules_apply(pair, rule, split, NULL)))

WARNING: suspect code indent for conditional statements (32, 32)
#327: FILE: john_core/src/single.c:327:
+				if ((key = rules_apply(pair, rule, split, NULL)))
+				if (ext_filter(key))

ERROR: do not use assignment in if condition
#327: FILE: john_core/src/single.c:327:
+				if ((key = rules_apply(pair, rule, split, NULL)))

WARNING: suspect code indent for conditional statements (32, 32)
#328: FILE: john_core/src/single.c:328:
+				if (ext_filter(key))
+				if (single_add_key(salt, key, 0))

WARNING: suspect code indent for conditional statements (32, 32)
#342: FILE: john_core/src/single.c:342:
+				if ((key = rules_apply(pair, rule, 1, NULL)))
+				if (ext_filter(key))

ERROR: do not use assignment in if condition
#342: FILE: john_core/src/single.c:342:
+				if ((key = rules_apply(pair, rule, 1, NULL)))

WARNING: suspect code indent for conditional statements (32, 32)
#343: FILE: john_core/src/single.c:343:
+				if (ext_filter(key))
+				if (single_add_key(salt, key, 0))

WARNING: suspect code indent for conditional statements (8, 0)
#371: FILE: john_core/src/single.c:371:
+	do {
+/*

ERROR: do not use assignment in if condition
#377: FILE: john_core/src/single.c:377:
+			if (!(status = single_process_pw(salt, pw, rule))) {

WARNING: else is not generally useful after a break or return
#386: FILE: john_core/src/single.c:386:
+			return 1; /* no hashes left to crack for all salts */
+		} else {

WARNING: Missing a blank line after declarations
#421: FILE: john_core/src/single.c:421:
+			int for_node = rule_number % options.node_count + 1;
+			if (for_node < options.node_min ||

ERROR: do not use assignment in if condition
#428: FILE: john_core/src/single.c:428:
+		if (!(rule = rules_reject(prerule, 0, NULL, single_db))) {

ERROR: do not use assignment in if condition
#481: FILE: john_core/src/single.c:481:
+		if ((salt = single_db->salts)) {

WARNING: quoted string split across lines
#483: FILE: john_core/src/single.c:483:
+			log_event("- Processing the remaining buffered "
+				"candidate passwords, if any");

total: 15 errors, 15 warnings, 509 lines checked

john_core/src/single.c has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
WARNING: Missing a blank line after declarations
#75: FILE: john_core/src/status.c:75:
+		unsigned int saved_hi = status.combs.hi;
+		add64to64(&status.combs, combs);

WARNING: Missing a blank line after declarations
#82: FILE: john_core/src/status.c:82:
+		unsigned int saved_lo = status.crypts.lo;
+		add32to64(&status.crypts, crypts);

WARNING: Missing a blank line after declarations
#91: FILE: john_core/src/status.c:91:
+	unsigned int saved_lo = status.cands.lo;
+	add32to64(&status.cands, cands);

ERROR: trailing statements should be on next line
#147: FILE: john_core/src/status.c:147:
+	if (!time) time = 1;

WARNING: Missing a blank line after declarations
#176: FILE: john_core/src/status.c:176:
+		unsigned int div, frac;
+		fmt = "%u.%06u"; div = 1000000;

WARNING: Missing a blank line after declarations
#217: FILE: john_core/src/status.c:217:
+		char *key = crk_get_key2();
+		if (key)

total: 1 errors, 5 warnings, 301 lines checked

john_core/src/status.c has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
ERROR: do not use assignment in if condition
#28: FILE: john_core/src/symlink.c:28:
+	if ((name = strrchr(strcpy(path, argv[0]), '/')))

total: 1 errors, 0 warnings, 36 lines checked

john_core/src/symlink.c has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
WARNING: Missing a blank line after declarations
#149: FILE: john_core/src/trip_fmt.c:149:
+		char *p;
+		if (atoi64[i] != 0x7F)

ERROR: do not use assignment in if condition
#151: FILE: john_core/src/trip_fmt.c:151:
+		else if ((p = strchr(from, i)))

WARNING: Missing a blank line after declarations
#199: FILE: john_core/src/trip_fmt.c:199:
+	unsigned int w = *(ARCH_WORD_32 *)binary;
+	return ((w >> 1) & 0x80) | (w & 0x7F);

WARNING: Missing a blank line after declarations
#205: FILE: john_core/src/trip_fmt.c:205:
+	unsigned int w = *(ARCH_WORD_32 *)binary;
+	return ((w >> 1) & 0xF80) | (w & 0x7F);

WARNING: Missing a blank line after declarations
#211: FILE: john_core/src/trip_fmt.c:211:
+	unsigned int w = *(ARCH_WORD_32 *)binary;
+	return ((w >> 2) & 0xC000) | ((w >> 1) & 0x3F80) | (w & 0x7F);

WARNING: Missing a blank line after declarations
#217: FILE: john_core/src/trip_fmt.c:217:
+	unsigned int w = *(ARCH_WORD_32 *)binary;
+	return ((w >> 2) & 0xFC000) | ((w >> 1) & 0x3F80) | (w & 0x7F);

WARNING: Missing a blank line after declarations
#223: FILE: john_core/src/trip_fmt.c:223:
+	unsigned int w = *(ARCH_WORD_32 *)binary;
+	return ((w >> 3) & 0xE00000) |

WARNING: Missing a blank line after declarations
#230: FILE: john_core/src/trip_fmt.c:230:
+	unsigned int w = *(ARCH_WORD_32 *)binary;
+	return ((w >> 3) & 0x7E00000) |

WARNING: macros should not use a trailing semicolon
#251: FILE: john_core/src/trip_fmt.c:251:
+#define MAYBE_T0 \
+	const int t = 0;

WARNING: Macros with flow control statements should be avoided
#257: FILE: john_core/src/trip_fmt.c:257:
+#define define_get_hash(NAME, CALL) \
+static int NAME(int index) \
+{ \
+	if (hash_func == CALL) \
+		return buffer[index].hash; \
+	{ \
+		int block = buffer[index].block; \
+		MAYBE_T0; \
+		blkcpy(DES_bs_all.B, crypt_out[block], 27 + 3); \
+		return (next_hash_func = CALL)(buffer[index].index); \
+	} \
+}
+

ERROR: do not use assignment in if condition
#363: FILE: john_core/src/trip_fmt.c:363:
+			if ((buffer[index].next = salt_bucket[salt]) >= 0)

WARNING: Missing a blank line after declarations
#436: FILE: john_core/src/trip_fmt.c:436:
+				int tindex;
+				DES_bs_crypt_25(lindex);

WARNING: suspect code indent for conditional statements (32, 32)
#443: FILE: john_core/src/trip_fmt.c:443:
+				if (next_hash_func)
+				for (tindex = 0; tindex < lindex; tindex++) {

WARNING: Missing a blank line after declarations
#492: FILE: john_core/src/trip_fmt.c:492:
+	int count = *pcount;
+	crypt_link_by_salt(count);

WARNING: Missing a blank line after declarations
#517: FILE: john_core/src/trip_fmt.c:517:
+	int block = buffer[index].block;
+	MAYBE_T0;

WARNING: Missing a blank line after declarations
#525: FILE: john_core/src/trip_fmt.c:525:
+	int block = buffer[index].block;
+	MAYBE_T0;

WARNING: suspect code indent for conditional statements (8, 8)
#534: FILE: john_core/src/trip_fmt.c:534:
+	for (index = 0; index < count; index++)
+	if (*(unsigned ARCH_WORD *)binary == buffer[index].aligned.binary[0])

WARNING: suspect code indent for conditional statements (8, 8)
#553: FILE: john_core/src/trip_fmt.c:553:
+	for (word = 0; word < 16 / DES_SIZE; word++)
+	if ((unsigned ARCH_WORD)binary[word] !=

total: 2 errors, 16 warnings, 638 lines checked

john_core/src/trip_fmt.c has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
WARNING: externs should be avoided in .c files
#30: FILE: john_core/src/tty.c:30:
+extern int tcgetattr(int fd, struct termios *termios_p);

WARNING: externs should be avoided in .c files
#31: FILE: john_core/src/tty.c:31:
+extern int tcsetattr(int fd, int actions, struct termios *termios_p);

ERROR: trailing statements should be on next line
#48: FILE: john_core/src/tty.c:48:
+	if (tty_fd >= 0) return;

ERROR: do not use assignment in if condition
#59: FILE: john_core/src/tty.c:59:
+	if ((fd = open("/dev/tty", O_RDONLY | O_NONBLOCK)) < 0) return;

ERROR: trailing statements should be on next line
#59: FILE: john_core/src/tty.c:59:
+	if ((fd = open("/dev/tty", O_RDONLY | O_NONBLOCK)) < 0) return;

ERROR: trailing statements should be on next line
#97: FILE: john_core/src/tty.c:97:
+		if (read(tty_fd, &c, 1) > 0) return c;

ERROR: trailing statements should be on next line
#112: FILE: john_core/src/tty.c:112:
+	if (tty_fd < 0) return;

total: 5 errors, 2 warnings, 119 lines checked

john_core/src/tty.c has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
ERROR: trailing statements should be on next line
#24: FILE: john_core/src/unafs.c:24:
+	if (!name[0]) return;

ERROR: trailing statements should be on next line
#45: FILE: john_core/src/unafs.c:45:
+	if (fread(buffer, 8, 1, file) != 1) return 1;

ERROR: trailing statements should be on next line
#49: FILE: john_core/src/unafs.c:49:
+	if (size == 0) size = 64; /* OpenAFS */

ERROR: trailing statements should be on next line
#50: FILE: john_core/src/unafs.c:50:
+	if (fseek(file, size, SEEK_SET)) pexit("fseek");

ERROR: trailing statements should be on next line
#52: FILE: john_core/src/unafs.c:52:
+	if (fread(buffer, 8, 1, file) != 1) return 1;

ERROR: trailing statements should be on next line
#58: FILE: john_core/src/unafs.c:58:
+	if (fseek(file, size, SEEK_SET)) pexit("fseek");

WARNING: else is not generally useful after a break or return
#75: FILE: john_core/src/unafs.c:75:
+			return 0;
+		else

ERROR: do not use assignment in if condition
#79: FILE: john_core/src/unafs.c:79:
+	if (!(file = fopen(argv[1], "rb")))

WARNING: suspect code indent for conditional statements (8, 8)
#82: FILE: john_core/src/unafs.c:82:
+	if (process_db(file, argv[2]))
+	if (!ferror(file)) {

ERROR: trailing statements should be on next line
#88: FILE: john_core/src/unafs.c:88:
+	if (ferror(file)) pexit("fread");

ERROR: trailing statements should be on next line
#90: FILE: john_core/src/unafs.c:90:
+	if (fclose(file)) pexit("fclose");

total: 9 errors, 2 warnings, 93 lines checked

john_core/src/unafs.c has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#39: FILE: john_core/src/unique.c:39:
+#define put_int(ptr, value) \
+	*(ptr) = (value);

WARNING: macros should not use a trailing semicolon
#39: FILE: john_core/src/unique.c:39:
+#define put_int(ptr, value) \
+	*(ptr) = (value);

ERROR: trailing statements should be on next line
#93: FILE: john_core/src/unique.c:93:
+		if (!p[1]) break;

ERROR: trailing statements should be on next line
#145: FILE: john_core/src/unique.c:145:
+			if (!strcmp(line, &buffer.data[current + 4])) break;

ERROR: trailing statements should be on next line
#149: FILE: john_core/src/unique.c:149:
+		if (current != ENTRY_END_HASH) continue;

ERROR: trailing statements should be on next line
#159: FILE: john_core/src/unique.c:159:
+		if (ptr > UNIQUE_BUFFER_SIZE - sizeof(line) - 8) break;

ERROR: trailing statements should be on next line
#162: FILE: john_core/src/unique.c:162:
+	if (ferror(stdin)) pexit("fgets");

WARNING: Missing a blank line after declarations
#174: FILE: john_core/src/unique.c:174:
+		unsigned int length, size;
+		ptr += 4;

ERROR: trailing statements should be on next line
#191: FILE: john_core/src/unique.c:191:
+	if (fseek(output, 0, SEEK_SET) < 0) pexit("fseek");

ERROR: trailing statements should be on next line
#211: FILE: john_core/src/unique.c:211:
+	if (ferror(output)) pexit("fgets");

ERROR: trailing statements should be on next line
#214: FILE: john_core/src/unique.c:214:
+	if (fseek(output, 0, SEEK_END) < 0) pexit("fseek");

ERROR: do not use assignment in if condition
#224: FILE: john_core/src/unique.c:224:
+	if ((fd = open(name, O_RDWR | O_CREAT | O_EXCL, 0600)) < 0)

ERROR: do not use assignment in if condition
#226: FILE: john_core/src/unique.c:226:
+	if (!(output = fdopen(fd, "w+"))) pexit("fdopen");

ERROR: trailing statements should be on next line
#226: FILE: john_core/src/unique.c:226:
+	if (!(output = fdopen(fd, "w+"))) pexit("fdopen");

ERROR: trailing statements should be on next line
#243: FILE: john_core/src/unique.c:243:
+	if (fclose(output)) pexit("fclose");

WARNING: else is not generally useful after a break or return
#253: FILE: john_core/src/unique.c:253:
+			return 0;
+		else

total: 13 errors, 3 warnings, 262 lines checked

john_core/src/unique.c has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
ERROR: trailing statements should be on next line
#54: FILE: john_core/src/unshadow.c:54:
+		if (!p[1]) break;

ERROR: do not use assignment in if condition
#88: FILE: john_core/src/unshadow.c:88:
+	if (!(file = fopen(name, "r")))

ERROR: trailing statements should be on next line
#94: FILE: john_core/src/unshadow.c:94:
+	if (ferror(file)) pexit("fgets");

ERROR: trailing statements should be on next line
#96: FILE: john_core/src/unshadow.c:96:
+	if (fclose(file)) pexit("fclose");

ERROR: do not initialise statics to 0 or NULL
#101: FILE: john_core/src/unshadow.c:101:
+	static struct shadow_entry **entry = NULL;

ERROR: do not use assignment in if condition
#105: FILE: john_core/src/unshadow.c:105:
+	if (!(passwd = strchr(line, ':'))) {

ERROR: trailing statements should be on next line
#106: FILE: john_core/src/unshadow.c:106:
+		while (*line == ' ' || *line == '\t') line++;

ERROR: do not use assignment in if condition
#118: FILE: john_core/src/unshadow.c:118:
+		if ((passwd = strstr(passwd, ":u_pwd=")))

ERROR: do not use assignment in if condition
#124: FILE: john_core/src/unshadow.c:124:
+		if ((tail = strchr(passwd, ':')))

ERROR: do not use assignment in if condition
#130: FILE: john_core/src/unshadow.c:130:
+	if (passwd && (tail = strchr(passwd, ':')))

ERROR: do not use assignment in if condition
#146: FILE: john_core/src/unshadow.c:146:
+	if (!(pos1 = strchr(line, ':'))) return;

ERROR: trailing statements should be on next line
#146: FILE: john_core/src/unshadow.c:146:
+	if (!(pos1 = strchr(line, ':'))) return;

ERROR: do not use assignment in if condition
#149: FILE: john_core/src/unshadow.c:149:
+	if (!(pos2 = strchr(pos1, ':')))

WARNING: suspect code indent for conditional statements (8, 8)
#152: FILE: john_core/src/unshadow.c:152:
+	if (pos2 > pos1 && (current = shadow_table[login_hash(line)]))
+	do {

ERROR: do not use assignment in if condition
#152: FILE: john_core/src/unshadow.c:152:
+	if (pos2 > pos1 && (current = shadow_table[login_hash(line)]))

WARNING: else is not generally useful after a break or return
#170: FILE: john_core/src/unshadow.c:170:
+			return 0;
+		else

total: 14 errors, 2 warnings, 180 lines checked

john_core/src/unshadow.c has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
ERROR: do not initialise statics to 0 or NULL
#34: FILE: john_core/src/wordlist.c:34:
+static FILE *word_file = NULL;

ERROR: do not initialise statics to 0 or NULL
#35: FILE: john_core/src/wordlist.c:35:
+static int progress = 0;

WARNING: suspect code indent for conditional statements (8, 8)
#53: FILE: john_core/src/wordlist.c:53:
+	if (rule_ctx)
+	for (rule_number = 0; rule_number < rec_rule; rule_number++)

WARNING: suspect code indent for conditional statements (8, 8)
#54: FILE: john_core/src/wordlist.c:54:
+	for (rule_number = 0; rule_number < rec_rule; rule_number++)
+	if (!rpp_next(rule_ctx)) {

WARNING: quoted string split across lines
#57: FILE: john_core/src/wordlist.c:57:
+		fprintf(stderr, "Restored rule number is out of range - "
+		    "has the configuration file changed?\n");

WARNING: Missing a blank line after declarations
#81: FILE: john_core/src/wordlist.c:81:
+	char line[LINE_BUFFER_SIZE];
+	if (skip_lines(rec_pos, line)) {

ERROR: do not use assignment in if condition
#121: FILE: john_core/src/wordlist.c:121:
+	if ((rec_pos = ftell(word_file)) < 0) {

ERROR: trailing statements should be on next line
#137: FILE: john_core/src/wordlist.c:137:
+	if (!word_file) return progress;

ERROR: trailing statements should be on next line
#139: FILE: john_core/src/wordlist.c:139:
+	if (word_file == stdin) return -1;

ERROR: trailing statements should be on next line
#141: FILE: john_core/src/wordlist.c:141:
+	if (fstat(fileno(word_file), &file_stat)) pexit("fstat");

ERROR: do not use assignment in if condition
#143: FILE: john_core/src/wordlist.c:143:
+	if ((pos = ftell(word_file)) < 0) {

ERROR: do not use assignment in if condition
#182: FILE: john_core/src/wordlist.c:182:
+		if (!(word_file = fopen(path_expand(name), "r")))

ERROR: do not use assignment in if condition
#193: FILE: john_core/src/wordlist.c:193:
+		if (rpp_init(rule_ctx = &ctx, SUBSECTION_WORDLIST)) {

WARNING: Missing a blank line after declarations
#242: FILE: john_core/src/wordlist.c:242:
+		const char *now, *later = "";
+		dist_switch = rule_count - rule_rem;

WARNING: suspect code indent for conditional statements (16, 0)
#259: FILE: john_core/src/wordlist.c:259:
+		if (line_number) {
+/* Restored session.  line_number is right after a word we've actually used. */

WARNING: Missing a blank line after declarations
#262: FILE: john_core/src/wordlist.c:262:
+			int for_node = line_number % options.node_count + 1;
+			if (for_node < options.node_min ||

WARNING: suspect code indent for conditional statements (24, 0)
#262: FILE: john_core/src/wordlist.c:262:
+			if (for_node < options.node_min ||
[...]
+/* We assume that line_number is at the beginning of other nodes' block */

WARNING: suspect code indent for conditional statements (8, 8)
#281: FILE: john_core/src/wordlist.c:281:
+	if (prerule)
+	do {

ERROR: do not use assignment in if condition
#291: FILE: john_core/src/wordlist.c:291:
+			if ((rule = rules_reject(prerule, -1, last, db))) {

WARNING: quoted string split across lines
#294: FILE: john_core/src/wordlist.c:294:
+					log_event("- Rule #%d: '%.100s'"
+						" accepted as '%.100s'",

WARNING: quoted string split across lines
#298: FILE: john_core/src/wordlist.c:298:
+					log_event("- Rule #%d: '%.100s'"
+						" accepted",

ERROR: do not use assignment in if condition
#312: FILE: john_core/src/wordlist.c:312:
+				if ((word = apply(line, rule, -1, last))) {

WARNING: suspect code indent for conditional statements (40, 40)
#315: FILE: john_core/src/wordlist.c:315:
+					if (ext_filter(word))
+					if (crk_process_key(word)) {

ERROR: do not use assignment in if condition
#340: FILE: john_core/src/wordlist.c:340:
+			if (!(rule = rpp_next(&ctx))) break;

ERROR: trailing statements should be on next line
#340: FILE: john_core/src/wordlist.c:340:
+			if (!(rule = rpp_next(&ctx))) break;

ERROR: trailing statements should be on next line
#367: FILE: john_core/src/wordlist.c:367:
+	if (ferror(word_file)) pexit("fgets");

ERROR: trailing statements should be on next line
#375: FILE: john_core/src/wordlist.c:375:
+		if (fclose(word_file)) pexit("fclose");

total: 15 errors, 12 warnings, 378 lines checked

john_core/src/wordlist.c has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.

total: 0 errors, 0 warnings, 50 lines checked

john_core/src/alpha.h has no obvious style problems and is ready for submission.
total: 0 errors, 0 warnings, 25 lines checked

john_core/src/batch.h has no obvious style problems and is ready for submission.
total: 0 errors, 0 warnings, 71 lines checked

john_core/src/bench.h has no obvious style problems and is ready for submission.
WARNING: do not add new typedefs
#21: FILE: john_core/src/BF_std.h:21:
+typedef ARCH_WORD_32 BF_word;

WARNING: do not add new typedefs
#26: FILE: john_core/src/BF_std.h:26:
+typedef struct {

WARNING: do not add new typedefs
#35: FILE: john_core/src/BF_std.h:35:
+typedef BF_word BF_binary[6];

total: 0 errors, 3 warnings, 96 lines checked

john_core/src/BF_std.h has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 0 warnings, 79 lines checked

john_core/src/charset.h has no obvious style problems and is ready for submission.
WARNING: do not add new typedefs
#22: FILE: john_core/src/common.h:22:
+typedef unsigned short ARCH_WORD_32;

WARNING: do not add new typedefs
#24: FILE: john_core/src/common.h:24:
+typedef unsigned int ARCH_WORD_32;

ERROR: Macros with complex values should be enclosed in parentheses
#29: FILE: john_core/src/common.h:29:
+#define MAYBE_INLINE __attribute__((always_inline)) __inline__

WARNING: plain inline is preferred over __inline__
#29: FILE: john_core/src/common.h:29:
+#define MAYBE_INLINE __attribute__((always_inline)) __inline__

WARNING: plain inline is preferred over __inline__
#31: FILE: john_core/src/common.h:31:
+#define MAYBE_INLINE __inline__

ERROR: Macros with complex values should be enclosed in parentheses
#40: FILE: john_core/src/common.h:40:
+#define CC_CACHE_ALIGN \
+	__attribute__ ((aligned (MEM_ALIGN_CACHE)))

WARNING: space prohibited between function name and open parenthesis '('
#41: FILE: john_core/src/common.h:41:
+	__attribute__ ((aligned (MEM_ALIGN_CACHE)))

WARNING: __aligned(size) is preferred over __attribute__((aligned(size)))
#41: FILE: john_core/src/common.h:41:
+	__attribute__ ((aligned (MEM_ALIGN_CACHE)))

total: 2 errors, 6 warnings, 67 lines checked

john_core/src/common.h has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
WARNING: do not add new typedefs
#52: FILE: john_core/src/compiler.h:52:
+typedef int c_int;

ERROR: Macros with complex values should be enclosed in parentheses
#83: FILE: john_core/src/compiler.h:83:
+#define c_execute(addr) \
+	if (addr) \
+		c_execute_fast(addr)

total: 1 errors, 1 warnings, 88 lines checked

john_core/src/compiler.h has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 0 warnings, 85 lines checked

john_core/src/config.h has no obvious style problems and is ready for submission.
total: 0 errors, 0 warnings, 50 lines checked

john_core/src/cracker.h has no obvious style problems and is ready for submission.
WARNING: do not add new typedefs
#23: FILE: john_core/src/crc32.h:23:
+typedef unsigned int CRC32_t;

total: 0 errors, 1 warnings, 42 lines checked

john_core/src/crc32.h has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
WARNING: do not add new typedefs
#33: FILE: john_core/src/DES_bs.h:33:
+typedef ARCH_WORD DES_bs_vector[DES_BS_VECTOR_SIZE];

WARNING: do not add new typedefs
#45: FILE: john_core/src/DES_bs.h:45:
+typedef struct {

ERROR: need consistent spacing around '*' (ctx:WxV)
#47: FILE: john_core/src/DES_bs.h:47:
+	ARCH_WORD *KSp[0x300];	/* Initial key schedule (key bit pointers) */
 	          ^

ERROR: need consistent spacing around '*' (ctx:WxV)
#50: FILE: john_core/src/DES_bs.h:50:
+		ARCH_WORD *p[0x300];	/* Key bit pointers */
 		          ^

ERROR: need consistent spacing around '*' (ctx:WxV)
#56: FILE: john_core/src/DES_bs.h:56:
+		ARCH_WORD *E[96];	/* Expansion function (data bit ptrs) */
 		          ^

WARNING: macros should not use a trailing semicolon
#96: FILE: john_core/src/DES_bs.h:96:
+#define init_t() \
+	int t = (unsigned int)index / DES_BS_DEPTH * DES_bs_all_size; \
+	index = (unsigned int)index % DES_BS_DEPTH;

WARNING: macros should not use a trailing semicolon
#108: FILE: john_core/src/DES_bs.h:108:
+#define init_t() \
+	int t = (unsigned int)index / DES_BS_DEPTH; \
+	index = (unsigned int)index % DES_BS_DEPTH;

total: 3 errors, 4 warnings, 203 lines checked

john_core/src/DES_bs.h has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
WARNING: do not add new typedefs
#37: FILE: john_core/src/DES_std.h:37:
+typedef ARCH_WORD DES_KS[128 / DES_SIZE];

WARNING: do not add new typedefs
#43: FILE: john_core/src/DES_std.h:43:
+typedef unsigned ARCH_WORD DES_binary[16 / DES_SIZE];

total: 0 errors, 2 warnings, 206 lines checked

john_core/src/DES_std.h has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 0 warnings, 56 lines checked

john_core/src/external.h has no obvious style problems and is ready for submission.
WARNING: please, no spaces at the start of a line
#274: FILE: john_core/src/formats.h:274:
+    struct fmt_main *self);$

total: 0 errors, 1 warnings, 289 lines checked

john_core/src/formats.h has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
WARNING: do not add new typedefs
#21: FILE: john_core/src/getopt.h:21:
+typedef unsigned int opt_flags;

total: 0 errors, 1 warnings, 82 lines checked

john_core/src/getopt.h has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 0 warnings, 50 lines checked

john_core/src/ia64.h has no obvious style problems and is ready for submission.
total: 0 errors, 0 warnings, 37 lines checked

john_core/src/idle.h has no obvious style problems and is ready for submission.
total: 0 errors, 0 warnings, 20 lines checked

john_core/src/inc.h has no obvious style problems and is ready for submission.
total: 0 errors, 0 warnings, 38 lines checked

john_core/src/john.h has no obvious style problems and is ready for submission.
total: 0 errors, 0 warnings, 70 lines checked

john_core/src/list.h has no obvious style problems and is ready for submission.
total: 0 errors, 0 warnings, 244 lines checked

john_core/src/loader.h has no obvious style problems and is ready for submission.
WARNING: __printf(string-index, first-to-check) is preferred over __attribute__((format(printf, string-index, first-to-check)))
#37: FILE: john_core/src/logger.h:37:
+	__attribute__ ((format (printf, 1, 2)));

total: 0 errors, 1 warnings, 57 lines checked

john_core/src/logger.h has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
WARNING: do not add new typedefs
#21: FILE: john_core/src/math.h:21:
+typedef struct {

total: 0 errors, 1 warnings, 33 lines checked

john_core/src/math.h has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
WARNING: do not add new typedefs
#21: FILE: john_core/src/MD5_std.h:21:
+typedef ARCH_WORD_32 MD5_word;

WARNING: do not add new typedefs
#26: FILE: john_core/src/MD5_std.h:26:
+typedef MD5_word MD5_binary[4];

WARNING: do not add new typedefs
#32: FILE: john_core/src/MD5_std.h:32:
+typedef union {

WARNING: do not add new typedefs
#38: FILE: john_core/src/MD5_std.h:38:
+typedef struct {

WARNING: do not add new typedefs
#43: FILE: john_core/src/MD5_std.h:43:
+typedef struct {

WARNING: do not add new typedefs
#57: FILE: john_core/src/MD5_std.h:57:
+typedef struct {

WARNING: do not add new typedefs
#70: FILE: john_core/src/MD5_std.h:70:
+typedef struct {

WARNING: macros should not use a trailing semicolon
#100: FILE: john_core/src/MD5_std.h:100:
+#define init_t() \
+	int t = (unsigned int)index / MD5_N * MD5_std_all_size; \
+	index = (unsigned int)index % MD5_N;

WARNING: macros should not use a trailing semicolon
#112: FILE: john_core/src/MD5_std.h:112:
+#define init_t() \
+	int t = (unsigned int)index / MD5_N; \
+	index = (unsigned int)index % MD5_N;

total: 0 errors, 9 warnings, 165 lines checked

john_core/src/MD5_std.h has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 0 warnings, 90 lines checked

john_core/src/memory.h has no obvious style problems and is ready for submission.
total: 0 errors, 0 warnings, 50 lines checked

john_core/src/mips32.h has no obvious style problems and is ready for submission.
total: 0 errors, 0 warnings, 50 lines checked

john_core/src/mips64.h has no obvious style problems and is ready for submission.
WARNING: __printf(string-index, first-to-check) is preferred over __attribute__((format(printf, string-index, first-to-check)))
#31: FILE: john_core/src/misc.h:31:
+	__attribute__ ((format (printf, 1, 2)));

total: 0 errors, 1 warnings, 71 lines checked

john_core/src/misc.h has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 0 warnings, 140 lines checked

john_core/src/options.h has no obvious style problems and is ready for submission.
total: 0 errors, 0 warnings, 62 lines checked

john_core/src/os.h has no obvious style problems and is ready for submission.
total: 0 errors, 0 warnings, 332 lines checked

john_core/src/params.h has no obvious style problems and is ready for submission.
total: 0 errors, 0 warnings, 51 lines checked

john_core/src/pa-risc.h has no obvious style problems and is ready for submission.
total: 0 errors, 0 warnings, 40 lines checked

john_core/src/path.h has no obvious style problems and is ready for submission.
total: 0 errors, 0 warnings, 66 lines checked

john_core/src/ppc32alt.h has no obvious style problems and is ready for submission.
total: 0 errors, 0 warnings, 50 lines checked

john_core/src/ppc32.h has no obvious style problems and is ready for submission.
total: 0 errors, 0 warnings, 66 lines checked

john_core/src/ppc64alt.h has no obvious style problems and is ready for submission.
total: 0 errors, 0 warnings, 50 lines checked

john_core/src/ppc64.h has no obvious style problems and is ready for submission.
total: 0 errors, 0 warnings, 103 lines checked

john_core/src/recovery.h has no obvious style problems and is ready for submission.
total: 0 errors, 0 warnings, 88 lines checked

john_core/src/rpp.h has no obvious style problems and is ready for submission.
total: 0 errors, 0 warnings, 57 lines checked

john_core/src/rules.h has no obvious style problems and is ready for submission.
WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt
#27: FILE: john_core/src/signals.h:27:
+extern volatile int event_pending;	/* An event is pending */

WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt
#28: FILE: john_core/src/signals.h:28:
+extern volatile int event_abort;	/* Abort requested */

WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt
#29: FILE: john_core/src/signals.h:29:
+extern volatile int event_save;		/* Save the crash recovery file */

WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt
#30: FILE: john_core/src/signals.h:30:
+extern volatile int event_status;	/* Status display requested */

WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt
#31: FILE: john_core/src/signals.h:31:
+extern volatile int event_ticksafety;	/* System time in ticks may overflow */

total: 0 errors, 5 warnings, 59 lines checked

john_core/src/signals.h has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 0 warnings, 20 lines checked

john_core/src/single.h has no obvious style problems and is ready for submission.
total: 0 errors, 0 warnings, 56 lines checked

john_core/src/sparc32.h has no obvious style problems and is ready for submission.
total: 0 errors, 0 warnings, 50 lines checked

john_core/src/sparc64.h has no obvious style problems and is ready for submission.
total: 0 errors, 0 warnings, 83 lines checked

john_core/src/status.h has no obvious style problems and is ready for submission.
total: 0 errors, 0 warnings, 37 lines checked

john_core/src/times.h has no obvious style problems and is ready for submission.
total: 0 errors, 0 warnings, 36 lines checked

john_core/src/tty.h has no obvious style problems and is ready for submission.
total: 0 errors, 0 warnings, 50 lines checked

john_core/src/vax.h has no obvious style problems and is ready for submission.
total: 0 errors, 0 warnings, 26 lines checked

john_core/src/wordlist.h has no obvious style problems and is ready for submission.
WARNING: line over 80 characters
#159: FILE: john_core/src/x86-64.h:159:
+#define DES_BS_ALGORITHM_NAME		"DES 128/128 SSE2-16 + 64/64 MMX + 64/64"

total: 0 errors, 1 warnings, 186 lines checked

john_core/src/x86-64.h has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 0 warnings, 59 lines checked

john_core/src/x86-any.h has no obvious style problems and is ready for submission.
WARNING: please, no spaces at the start of a line
#73: FILE: john_core/src/x86-mmx.h:73:
+    (defined(__GNUC__) && \$

WARNING: please, no spaces at the start of a line
#74: FILE: john_core/src/x86-mmx.h:74:
+    (__GNUC__ > 4 || (__GNUC__ == 4 && __GNUC_MINOR__ >= 2)))$

total: 0 errors, 2 warnings, 83 lines checked

john_core/src/x86-mmx.h has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
WARNING: please, no spaces at the start of a line
#129: FILE: john_core/src/x86-sse.h:129:
+    (defined(__GNUC__) && \$

WARNING: please, no spaces at the start of a line
#130: FILE: john_core/src/x86-sse.h:130:
+    (__GNUC__ > 4 || (__GNUC__ == 4 && __GNUC_MINOR__ >= 2)))$

total: 0 errors, 2 warnings, 139 lines checked

john_core/src/x86-sse.h has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.

Powered by blists - more mailing lists

Your e-mail address:

Powered by Openwall GNU/*/Linux - Powered by OpenVZ