Openwall GNU/*/Linux - a small security-enhanced Linux distro for servers
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 10 Apr 2015 08:56:50 +0800
From: Kai Zhao <loverszhao@...il.com>
To: john-dev@...ts.openwall.com
Subject: Re: Coding Style

> Please attach the 130 KB file for core.  I might actually make changes
> based on it.  Thanks!

Sorry. The original output is not exactly 130KB which I have removed
several same problems. The original output is 323KB and I attach them
to three emails.

This is part 2.


Thanks,

Kai

[ CONTENT OF TYPE text/html SKIPPED ]

ERROR: trailing statements should be on next line
#626: FILE: john_core/src/DES_std.c:626:
+	if (j != l) k += 3;

ERROR: trailing statements should be on next line
#635: FILE: john_core/src/DES_std.c:635:
+		while (DES_key[i++]) k += 2;

WARNING: suspect code indent for conditional statements (24, 24)
#641: FILE: john_core/src/DES_std.c:641:
+			if (l)
+			if (k == (l = DES_key[j++])) continue;

ERROR: do not use assignment in if condition
#642: FILE: john_core/src/DES_std.c:642:
+			if (k == (l = DES_key[j++])) continue;

ERROR: trailing statements should be on next line
#642: FILE: john_core/src/DES_std.c:642:
+			if (k == (l = DES_key[j++])) continue;

WARNING: suspect code indent for conditional statements (16, 16)
#651: FILE: john_core/src/DES_std.c:651:
+		if (l)
+		for (; j < 8 && (l = DES_key[j]); j++)

WARNING: suspect code indent for conditional statements (16, 16)
#658: FILE: john_core/src/DES_std.c:658:
+		if (k)
+		for (i = 1; i < 8 && (k = key[i]); i++)

WARNING: Missing a blank line after declarations
#676: FILE: john_core/src/DES_std.c:676:
+	ARCH_WORD Rl, Rh, Ll, Lh;
+	unsigned ARCH_WORD C;

WARNING: Missing a blank line after declarations
#732: FILE: john_core/src/DES_std.c:732:
+	ARCH_WORD R, L;
+	unsigned ARCH_WORD C;

ERROR: Macros with multiple statements should be enclosed in a do - while loop
#824: FILE: john_core/src/DES_std.c:824:
+#define DES_ROUND(L, H, B) \
+	T = DES_INDEX(DES_SPE_F[0], DES_D & DES_MASK_6); \
+	B ^= DES_INDEX(DES_SPE_F[1], (DES_D >> 8) & DES_MASK_6); \
+	T ^= DES_INDEX(DES_SPE_F[2], (DES_D >> 16) & DES_MASK_6); \
+	B ^= DES_INDEX(DES_SPE_F[3], (DES_D >> 24) & DES_MASK_6); \
+	T ^= DES_INDEX(DES_SPE_F[4], (DES_D >> 32) & DES_MASK_6); \
+	B ^= DES_INDEX(DES_SPE_F[5], (DES_D >> 40) & DES_MASK_6); \
+	T ^= DES_INDEX(DES_SPE_F[6], (DES_D >> 48) & DES_MASK_6); \
+	B ^= T ^ DES_INDEX(DES_SPE_F[7], DES_D >> 56);

WARNING: macros should not use a trailing semicolon
#824: FILE: john_core/src/DES_std.c:824:
+#define DES_ROUND(L, H, B) \
+	T = DES_INDEX(DES_SPE_F[0], DES_D & DES_MASK_6); \
+	B ^= DES_INDEX(DES_SPE_F[1], (DES_D >> 8) & DES_MASK_6); \
+	T ^= DES_INDEX(DES_SPE_F[2], (DES_D >> 16) & DES_MASK_6); \
+	B ^= DES_INDEX(DES_SPE_F[3], (DES_D >> 24) & DES_MASK_6); \
+	T ^= DES_INDEX(DES_SPE_F[4], (DES_D >> 32) & DES_MASK_6); \
+	B ^= DES_INDEX(DES_SPE_F[5], (DES_D >> 40) & DES_MASK_6); \
+	T ^= DES_INDEX(DES_SPE_F[6], (DES_D >> 48) & DES_MASK_6); \
+	B ^= T ^ DES_INDEX(DES_SPE_F[7], DES_D >> 56);

ERROR: Macros with multiple statements should be enclosed in a do - while loop
#842: FILE: john_core/src/DES_std.c:842:
+#define DES_ROUND(L, H, B) \
+	T = DES_INDEX(DES_SPE_F[0], (DES_D & (DES_MASK_6 >> 1)) << 1); \
+	B ^= DES_INDEX(DES_SPE_F[1], (DES_D >> 7) & DES_MASK_6); \
+	T ^= DES_INDEX(DES_SPE_F[2], (DES_D >> 15) & DES_MASK_6); \
+	B ^= DES_INDEX(DES_SPE_F[3], (DES_D >> 23) & DES_MASK_6); \
+	T ^= DES_INDEX(DES_SPE_F[4], (DES_D >> 31) & DES_MASK_6); \
+	B ^= DES_INDEX(DES_SPE_F[5], (DES_D >> 39) & DES_MASK_6); \
+	T ^= DES_INDEX(DES_SPE_F[6], (DES_D >> 47) & DES_MASK_6); \
+	B ^= T ^ DES_INDEX(DES_SPE_F[7], (DES_D >> 55) & DES_MASK_6);

WARNING: macros should not use a trailing semicolon
#842: FILE: john_core/src/DES_std.c:842:
+#define DES_ROUND(L, H, B) \
+	T = DES_INDEX(DES_SPE_F[0], (DES_D & (DES_MASK_6 >> 1)) << 1); \
+	B ^= DES_INDEX(DES_SPE_F[1], (DES_D >> 7) & DES_MASK_6); \
+	T ^= DES_INDEX(DES_SPE_F[2], (DES_D >> 15) & DES_MASK_6); \
+	B ^= DES_INDEX(DES_SPE_F[3], (DES_D >> 23) & DES_MASK_6); \
+	T ^= DES_INDEX(DES_SPE_F[4], (DES_D >> 31) & DES_MASK_6); \
+	B ^= DES_INDEX(DES_SPE_F[5], (DES_D >> 39) & DES_MASK_6); \
+	T ^= DES_INDEX(DES_SPE_F[6], (DES_D >> 47) & DES_MASK_6); \
+	B ^= T ^ DES_INDEX(DES_SPE_F[7], (DES_D >> 55) & DES_MASK_6);

ERROR: Macros with multiple statements should be enclosed in a do - while loop
#854: FILE: john_core/src/DES_std.c:854:
+#define DES_ROUND(L, H, B) \
+	T = DES_INDEX(DES_SPE_F[0], DES_B0); \
+	B ^= DES_INDEX(DES_SPE_F[1], DES_B1); \
+	T ^= DES_INDEX(DES_SPE_F[2], DES_B2); \
+	B ^= DES_INDEX(DES_SPE_F[3], DES_B3); \
+	T ^= DES_INDEX(DES_SPE_F[4], DES_B4); \
+	B ^= DES_INDEX(DES_SPE_F[5], DES_B5); \
+	T ^= DES_INDEX(DES_SPE_F[6], DES_B6); \
+	B ^= T ^ DES_INDEX(DES_SPE_F[7], DES_B7);

WARNING: macros should not use a trailing semicolon
#854: FILE: john_core/src/DES_std.c:854:
+#define DES_ROUND(L, H, B) \
+	T = DES_INDEX(DES_SPE_F[0], DES_B0); \
+	B ^= DES_INDEX(DES_SPE_F[1], DES_B1); \
+	T ^= DES_INDEX(DES_SPE_F[2], DES_B2); \
+	B ^= DES_INDEX(DES_SPE_F[3], DES_B3); \
+	T ^= DES_INDEX(DES_SPE_F[4], DES_B4); \
+	B ^= DES_INDEX(DES_SPE_F[5], DES_B5); \
+	T ^= DES_INDEX(DES_SPE_F[6], DES_B6); \
+	B ^= T ^ DES_INDEX(DES_SPE_F[7], DES_B7);

ERROR: Macros with multiple statements should be enclosed in a do - while loop
#866: FILE: john_core/src/DES_std.c:866:
+#define DES_ROUND(L, H, B) \
+	B ^= DES_INDEX(DES_SPE_W[0], DES_D & 0xFFFF); \
+	B ^= DES_INDEX(DES_SPE_W[1], (DES_D >>= 16) & 0xFFFF); \
+	B ^= DES_INDEX(DES_SPE_W[2], (DES_D >>= 16) & 0xFFFF); \
+	B ^= DES_INDEX(DES_SPE_W[3], DES_D >> 16);

WARNING: macros should not use a trailing semicolon
#866: FILE: john_core/src/DES_std.c:866:
+#define DES_ROUND(L, H, B) \
+	B ^= DES_INDEX(DES_SPE_W[0], DES_D & 0xFFFF); \
+	B ^= DES_INDEX(DES_SPE_W[1], (DES_D >>= 16) & 0xFFFF); \
+	B ^= DES_INDEX(DES_SPE_W[2], (DES_D >>= 16) & 0xFFFF); \
+	B ^= DES_INDEX(DES_SPE_W[3], DES_D >> 16);

ERROR: Macros with multiple statements should be enclosed in a do - while loop
#876: FILE: john_core/src/DES_std.c:876:
+#define DES_ROUND(L, H, B) \
+	L ^= DES_INDEX(DES_SPE_L[0], DES_Dl & DES_MASK_6); \
+	H ^= DES_INDEX(DES_SPE_H[0], DES_Dl & DES_MASK_6); \
+	L ^= DES_INDEX(DES_SPE_L[1], (DES_Dl >>= 8) & DES_MASK_6); \
+	H ^= DES_INDEX(DES_SPE_H[1], DES_Dl & DES_MASK_6); \
+	L ^= DES_INDEX(DES_SPE_L[2], (DES_Dl >>= 8) & DES_MASK_6); \
+	H ^= DES_INDEX(DES_SPE_H[2], DES_Dl & DES_MASK_6); \
+	L ^= DES_INDEX(DES_SPE_L[3], (DES_Dl >>= 8) & DES_MASK_6); \
+	H ^= DES_INDEX(DES_SPE_H[3], DES_Dl & DES_MASK_6); \
+	L ^= DES_INDEX(DES_SPE_L[4], DES_Dh & DES_MASK_6); \
+	H ^= DES_INDEX(DES_SPE_H[4], DES_Dh & DES_MASK_6); \
+	L ^= DES_INDEX(DES_SPE_L[5], (DES_Dh >>= 8) & DES_MASK_6); \
+	H ^= DES_INDEX(DES_SPE_H[5], DES_Dh & DES_MASK_6); \
+	L ^= DES_INDEX(DES_SPE_L[6], (DES_Dh >>= 8) & DES_MASK_6); \
+	H ^= DES_INDEX(DES_SPE_H[6], DES_Dh & DES_MASK_6); \
+	L ^= DES_INDEX(DES_SPE_L[7], (DES_Dh >>= 8) & DES_MASK_6); \
+	H ^= DES_INDEX(DES_SPE_H[7], DES_Dh & DES_MASK_6);

WARNING: macros should not use a trailing semicolon
#876: FILE: john_core/src/DES_std.c:876:
+#define DES_ROUND(L, H, B) \
+	L ^= DES_INDEX(DES_SPE_L[0], DES_Dl & DES_MASK_6); \
+	H ^= DES_INDEX(DES_SPE_H[0], DES_Dl & DES_MASK_6); \
+	L ^= DES_INDEX(DES_SPE_L[1], (DES_Dl >>= 8) & DES_MASK_6); \
+	H ^= DES_INDEX(DES_SPE_H[1], DES_Dl & DES_MASK_6); \
+	L ^= DES_INDEX(DES_SPE_L[2], (DES_Dl >>= 8) & DES_MASK_6); \
+	H ^= DES_INDEX(DES_SPE_H[2], DES_Dl & DES_MASK_6); \
+	L ^= DES_INDEX(DES_SPE_L[3], (DES_Dl >>= 8) & DES_MASK_6); \
+	H ^= DES_INDEX(DES_SPE_H[3], DES_Dl & DES_MASK_6); \
+	L ^= DES_INDEX(DES_SPE_L[4], DES_Dh & DES_MASK_6); \
+	H ^= DES_INDEX(DES_SPE_H[4], DES_Dh & DES_MASK_6); \
+	L ^= DES_INDEX(DES_SPE_L[5], (DES_Dh >>= 8) & DES_MASK_6); \
+	H ^= DES_INDEX(DES_SPE_H[5], DES_Dh & DES_MASK_6); \
+	L ^= DES_INDEX(DES_SPE_L[6], (DES_Dh >>= 8) & DES_MASK_6); \
+	H ^= DES_INDEX(DES_SPE_H[6], DES_Dh & DES_MASK_6); \
+	L ^= DES_INDEX(DES_SPE_L[7], (DES_Dh >>= 8) & DES_MASK_6); \
+	H ^= DES_INDEX(DES_SPE_H[7], DES_Dh & DES_MASK_6);

ERROR: Macros with multiple statements should be enclosed in a do - while loop
#895: FILE: john_core/src/DES_std.c:895:
+#define DES_ROUND(L, H, B) \
+	L ^= DES_INDEX(DES_SPE_L[0], DES_B0); \
+	H ^= DES_INDEX(DES_SPE_H[0], DES_B0); \
+	L ^= DES_INDEX(DES_SPE_L[1], DES_B1); \
+	H ^= DES_INDEX(DES_SPE_H[1], DES_B1); \
+	L ^= DES_INDEX(DES_SPE_L[2], DES_B2); \
+	H ^= DES_INDEX(DES_SPE_H[2], DES_B2); \
+	L ^= DES_INDEX(DES_SPE_L[3], DES_B3); \
+	H ^= DES_INDEX(DES_SPE_H[3], DES_B3); \
+	L ^= DES_INDEX(DES_SPE_L[4], DES_B4); \
+	H ^= DES_INDEX(DES_SPE_H[4], DES_B4); \
+	L ^= DES_INDEX(DES_SPE_L[5], DES_B5); \
+	H ^= DES_INDEX(DES_SPE_H[5], DES_B5); \
+	L ^= DES_INDEX(DES_SPE_L[6], DES_B6); \
+	H ^= DES_INDEX(DES_SPE_H[6], DES_B6); \
+	L ^= DES_INDEX(DES_SPE_L[7], DES_B7); \
+	H ^= DES_INDEX(DES_SPE_H[7], DES_B7);

WARNING: macros should not use a trailing semicolon
#895: FILE: john_core/src/DES_std.c:895:
+#define DES_ROUND(L, H, B) \
+	L ^= DES_INDEX(DES_SPE_L[0], DES_B0); \
+	H ^= DES_INDEX(DES_SPE_H[0], DES_B0); \
+	L ^= DES_INDEX(DES_SPE_L[1], DES_B1); \
+	H ^= DES_INDEX(DES_SPE_H[1], DES_B1); \
+	L ^= DES_INDEX(DES_SPE_L[2], DES_B2); \
+	H ^= DES_INDEX(DES_SPE_H[2], DES_B2); \
+	L ^= DES_INDEX(DES_SPE_L[3], DES_B3); \
+	H ^= DES_INDEX(DES_SPE_H[3], DES_B3); \
+	L ^= DES_INDEX(DES_SPE_L[4], DES_B4); \
+	H ^= DES_INDEX(DES_SPE_H[4], DES_B4); \
+	L ^= DES_INDEX(DES_SPE_L[5], DES_B5); \
+	H ^= DES_INDEX(DES_SPE_H[5], DES_B5); \
+	L ^= DES_INDEX(DES_SPE_L[6], DES_B6); \
+	H ^= DES_INDEX(DES_SPE_H[6], DES_B6); \
+	L ^= DES_INDEX(DES_SPE_L[7], DES_B7); \
+	H ^= DES_INDEX(DES_SPE_H[7], DES_B7);

ERROR: Macros with multiple statements should be enclosed in a do - while loop
#915: FILE: john_core/src/DES_std.c:915:
+#define DES_ROUND(L, H, B) \
+	L ^= DES_INDEX_L(DES_SPE_W[0], DES_Dl & 0xFFFF); \
+	H ^= DES_INDEX_H(DES_SPE_W[0], DES_Dl & 0xFFFF); \
+	L ^= DES_INDEX_L(DES_SPE_W[1], DES_Dl >>= 16); \
+	H ^= DES_INDEX_H(DES_SPE_W[1], DES_Dl); \
+	L ^= DES_INDEX_L(DES_SPE_W[2], DES_Dh & 0xFFFF); \
+	H ^= DES_INDEX_H(DES_SPE_W[2], DES_Dh & 0xFFFF); \
+	L ^= DES_INDEX_L(DES_SPE_W[3], DES_Dh >>= 16); \
+	H ^= DES_INDEX_H(DES_SPE_W[3], DES_Dh);

WARNING: macros should not use a trailing semicolon
#915: FILE: john_core/src/DES_std.c:915:
+#define DES_ROUND(L, H, B) \
+	L ^= DES_INDEX_L(DES_SPE_W[0], DES_Dl & 0xFFFF); \
+	H ^= DES_INDEX_H(DES_SPE_W[0], DES_Dl & 0xFFFF); \
+	L ^= DES_INDEX_L(DES_SPE_W[1], DES_Dl >>= 16); \
+	H ^= DES_INDEX_H(DES_SPE_W[1], DES_Dl); \
+	L ^= DES_INDEX_L(DES_SPE_W[2], DES_Dh & 0xFFFF); \
+	H ^= DES_INDEX_H(DES_SPE_W[2], DES_Dh & 0xFFFF); \
+	L ^= DES_INDEX_L(DES_SPE_W[3], DES_Dh >>= 16); \
+	H ^= DES_INDEX_H(DES_SPE_W[3], DES_Dh);

ERROR: Macros with multiple statements should be enclosed in a do - while loop
#928: FILE: john_core/src/DES_std.c:928:
+#define DES_2_ROUNDS(KS) \
+	DES_D = R ^ KS[0]; \
+	DES_ROUND(Ll, Lh, L); \
+	DES_D = L ^ KS[1]; \
+	DES_ROUND(Rl, Rh, R);

WARNING: macros should not use a trailing semicolon
#928: FILE: john_core/src/DES_std.c:928:
+#define DES_2_ROUNDS(KS) \
+	DES_D = R ^ KS[0]; \
+	DES_ROUND(Ll, Lh, L); \
+	DES_D = L ^ KS[1]; \
+	DES_ROUND(Rl, Rh, R);

ERROR: Macros with multiple statements should be enclosed in a do - while loop
#934: FILE: john_core/src/DES_std.c:934:
+#define DES_2_ROUNDS(KS) \
+	DES_Dl = Rl ^ KS[0]; \
+	DES_Dh = Rh ^ KS[1]; \
+	DES_ROUND(Ll, Lh, L); \
+	DES_Dl = Ll ^ KS[2]; \
+	DES_Dh = Lh ^ KS[3]; \
+	DES_ROUND(Rl, Rh, R);

WARNING: macros should not use a trailing semicolon
#934: FILE: john_core/src/DES_std.c:934:
+#define DES_2_ROUNDS(KS) \
+	DES_Dl = Rl ^ KS[0]; \
+	DES_Dh = Rh ^ KS[1]; \
+	DES_ROUND(Ll, Lh, L); \
+	DES_Dl = Ll ^ KS[2]; \
+	DES_Dh = Lh ^ KS[3]; \
+	DES_ROUND(Rl, Rh, R);

ERROR: trailing statements should be on next line
#1054: FILE: john_core/src/DES_std.c:1054:
+	if (ciphertext[13]) return DES_atoi64[ARCH_INDEX(ciphertext[5])] |

ERROR: trailing statements should be on next line
#1058: FILE: john_core/src/DES_std.c:1058:
+	else return DES_atoi64[ARCH_INDEX(ciphertext[0])] |

ERROR: trailing statements should be on next line
#1073: FILE: john_core/src/DES_std.c:1073:
+	if (ciphertext[13]) return DES_atoi64[ARCH_INDEX(ciphertext[1])] |

ERROR: trailing statements should be on next line
#1077: FILE: john_core/src/DES_std.c:1077:
+	else return 25;

ERROR: trailing statements should be on next line
#1118: FILE: john_core/src/DES_std.c:1118:
+	if (ciphertext[13]) ofs = 9; else ofs = 2;

WARNING: line over 80 characters
#1128: FILE: john_core/src/DES_std.c:1128:
+				block[dst >> 5] |= (unsigned ARCH_WORD)1 << (dst & 0x1F);

total: 26 errors, 39 warnings, 1171 lines checked

john_core/src/DES_std.c has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
ERROR: trailing statements should be on next line
#22: FILE: john_core/src/detect.c:22:
+	if (argc != 8) return 1;

ERROR: trailing statements should be on next line
#25: FILE: john_core/src/detect.c:25:
+	while (sizeof(long) * 8 != 1 << size_log) size_log++;

total: 2 errors, 0 warnings, 137 lines checked

john_core/src/detect.c has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
WARNING: do not add new typedefs
#26: FILE: john_core/src/dummy.c:26:
+typedef struct {

ERROR: trailing statements should be on next line
#114: FILE: john_core/src/dummy.c:114:
+		if (!p[1]) break;

WARNING: Missing a blank line after declarations
#149: FILE: john_core/src/dummy.c:149:
+	ARCH_WORD_32 hash = ((dummy_binary *)binary)->hash;
+	hash ^= hash >> 8;

WARNING: Missing a blank line after declarations
#156: FILE: john_core/src/dummy.c:156:
+	ARCH_WORD_32 hash = ((dummy_binary *)binary)->hash;
+	return (hash ^ (hash >> 8)) & 0xff;

WARNING: Missing a blank line after declarations
#162: FILE: john_core/src/dummy.c:162:
+	ARCH_WORD_32 hash = ((dummy_binary *)binary)->hash;
+	return (hash ^ (hash >> 12)) & 0xfff;

WARNING: Missing a blank line after declarations
#188: FILE: john_core/src/dummy.c:188:
+	ARCH_WORD_32 hash = string_hash(saved_key[index]);
+	hash ^= hash >> 8;

WARNING: Missing a blank line after declarations
#195: FILE: john_core/src/dummy.c:195:
+	ARCH_WORD_32 hash = string_hash(saved_key[index]);
+	return (hash ^ (hash >> 8)) & 0xff;

WARNING: Missing a blank line after declarations
#201: FILE: john_core/src/dummy.c:201:
+	ARCH_WORD_32 hash = string_hash(saved_key[index]);
+	return (hash ^ (hash >> 12)) & 0xfff;

total: 1 errors, 7 warnings, 321 lines checked

john_core/src/dummy.c has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
ERROR: trailing statements should be on next line
#73: FILE: john_core/src/external.c:73:
+	if (!ext_line || !ext_line->data) return -1;

ERROR: do not use assignment in if condition
#75: FILE: john_core/src/external.c:75:
+	if ((c = (unsigned char)ext_line->data[ext_pos++])) return c;

ERROR: trailing statements should be on next line
#75: FILE: john_core/src/external.c:75:
+	if ((c = (unsigned char)ext_line->data[ext_pos++])) return c;

ERROR: do not use assignment in if condition
#90: FILE: john_core/src/external.c:90:
+	if (!(ext_source = cfg_get_list(SECTION_EXT, mode))) {

ERROR: trailing statements should be on next line
#97: FILE: john_core/src/external.c:97:
+		if (!ext_line) ext_line = ext_source->tail;

WARNING: quoted string split across lines
#129: FILE: john_core/src/external.c:129:
+		fprintf(stderr, "Warning: external mode defines generate(), "
+		    "but is only used for filter()\n");

WARNING: suspect code indent for conditional statements (8, 8)
#145: FILE: john_core/src/external.c:145:
+	if (external[0] && external[1] && external[2] && external[3])
+	do {

ERROR: do not use assignment in if condition
#147: FILE: john_core/src/external.c:147:
+		if (!(external[4] = internal[4]))

ERROR: do not use assignment in if condition
#149: FILE: john_core/src/external.c:149:
+		if (!(external[5] = internal[5]))

ERROR: do not use assignment in if condition
#151: FILE: john_core/src/external.c:151:
+		if (!(external[6] = internal[6]))

ERROR: do not use assignment in if condition
#153: FILE: john_core/src/external.c:153:
+		if (!(external[7] = internal[7]))

ERROR: trailing statements should be on next line
#161: FILE: john_core/src/external.c:161:
+	if (!ext_word[0] && in[0]) return 0;

WARNING: suspect code indent for conditional statements (8, 8)
#169: FILE: john_core/src/external.c:169:
+	if (external[0] && external[1] && external[2] && external[3])
+	do {

ERROR: do not use assignment in if condition
#171: FILE: john_core/src/external.c:171:
+		if (!(internal[4] = external[4]))

ERROR: do not use assignment in if condition
#173: FILE: john_core/src/external.c:173:
+		if (!(internal[5] = external[5]))

ERROR: do not use assignment in if condition
#175: FILE: john_core/src/external.c:175:
+		if (!(internal[6] = external[6]))

ERROR: do not use assignment in if condition
#177: FILE: john_core/src/external.c:177:
+		if (!(internal[7] = external[7]))

ERROR: trailing statements should be on next line
#211: FILE: john_core/src/external.c:211:
+		if (fscanf(file, "%d\n", &c) != 1) return 1;

ERROR: trailing statements should be on next line
#212: FILE: john_core/src/external.c:212:
+		if (++count >= PLAINTEXT_BUFFER_SIZE) return 1;

WARNING: Missing a blank line after declarations
#259: FILE: john_core/src/external.c:259:
+			int for_node = seq++ % options.node_count + 1;
+			if (for_node < options.node_min ||

ERROR: do not use assignment in if condition
#271: FILE: john_core/src/external.c:271:
+		if ((int_word[1] = ext_word[1])) {

ERROR: do not use assignment in if condition
#275: FILE: john_core/src/external.c:275:
+				if (!(internal[0] = external[0]))

ERROR: do not use assignment in if condition
#277: FILE: john_core/src/external.c:277:
+				if (!(internal[1] = external[1]))

ERROR: do not use assignment in if condition
#279: FILE: john_core/src/external.c:279:
+				if (!(internal[2] = external[2]))

ERROR: do not use assignment in if condition
#281: FILE: john_core/src/external.c:281:
+				if (!(internal[3] = external[3]))

ERROR: trailing statements should be on next line
#288: FILE: john_core/src/external.c:288:
+		if (crk_process_key(int_word)) break;

total: 22 errors, 4 warnings, 293 lines checked

john_core/src/external.c has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
WARNING: please, no spaces at the start of a line
#51: FILE: john_core/src/formats.c:51:
+    void *binary_copy, void *salt_copy)$

ERROR: do not use assignment in if condition
#85: FILE: john_core/src/formats.c:85:
+	if (!(current = format->params.tests)) return NULL;

ERROR: trailing statements should be on next line
#85: FILE: john_core/src/formats.c:85:
+	if (!(current = format->params.tests)) return NULL;

WARNING: suspect code indent for conditional statements (16, 16)
#147: FILE: john_core/src/formats.c:147:
+		for (size = 0; size < PASSWORD_HASH_SIZES; size++)
+		if (format->methods.binary_hash[size] &&

WARNING: suspect code indent for conditional statements (16, 0)
#181: FILE: john_core/src/formats.c:181:
+		if (!(++current)->ciphertext) {
+/* Jump straight to last index for non-bitslice DES */

total: 2 errors, 3 warnings, 298 lines checked

john_core/src/formats.c has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
ERROR: do not use assignment in if condition
#36: FILE: john_core/src/getopt.c:36:
+		if (*(name = opt + 1) == '-') name++;

ERROR: trailing statements should be on next line
#36: FILE: john_core/src/getopt.c:36:
+		if (*(name = opt + 1) == '-') name++;

ERROR: do not use assignment in if condition
#37: FILE: john_core/src/getopt.c:37:
+		if (!(param = strchr(name, '=')))

ERROR: trailing statements should be on next line
#41: FILE: john_core/src/getopt.c:41:
+			if (!*++param) param = NULL;

WARNING: suspect code indent for conditional statements (24, 24)
#47: FILE: john_core/src/getopt.c:47:
+			if (length <= strlen(list->name))
+			if (!strncmp(name, list->name, length)) {

ERROR: do not use assignment in if condition
#58: FILE: john_core/src/getopt.c:58:
+		if ((*entry = found))

WARNING: else is not generally useful after a break or return
#73: FILE: john_core/src/getopt.c:73:
+		return 0;
+	} else

WARNING: else is not generally useful after a break or return
#77: FILE: john_core/src/getopt.c:77:
+		return 0;
+	} else

ERROR: trailing statements should be on next line
#91: FILE: john_core/src/getopt.c:91:
+	if (!entry) return OPT_ERROR_UNKNOWN;

ERROR: trailing statements should be on next line
#93: FILE: john_core/src/getopt.c:93:
+	if (*flg & entry->flg_set & entry->flg_clr) return OPT_ERROR_COMB;

ERROR: trailing statements should be on next line
#106: FILE: john_core/src/getopt.c:106:
+	if (param) return OPT_ERROR_PARAM_EXT;

ERROR: trailing statements should be on next line
#116: FILE: john_core/src/getopt.c:116:
+	if (!entry) return OPT_ERROR_UNKNOWN;

WARNING: suspect code indent for conditional statements (8, 8)
#129: FILE: john_core/src/getopt.c:129:
+	if (*(opt = argv))
+	while (*++opt)

ERROR: do not use assignment in if condition
#129: FILE: john_core/src/getopt.c:129:
+	if (*(opt = argv))

WARNING: suspect code indent for conditional statements (8, 8)
#130: FILE: john_core/src/getopt.c:130:
+	while (*++opt)
+	if ((res = opt_process_one(list, flg, *opt))) {

ERROR: do not use assignment in if condition
#131: FILE: john_core/src/getopt.c:131:
+	if ((res = opt_process_one(list, flg, *opt))) {

WARNING: suspect code indent for conditional statements (8, 8)
#142: FILE: john_core/src/getopt.c:142:
+	if (*(opt = argv))
+	while (*++opt)

ERROR: do not use assignment in if condition
#142: FILE: john_core/src/getopt.c:142:
+	if (*(opt = argv))

WARNING: suspect code indent for conditional statements (8, 8)
#143: FILE: john_core/src/getopt.c:143:
+	while (*++opt)
+	if ((res = opt_check_one(list, flg, *opt))) {

ERROR: do not use assignment in if condition
#144: FILE: john_core/src/getopt.c:144:
+	if ((res = opt_check_one(list, flg, *opt))) {

total: 13 errors, 7 warnings, 148 lines checked

john_core/src/getopt.c has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
ERROR: do not initialise statics to 0 or NULL
#20: FILE: john_core/src/idle.c:20:
+static int use_yield = 0;

WARNING: externs should be avoided in .c files
#24: FILE: john_core/src/idle.c:24:
+extern int nice(int);

ERROR: do not initialise statics to 0 or NULL
#89: FILE: john_core/src/idle.c:89:
+	static unsigned int calls_to_skip = 0;

ERROR: do not initialise statics to 0 or NULL
#90: FILE: john_core/src/idle.c:90:
+	static unsigned int calls_per_tick = 0;

ERROR: do not initialise statics to 0 or NULL
#91: FILE: john_core/src/idle.c:91:
+	static unsigned int calls_since_tick = 0;

ERROR: do not initialise statics to 0 or NULL
#92: FILE: john_core/src/idle.c:92:
+	static unsigned int calls_since_adj = 0;

ERROR: do not initialise statics to 0 or NULL
#93: FILE: john_core/src/idle.c:93:
+	static int calls_per_tick_known = 0;

ERROR: do not initialise statics to 0 or NULL
#94: FILE: john_core/src/idle.c:94:
+	static clock_t last_adj = 0;

ERROR: trailing statements should be on next line
#100: FILE: john_core/src/idle.c:100:
+	if (!use_yield) return;

ERROR: trailing statements should be on next line
#102: FILE: john_core/src/idle.c:102:
+	if (++calls_since_tick < calls_to_skip) return;

ERROR: trailing statements should be on next line
#107: FILE: john_core/src/idle.c:107:
+	if (!last_adj) last_adj = current;

ERROR: trailing statements should be on next line
#124: FILE: john_core/src/idle.c:124:
+		if (event_pending) break;

WARNING: Missing a blank line after declarations
#138: FILE: john_core/src/idle.c:138:
+		unsigned int max_calls_to_skip = calls_per_tick * clk_tck >> 4;
+		if (max_calls_to_skip < calls_per_tick)

total: 11 errors, 2 warnings, 144 lines checked

john_core/src/idle.c has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
WARNING: externs should be avoided in .c files
#27: FILE: john_core/src/inc.c:27:
+extern struct fmt_main fmt_LM;

WARNING: do not add new typedefs
#29: FILE: john_core/src/inc.c:29:
+typedef char (*char2_table)

WARNING: do not add new typedefs
#31: FILE: john_core/src/inc.c:31:
+typedef char (*chars_table)

WARNING: Missing a blank line after declarations
#67: FILE: john_core/src/inc.c:67:
+		unsigned int number;
+		if (fscanf(file, "%u\n", &number) != 1)

WARNING: suspect code indent for conditional statements (16, 16)
#130: FILE: john_core/src/inc.c:130:
+		for (i = real_min; i <= real_max; i++)
+		for (j = real_min; j <= real_max; j++)

WARNING: suspect code indent for conditional statements (8, 8)
#147: FILE: john_core/src/inc.c:147:
+	if ((value = getc(file)) != EOF)
+	do {

ERROR: do not use assignment in if condition
#147: FILE: john_core/src/inc.c:147:
+	if ((value = getc(file)) != EOF)

ERROR: do not use assignment in if condition
#183: FILE: john_core/src/inc.c:183:
+		if ((value = getc(file)) == EOF)

WARNING: else is not generally useful after a break or return
#185: FILE: john_core/src/inc.c:185:
+			break;
+		else

ERROR: do not use assignment in if condition
#187: FILE: john_core/src/inc.c:187:
+			if ((value = getc(file)) != (int)length)

ERROR: do not use assignment in if condition
#189: FILE: john_core/src/inc.c:189:
+			if ((value = getc(file)) == EOF)

ERROR: do not use assignment in if condition
#198: FILE: john_core/src/inc.c:198:
+			if ((value = getc(file)) == EOF)

ERROR: do not use assignment in if condition
#203: FILE: john_core/src/inc.c:203:
+			if ((value = getc(file)) == EOF)

WARNING: Missing a blank line after declarations
#284: FILE: john_core/src/inc.c:284:
+			int j = real_chars[cj];
+			for (pos = 0; pos <= (int)length - 2; pos++) {

ERROR: do not use assignment in if condition
#345: FILE: john_core/src/inc.c:345:
+	if (!f_filter || ext_filter_body(key_i, key = key_e))

ERROR: do not use assignment in if condition
#399: FILE: john_core/src/inc.c:399:
+	if (!(charset = cfg_get_param(SECTION_INC, mode, "File"))) {

ERROR: do not use assignment in if condition
#409: FILE: john_core/src/inc.c:409:
+	if ((min_length = cfg_get_int(SECTION_INC, mode, "MinLen")) < 0)

ERROR: do not use assignment in if condition
#411: FILE: john_core/src/inc.c:411:
+	if ((max_length = cfg_get_int(SECTION_INC, mode, "MaxLen")) < 0)

WARNING: quoted string split across lines
#430: FILE: john_core/src/inc.c:430:
+			    "MinLen = %d exceeds the maximum possible "
+			    "length for the current hash type (%d)\n",

WARNING: quoted string split across lines
#440: FILE: john_core/src/inc.c:440:
+			fprintf(stderr, "Warning: MaxLen = %d is too large "
+			    "for the current hash type, reduced to %d\n",

WARNING: quoted string split across lines
#450: FILE: john_core/src/inc.c:450:
+			fprintf(stderr, "MaxLen = %d exceeds the compile-time "
+			    "limit of %d\n", max_length, CHARSET_LENGTH);

ERROR: do not use assignment in if condition
#454: FILE: john_core/src/inc.c:454:
+	if (!(file = fopen(path_expand(charset), "rb")))

WARNING: quoted string split across lines
#511: FILE: john_core/src/inc.c:511:
+		log_event("! Extra characters not in compile-time "
+		    "specified range ('\\x%02x' to '\\x%02x')",

WARNING: quoted string split across lines
#515: FILE: john_core/src/inc.c:515:
+			fprintf(stderr, "Extra characters not in compile-time "
+			    "specified range ('\\x%02x' to '\\x%02x')\n",

WARNING: Missing a blank line after declarations
#523: FILE: john_core/src/inc.c:523:
+		unsigned char c;
+		real_min = 0xff;

WARNING: quoted string split across lines
#559: FILE: john_core/src/inc.c:559:
+		log_event("! Mixed-case charset, "
+		    "but the hash type is case-insensitive");

WARNING: quoted string split across lines
#562: FILE: john_core/src/inc.c:562:
+			fprintf(stderr, "Warning: mixed-case charset, "
+			    "but the current hash type is case-insensitive;\n"

WARNING: quoted string split across lines
#564: FILE: john_core/src/inc.c:564:
+			    "some candidate passwords may be unnecessarily "
+			    "tried more than once.\n");

WARNING: Missing a blank line after declarations
#625: FILE: john_core/src/inc.c:625:
+		int skip = 0;
+		if (options.node_count) {

WARNING: Missing a blank line after declarations
#627: FILE: john_core/src/inc.c:627:
+			int for_node = entry % options.node_count + 1;
+			skip = for_node < options.node_min ||

WARNING: Missing a blank line after declarations
#652: FILE: john_core/src/inc.c:652:
+			int i, max_count = 0;
+			if ((int)length != last_length) {

total: 11 errors, 20 warnings, 705 lines checked

john_core/src/inc.c has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
ERROR: do not initialise statics to 0 or NULL
#35: FILE: john_core/src/john.c:35:
+static int john_omp_threads_orig = 0;

WARNING: externs should be avoided in .c files
#64: FILE: john_core/src/john.c:64:
+extern int CPU_detect(void);

WARNING: externs should be avoided in .c files
#67: FILE: john_core/src/john.c:67:
+extern struct fmt_main fmt_DES, fmt_BSDI, fmt_MD5, fmt_BF;

WARNING: externs should be avoided in .c files
#68: FILE: john_core/src/john.c:68:
+extern struct fmt_main fmt_AFS, fmt_LM;

WARNING: externs should be avoided in .c files
#70: FILE: john_core/src/john.c:70:
+extern struct fmt_main fmt_crypt;

WARNING: externs should be avoided in .c files
#72: FILE: john_core/src/john.c:72:
+extern struct fmt_main fmt_trip;

WARNING: externs should be avoided in .c files
#73: FILE: john_core/src/john.c:73:
+extern struct fmt_main fmt_dummy;

WARNING: externs should be avoided in .c files
#75: FILE: john_core/src/john.c:75:
+extern int unshadow(int argc, char **argv);

WARNING: externs should be avoided in .c files
#76: FILE: john_core/src/john.c:76:
+extern int unafs(int argc, char **argv);

WARNING: externs should be avoided in .c files
#77: FILE: john_core/src/john.c:77:
+extern int unique(int argc, char **argv);

ERROR: do not initialise statics to 0 or NULL
#89: FILE: john_core/src/john.c:89:
+static int exit_status = 0;

WARNING: quoted string split across lines
#140: FILE: john_core/src/john.c:140:
+		log_event("- Candidate passwords %s be buffered and "
+			"tried in chunks of %d",

ERROR: open brace '{' following function declarations go on the next line
#158: FILE: john_core/src/john.c:158:
+static void john_omp_fallback(char **argv) {

WARNING: Missing a blank line after declarations
#187: FILE: john_core/src/john.c:187:
+		const char *msg = NULL;
+		if (!(database.format->params.flags & FMT_OMP))

WARNING: quoted string split across lines
#194: FILE: john_core/src/john.c:194:
+			fprintf(stderr, "Warning: %s for this hash type, "
+			    "consider --fork=%d\n",

WARNING: Missing a blank line after declarations
#211: FILE: john_core/src/john.c:211:
+		int show = 0;
+		if (database.format &&

WARNING: quoted string split across lines
#230: FILE: john_core/src/john.c:230:
+			    "Will run %d OpenMP threads per process "
+			    "(%u total across %u processes)\n",

WARNING: Missing a blank line after declarations
#280: FILE: john_core/src/john.c:280:
+				unsigned int node_id = options.node_min;
+				rec_done(-2);

WARNING: quoted string split across lines
#285: FILE: john_core/src/john.c:285:
+					    "Inconsistent crash recovery file:"
+					    " %s\n", rec_name);

WARNING: Missing a blank line after declarations
#319: FILE: john_core/src/john.c:319:
+		int pid = wait(&status);
+		if (pid == -1) {

WARNING: suspect code indent for conditional statements (24, 24)
#373: FILE: john_core/src/john.c:373:
+			if ((current = options.passwd->head))
+			do {

ERROR: do not use assignment in if condition
#373: FILE: john_core/src/john.c:373:
+			if ((current = options.passwd->head))

WARNING: suspect code indent for conditional statements (24, 24)
#402: FILE: john_core/src/john.c:402:
+			if ((current = options.passwd->head))
+			do {

ERROR: do not use assignment in if condition
#402: FILE: john_core/src/john.c:402:
+			if ((current = options.passwd->head))

WARNING: suspect code indent for conditional statements (16, 16)
#425: FILE: john_core/src/john.c:425:
+		if ((current = options.passwd->head))
+		do {

ERROR: do not use assignment in if condition
#425: FILE: john_core/src/john.c:425:
+		if ((current = options.passwd->head))

ERROR: trailing statements should be on next line
#460: FILE: john_core/src/john.c:460:
+		if ((options.flags & FLG_PWD_REQ) && !database.salts) exit(0);

WARNING: Missing a blank line after declarations
#519: FILE: john_core/src/john.c:519:
+	int make_check = (argc == 2 && !strcmp(argv[1], "--make_check"));
+	if (make_check)

WARNING: Missing a blank line after declarations
#570: FILE: john_core/src/john.c:570:
+			char *where = fmt_self_test(database.format);
+			if (where) {

WARNING: quoted string split across lines
#581: FILE: john_core/src/john.c:581:
+				log_event("- Configured to use otherwise idle "
+					"processor cycles only");

WARNING: Missing a blank line after declarations
#614: FILE: john_core/src/john.c:614:
+			char *not_all = " not be all those cracked";
+			switch (database.options->flags &

WARNING: quoted string split across lines
#627: FILE: john_core/src/john.c:627:
+			fputs("Use the \"--show\" option to display all of "
+			    "the cracked passwords reliably\n", stderr);

WARNING: quoted string split across lines
#646: FILE: john_core/src/john.c:646:
+			    "Main process session completed, "
+			    "but some child processes failed";

ERROR: trailing statements should be on next line
#665: FILE: john_core/src/john.c:665:
+	if (--argc <= 0) return 1;

ERROR: do not use assignment in if condition
#666: FILE: john_core/src/john.c:666:
+	if ((name = strrchr(argv[0], '/')))

ERROR: do not use assignment in if condition
#675: FILE: john_core/src/john.c:675:
+	if ((name = strrchr(argv[0], '/')))

total: 10 errors, 26 warnings, 707 lines checked

john_core/src/john.c has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
ERROR: do not use assignment in if condition
#52: FILE: john_core/src/list.c:52:
+		if ((comma = strchr(data, ','))) *comma = 0;

ERROR: trailing statements should be on next line
#52: FILE: john_core/src/list.c:52:
+		if ((comma = strchr(data, ','))) *comma = 0;

ERROR: trailing statements should be on next line
#57: FILE: john_core/src/list.c:57:
+		if (comma) *comma = ',';

WARNING: suspect code indent for conditional statements (8, 8)
#65: FILE: john_core/src/list.c:65:
+	if ((current = list->head))
+	do {

ERROR: do not use assignment in if condition
#65: FILE: john_core/src/list.c:65:
+	if ((current = list->head))

ERROR: trailing statements should be on next line
#67: FILE: john_core/src/list.c:67:
+		if (!strcmp(current->data, data)) return;

ERROR: do not use assignment in if condition
#77: FILE: john_core/src/list.c:77:
+		if (!(prev->next = prev->next->next)) list->tail = prev;

ERROR: trailing statements should be on next line
#77: FILE: john_core/src/list.c:77:
+		if (!(prev->next = prev->next->next)) list->tail = prev;

ERROR: do not use assignment in if condition
#79: FILE: john_core/src/list.c:79:
+		if (!(list->head = list->head->next)) list->tail = NULL;

ERROR: trailing statements should be on next line
#79: FILE: john_core/src/list.c:79:
+		if (!(list->head = list->head->next)) list->tail = NULL;

total: 9 errors, 1 warnings, 82 lines checked

john_core/src/list.c has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
ERROR: trailing statements should be on next line
#79: FILE: john_core/src/LM_fmt.c:79:
+	for (pos = ciphertext; atoi16[ARCH_INDEX(*pos)] != 0x7F; pos++);

ERROR: trailing statements should be on next line
#89: FILE: john_core/src/LM_fmt.c:89:
+	if (strncmp(ciphertext, "$LM$", 4)) return 0;

ERROR: trailing statements should be on next line
#91: FILE: john_core/src/LM_fmt.c:91:
+	for (pos = &ciphertext[4]; atoi16[ARCH_INDEX(*pos)] != 0x7F; pos++);

ERROR: trailing statements should be on next line
#92: FILE: john_core/src/LM_fmt.c:92:
+	if (*pos || pos - ciphertext != 20) return 0;

total: 4 errors, 0 warnings, 254 lines checked

john_core/src/LM_fmt.c has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
WARNING: externs should be avoided in .c files
#23: FILE: john_core/src/loader.c:23:
+extern struct fmt_main fmt_crypt;

ERROR: do not initialise statics to 0 or NULL
#40: FILE: john_core/src/loader.c:40:
+static int issep_initialized = 0;

ERROR: trailing statements should be on next line
#54: FILE: john_core/src/loader.c:54:
+				if (errno == ENOENT) return;

ERROR: trailing statements should be on next line
#57: FILE: john_core/src/loader.c:57:
+			if (S_ISDIR(file_stat.st_mode)) return;

ERROR: do not use assignment in if condition
#60: FILE: john_core/src/loader.c:60:
+	if (!(file = fopen(path_expand(name), "r"))) {

ERROR: trailing statements should be on next line
#61: FILE: john_core/src/loader.c:61:
+		if ((flags & RF_ALLOW_MISSING) && errno == ENOENT) return;

ERROR: trailing statements should be on next line
#70: FILE: john_core/src/loader.c:70:
+	if (ferror(file)) pexit("fgets");

ERROR: trailing statements should be on next line
#72: FILE: john_core/src/loader.c:72:
+	if (fclose(file)) pexit("fclose");

ERROR: trailing statements should be on next line
#79: FILE: john_core/src/loader.c:79:
+	if (issep_initialized) return;

ERROR: trailing statements should be on next line
#163: FILE: john_core/src/loader.c:163:
+	if (!*ptr) return "";

ERROR: do not use assignment in if condition
#165: FILE: john_core/src/loader.c:165:
+	if ((pos = strchr(res = *ptr, ':'))) {

ERROR: trailing statements should be on next line
#170: FILE: john_core/src/loader.c:170:
+			if (*pos == '\r' || *pos == '\n') *pos = 0;

ERROR: do not use assignment in if condition
#183: FILE: john_core/src/loader.c:183:
+	if (!(current = list->head)) return 0;

ERROR: trailing statements should be on next line
#183: FILE: john_core/src/loader.c:183:
+	if (!(current = list->head)) return 0;

ERROR: trailing statements should be on next line
#188: FILE: john_core/src/loader.c:188:
+			if (!strcmp(s1, data) || !strcmp(s2, data)) return 1;

ERROR: do not use assignment in if condition
#189: FILE: john_core/src/loader.c:189:
+			if ((current = current->next)) data = current->data;

ERROR: trailing statements should be on next line
#189: FILE: john_core/src/loader.c:189:
+			if ((current = current->next)) data = current->data;

ERROR: trailing statements should be on next line
#194: FILE: john_core/src/loader.c:194:
+			if (!strcmp(s1, data) || !strcmp(s2, data)) return 0;

ERROR: do not use assignment in if condition
#207: FILE: john_core/src/loader.c:207:
+		if ((name = strrchr(shell, '/'))) name++; else name = shell;

ERROR: trailing statements should be on next line
#207: FILE: john_core/src/loader.c:207:
+		if ((name = strrchr(shell, '/'))) name++; else name = shell;

WARNING: suspect code indent for conditional statements (8, 0)
#231: FILE: john_core/src/loader.c:231:
+	if (!**ciphertext && !line) {
+/* Possible hash on a line on its own (no colons) */

ERROR: trailing statements should be on next line
#235: FILE: john_core/src/loader.c:235:
+		while (*p == ' ' || *p == '\t') p++;

ERROR: trailing statements should be on next line
#238: FILE: john_core/src/loader.c:238:
+		while (p > *ciphertext && (*p == ' ' || *p == '\t')) p--;

WARNING: suspect code indent for conditional statements (16, 0)
#242: FILE: john_core/src/loader.c:242:
+		if (strncmp(*ciphertext, "$dummy$", 7) &&
[...]
+/* Check for a special case: possibly a traditional crypt(3) hash with

WARNING: Missing a blank line after declarations
#307: FILE: john_core/src/loader.c:307:
+			int shift = strlen(uid);
+			memmove(source + shift + 1, source, strlen(source) + 1);

ERROR: trailing statements should be on next line
#313: FILE: john_core/src/loader.c:313:
+	if (ldr_check_list(options->users, *login, uid)) return 0;

ERROR: trailing statements should be on next line
#314: FILE: john_core/src/loader.c:314:
+	if (ldr_check_list(options->groups, gid, gid)) return 0;

ERROR: trailing statements should be on next line
#315: FILE: john_core/src/loader.c:315:
+	if (ldr_check_shells(options->shells, shell)) return 0;

WARNING: quoted string split across lines
#353: FILE: john_core/src/loader.c:353:
+				    "Warning: only loading hashes of type "
+				    "\"%s\", but also saw type \"%s\"\n"

WARNING: quoted string split across lines
#355: FILE: john_core/src/loader.c:355:
+				    "Use the \"--format=%s\" option to force "
+				    "loading hashes of that type instead\n",

WARNING: suspect code indent for conditional statements (8, 8)
#367: FILE: john_core/src/loader.c:367:
+	if ((alt = fmt_list))
+	do {

ERROR: do not use assignment in if condition
#367: FILE: john_core/src/loader.c:367:
+	if ((alt = fmt_list))

WARNING: quoted string split across lines
#410: FILE: john_core/src/loader.c:410:
+		    "Warning: detected hash type \"%s\", but the string is "
+		    "also recognized as \"%s\"\n"

WARNING: quoted string split across lines
#412: FILE: john_core/src/loader.c:412:
+		    "Use the \"--format=%s\" option to force loading these "
+		    "as that type instead\n",

ERROR: trailing statements should be on next line
#429: FILE: john_core/src/loader.c:429:
+		while (*word && issep_map[ARCH_INDEX(*word)]) word++;

ERROR: trailing statements should be on next line
#430: FILE: john_core/src/loader.c:430:
+		if (!*word) break;

ERROR: trailing statements should be on next line
#433: FILE: john_core/src/loader.c:433:
+		while (!issep_map[ARCH_INDEX(*pos)]) pos++;

ERROR: do not use assignment in if condition
#454: FILE: john_core/src/loader.c:454:
+	if ((pos = strrchr(home, '/')) && pos[1])

ERROR: do not initialise statics to 0 or NULL
#462: FILE: john_core/src/loader.c:462:
+	static int skip_dupe_checking = 0;

ERROR: trailing statements should be on next line
#476: FILE: john_core/src/loader.c:476:
+	if (count <= 0) return;

ERROR: trailing statements should be on next line
#477: FILE: john_core/src/loader.c:477:
+	if (count >= 2) db->options->flags |= DB_SPLIT;

WARNING: Missing a blank line after declarations
#508: FILE: john_core/src/loader.c:508:
+			int collisions = 0;
+			if ((current_pw = db->password_hash[pw_hash]))

WARNING: suspect code indent for conditional statements (24, 24)
#508: FILE: john_core/src/loader.c:508:
+			if ((current_pw = db->password_hash[pw_hash]))
+			do {

ERROR: do not use assignment in if condition
#508: FILE: john_core/src/loader.c:508:
+			if ((current_pw = db->password_hash[pw_hash]))

WARNING: quoted string split across lines
#521: FILE: john_core/src/loader.c:521:
+					fprintf(stderr, "Warning: "
+					    "excessive partial hash "

WARNING: quoted string split across lines
#522: FILE: john_core/src/loader.c:522:
+					    "excessive partial hash "
+					    "collisions detected\n%s",

WARNING: quoted string split across lines
#526: FILE: john_core/src/loader.c:526:
+					    "(cause: the \"format\" lacks "
+					    "proper binary_hash() function "

WARNING: quoted string split across lines
#527: FILE: john_core/src/loader.c:527:
+					    "proper binary_hash() function "
+					    "definitions)\n");

WARNING: quoted string split across lines
#530: FILE: john_core/src/loader.c:530:
+					fprintf(stderr, "Warning: "
+					    "check for duplicates partially "

WARNING: quoted string split across lines
#531: FILE: john_core/src/loader.c:531:
+					    "check for duplicates partially "
+					    "bypassed to speedup loading\n");

ERROR: trailing statements should be on next line
#537: FILE: john_core/src/loader.c:537:
+			if (current_pw) continue;

WARNING: suspect code indent for conditional statements (16, 16)
#543: FILE: john_core/src/loader.c:543:
+		if ((current_salt = db->salt_hash[salt_hash]))
+		do {

ERROR: do not use assignment in if condition
#543: FILE: john_core/src/loader.c:543:
+		if ((current_salt = db->salt_hash[salt_hash]))

ERROR: trailing statements should be on next line
#638: FILE: john_core/src/loader.c:638:
+	if (format->methods.valid(ciphertext, format) != 1) return;

WARNING: suspect code indent for conditional statements (8, 8)
#644: FILE: john_core/src/loader.c:644:
+	if ((current = db->password_hash[hash]))
+	do {

ERROR: do not use assignment in if condition
#644: FILE: john_core/src/loader.c:644:
+	if ((current = db->password_hash[hash]))

WARNING: suspect code indent for conditional statements (8, 8)
#684: FILE: john_core/src/loader.c:684:
+	for (hash = 0, tail = &db->salts; hash < SALT_HASH_SIZE; hash++)
+	if ((current = db->salt_hash[hash])) {

ERROR: do not use assignment in if condition
#685: FILE: john_core/src/loader.c:685:
+	if ((current = db->salt_hash[hash])) {

WARNING: suspect code indent for conditional statements (8, 8)
#703: FILE: john_core/src/loader.c:703:
+	if ((current_salt = db->salts))
+	do {

ERROR: do not use assignment in if condition
#703: FILE: john_core/src/loader.c:703:
+	if ((current_salt = db->salts))

WARNING: suspect code indent for conditional statements (16, 16)
#706: FILE: john_core/src/loader.c:706:
+		if ((current_pw = current_salt->list))
+		do {

ERROR: do not use assignment in if condition
#706: FILE: john_core/src/loader.c:706:
+		if ((current_pw = current_salt->list))

ERROR: trailing statements should be on next line
#742: FILE: john_core/src/loader.c:742:
+		if (!min) return;

WARNING: suspect code indent for conditional statements (8, 8)
#747: FILE: john_core/src/loader.c:747:
+	if ((current = db->salts))
+	do {

ERROR: do not use assignment in if condition
#747: FILE: john_core/src/loader.c:747:
+	if ((current = db->salts))

WARNING: suspect code indent for conditional statements (16, 16)
#775: FILE: john_core/src/loader.c:775:
+		if ((current = salt->list))
+		do {

ERROR: do not use assignment in if condition
#775: FILE: john_core/src/loader.c:775:
+		if ((current = salt->list))

WARNING: Missing a blank line after declarations
#796: FILE: john_core/src/loader.c:796:
+		size_t size = hash_size * sizeof(struct db_password *);
+		salt->hash = mem_alloc_tiny(size, MEM_ALIGN_WORD);

WARNING: suspect code indent for conditional statements (8, 8)
#805: FILE: john_core/src/loader.c:805:
+	if ((current = salt->list))
+	do {

ERROR: do not use assignment in if condition
#805: FILE: john_core/src/loader.c:805:
+	if ((current = salt->list))

WARNING: suspect code indent for conditional statements (8, 0)
#830: FILE: john_core/src/loader.c:830:
+	if (db->format && (db->format->params.flags & FMT_BS)) {
+/*

WARNING: suspect code indent for conditional statements (8, 8)
#840: FILE: john_core/src/loader.c:840:
+	if ((current = db->salts))
+	do {

ERROR: do not use assignment in if condition
#840: FILE: john_core/src/loader.c:840:
+	if ((current = db->salts))

WARNING: suspect code indent for conditional statements (8, 0)
#902: FILE: john_core/src/loader.c:902:
+	if (line) {
+/* If just one format was forced on the command line, insist on it */

ERROR: trailing statements should be on next line
#910: FILE: john_core/src/loader.c:910:
+			if (*pos == '\r' || *pos == '\n') *pos = 0;

ERROR: trailing statements should be on next line
#958: FILE: john_core/src/loader.c:958:
+	if (!count) return;

ERROR: trailing statements should be on next line
#961: FILE: john_core/src/loader.c:961:
+	if (!fmt_list->next && !format) return;

ERROR: trailing statements should be on next line
#976: FILE: john_core/src/loader.c:976:
+		if (show) printf("%s:NO PASSWORD", login);

WARNING: suspect code indent for conditional statements (8, 8)
#980: FILE: john_core/src/loader.c:980:
+	for (found = pass = 0; pass == 0 || (pass == 1 && found); pass++)
+	for (index = 0; index < count; index++) {

WARNING: suspect code indent for conditional statements (16, 16)
#988: FILE: john_core/src/loader.c:988:
+		if ((current = db->cracked_hash[hash]))
+		do {

ERROR: do not use assignment in if condition
#988: FILE: john_core/src/loader.c:988:
+		if ((current = db->cracked_hash[hash]))

WARNING: Missing a blank line after declarations
#991: FILE: john_core/src/loader.c:991:
+			char *pot = current->ciphertext;
+			if (!strcmp(pot, piece))

ERROR: trailing statements should be on next line
#1030: FILE: john_core/src/loader.c:1030:
+			if (show) printf("%s:", login);

ERROR: trailing statements should be on next line
#1042: FILE: john_core/src/loader.c:1042:
+	if (format || found) db->password_count += count;

total: 52 errors, 32 warnings, 1048 lines checked

john_core/src/loader.c has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
ERROR: do not initialise statics to 0 or NULL
#53: FILE: john_core/src/logger.c:53:
+static int in_logger = 0;

WARNING: suspect code indent for conditional statements (8, 8)
#59: FILE: john_core/src/logger.c:59:
+	if (chmod(path_expand(name), S_IRUSR | S_IWUSR))
+	if (errno != ENOENT)

ERROR: do not use assignment in if condition
#63: FILE: john_core/src/logger.c:63:
+	if ((f->fd = open(path_expand(name),

ERROR: trailing statements should be on next line
#75: FILE: john_core/src/logger.c:75:
+	if (f->fd < 0) return;

ERROR: trailing statements should be on next line
#78: FILE: john_core/src/logger.c:78:
+	if (count <= 0) return;

ERROR: trailing statements should be on next line
#86: FILE: john_core/src/logger.c:86:
+	if (write_loop(f->fd, f->buffer, count) < 0) pexit("write");

ERROR: trailing statements should be on next line
#106: FILE: john_core/src/logger.c:106:
+	if (f->fd < 0) return;

ERROR: trailing statements should be on next line
#110: FILE: john_core/src/logger.c:110:
+	if (fsync(f->fd)) pexit("fsync");

ERROR: trailing statements should be on next line
#116: FILE: john_core/src/logger.c:116:
+	if (f->fd < 0) return;

ERROR: trailing statements should be on next line
#122: FILE: john_core/src/logger.c:122:
+	if (close(f->fd)) pexit("close");

ERROR: trailing statements should be on next line
#183: FILE: john_core/src/logger.c:183:
+		if (count1 > 0) pot.ptr += count1;

ERROR: trailing statements should be on next line
#218: FILE: john_core/src/logger.c:218:
+	if (log.fd < 0) return;

ERROR: trailing statements should be on next line
#224: FILE: john_core/src/logger.c:224:
+	if (in_logger) return;

ERROR: trailing statements should be on next line
#273: FILE: john_core/src/logger.c:273:
+	if (in_logger) return;

total: 13 errors, 1 warnings, 280 lines checked

john_core/src/logger.c has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
ERROR: trailing statements should be on next line
#25: FILE: john_core/src/math.c:25:
+	if (dst->lo < saved) dst->hi++;

ERROR: trailing statements should be on next line
#87: FILE: john_core/src/math.c:87:
+	if (hi >= d) return 0xFFFFFFFF;

total: 2 errors, 0 warnings, 116 lines checked

john_core/src/math.c has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
ERROR: trailing statements should be on next line
#80: FILE: john_core/src/MD5_fmt.c:80:
+	for (pos = &ciphertext[3]; *pos && *pos != '$'; pos++);

ERROR: trailing statements should be on next line
#81: FILE: john_core/src/MD5_fmt.c:81:
+	if (!*pos || pos < &ciphertext[3] || pos > &ciphertext[11]) return 0;

ERROR: trailing statements should be on next line
#84: FILE: john_core/src/MD5_fmt.c:84:
+	while (atoi64[ARCH_INDEX(*pos)] != 0x7F) pos++;

ERROR: trailing statements should be on next line
#85: FILE: john_core/src/MD5_fmt.c:85:
+	if (*pos || pos - start != CIPHERTEXT_LENGTH) return 0;

ERROR: trailing statements should be on next line
#87: FILE: john_core/src/MD5_fmt.c:87:
+	if (atoi64[ARCH_INDEX(*(pos - 1))] & 0x3C) return 0;

WARNING: Missing a blank line after declarations
#206: FILE: john_core/src/MD5_fmt.c:206:
+	int count = *pcount;
+	MD5_std_crypt(count);

total: 5 errors, 1 warnings, 298 lines checked

john_core/src/MD5_fmt.c has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
ERROR: Macros with complex values should be enclosed in parentheses
#254: FILE: john_core/src/MD5_std.c:254:
+#define ROTATE_LEFT(x, n) \
+	(x) = (((x) << (n)) | ((MD5_word)(x) >> (32 - (n))))

ERROR: Macros with multiple statements should be enclosed in a do - while loop
#262: FILE: john_core/src/MD5_std.c:262:
+#define FF(a, b, c, d, x, s, ac) \
+	(a) += F ((b), (c), (d)) + (x) + (ac); \
+	ROTATE_LEFT ((a), (s)); \
+	(a) += (b);

WARNING: macros should not use a trailing semicolon
#262: FILE: john_core/src/MD5_std.c:262:
+#define FF(a, b, c, d, x, s, ac) \
+	(a) += F ((b), (c), (d)) + (x) + (ac); \
+	ROTATE_LEFT ((a), (s)); \
+	(a) += (b);

WARNING: space prohibited between function name and open parenthesis '('
#263: FILE: john_core/src/MD5_std.c:263:
+	(a) += F ((b), (c), (d)) + (x) + (ac); \

WARNING: space prohibited between function name and open parenthesis '('
#264: FILE: john_core/src/MD5_std.c:264:
+	ROTATE_LEFT ((a), (s)); \

ERROR: Macros with multiple statements should be enclosed in a do - while loop
#267: FILE: john_core/src/MD5_std.c:267:
+#define GG(a, b, c, d, x, s, ac) \
+	(a) += G ((b), (c), (d)) + (x) + (ac); \
+	ROTATE_LEFT ((a), (s)); \
+	(a) += (b);

WARNING: macros should not use a trailing semicolon
#267: FILE: john_core/src/MD5_std.c:267:
+#define GG(a, b, c, d, x, s, ac) \
+	(a) += G ((b), (c), (d)) + (x) + (ac); \
+	ROTATE_LEFT ((a), (s)); \
+	(a) += (b);

WARNING: space prohibited between function name and open parenthesis '('
#268: FILE: john_core/src/MD5_std.c:268:
+	(a) += G ((b), (c), (d)) + (x) + (ac); \

WARNING: space prohibited between function name and open parenthesis '('
#269: FILE: john_core/src/MD5_std.c:269:
+	ROTATE_LEFT ((a), (s)); \

ERROR: Macros with multiple statements should be enclosed in a do - while loop
#272: FILE: john_core/src/MD5_std.c:272:
+#define HH(a, b, c, d, x, s, ac) \
+	(a) += H ((b), (c), (d)) + (x) + (ac); \
+	ROTATE_LEFT ((a), (s)); \
+	(a) += (b);

WARNING: macros should not use a trailing semicolon
#272: FILE: john_core/src/MD5_std.c:272:
+#define HH(a, b, c, d, x, s, ac) \
+	(a) += H ((b), (c), (d)) + (x) + (ac); \
+	ROTATE_LEFT ((a), (s)); \
+	(a) += (b);

WARNING: space prohibited between function name and open parenthesis '('
#273: FILE: john_core/src/MD5_std.c:273:
+	(a) += H ((b), (c), (d)) + (x) + (ac); \

WARNING: space prohibited between function name and open parenthesis '('
#274: FILE: john_core/src/MD5_std.c:274:
+	ROTATE_LEFT ((a), (s)); \

ERROR: Macros with multiple statements should be enclosed in a do - while loop
#277: FILE: john_core/src/MD5_std.c:277:
+#define II(a, b, c, d, x, s, ac) \
+	(a) += I ((b), (c), (d)) + (x) + (ac); \
+	ROTATE_LEFT ((a), (s)); \
+	(a) += (b);

WARNING: macros should not use a trailing semicolon
#277: FILE: john_core/src/MD5_std.c:277:
+#define II(a, b, c, d, x, s, ac) \
+	(a) += I ((b), (c), (d)) + (x) + (ac); \
+	ROTATE_LEFT ((a), (s)); \
+	(a) += (b);

WARNING: space prohibited between function name and open parenthesis '('
#278: FILE: john_core/src/MD5_std.c:278:
+	(a) += I ((b), (c), (d)) + (x) + (ac); \

WARNING: space prohibited between function name and open parenthesis '('
#279: FILE: john_core/src/MD5_std.c:279:
+	ROTATE_LEFT ((a), (s)); \

WARNING: Missing a blank line after declarations
#335: FILE: john_core/src/MD5_std.c:335:
+			int max = n * MD5_std_cpt;
+			while (max > MD5_std_mt_max)

WARNING: macros should not use a trailing semicolon
#358: FILE: john_core/src/MD5_std.c:358:
+#define init_line(line, init_even, init_odd) \
+	order[line][index].even = init_even; \
+	order[line][index].odd = init_odd;

ERROR: trailing statements should be on next line
#396: FILE: john_core/src/MD5_std.c:396:
+	for (length = 0; length < 8 && salt[length]; length++);

ERROR: trailing statements should be on next line
#427: FILE: john_core/src/MD5_std.c:427:
+	for (length = 0; key[length] && length < 15; length++);

WARNING: externs should be avoided in .c files
#462: FILE: john_core/src/MD5_std.c:462:
+extern void MD5_body(MD5_word x[15], MD5_word out[4]);

WARNING: space prohibited between function name and open parenthesis '('
#490: FILE: john_core/src/MD5_std.c:490:
+	ROTATE_LEFT (a, S11); a += b;			/* 1 */

WARNING: space prohibited between function name and open parenthesis '('
#492: FILE: john_core/src/MD5_std.c:492:
+	ROTATE_LEFT (d, S12); d += a;			/* 2 */

WARNING: space prohibited between function name and open parenthesis '('
#497: FILE: john_core/src/MD5_std.c:497:
+	FF (a, b, c, d, x[ 4], S11, AC5);		/* 5 */

ERROR: space prohibited after that open square bracket '['
#497: FILE: john_core/src/MD5_std.c:497:
+	FF (a, b, c, d, x[ 4], S11, AC5);		/* 5 */

WARNING: space prohibited between function name and open parenthesis '('
#498: FILE: john_core/src/MD5_std.c:498:
+	FF (d, a, b, c, x[ 5], S12, AC6);		/* 6 */

ERROR: space prohibited after that open square bracket '['
#498: FILE: john_core/src/MD5_std.c:498:
+	FF (d, a, b, c, x[ 5], S12, AC6);		/* 6 */

WARNING: space prohibited between function name and open parenthesis '('
#499: FILE: john_core/src/MD5_std.c:499:
+	FF (c, d, a, b, x[ 6], S13, AC7);		/* 7 */

ERROR: space prohibited after that open square bracket '['
#499: FILE: john_core/src/MD5_std.c:499:
+	FF (c, d, a, b, x[ 6], S13, AC7);		/* 7 */

WARNING: space prohibited between function name and open parenthesis '('
#500: FILE: john_core/src/MD5_std.c:500:
+	FF (b, c, d, a, x[ 7], S14, AC8);		/* 8 */

ERROR: space prohibited after that open square bracket '['
#500: FILE: john_core/src/MD5_std.c:500:
+	FF (b, c, d, a, x[ 7], S14, AC8);		/* 8 */

WARNING: space prohibited between function name and open parenthesis '('
#501: FILE: john_core/src/MD5_std.c:501:
+	FF (a, b, c, d, x[ 8], S11, AC9);		/* 9 */

ERROR: space prohibited after that open square bracket '['
#501: FILE: john_core/src/MD5_std.c:501:
+	FF (a, b, c, d, x[ 8], S11, AC9);		/* 9 */

WARNING: space prohibited between function name and open parenthesis '('
#502: FILE: john_core/src/MD5_std.c:502:
+	FF (d, a, b, c, x[ 9], S12, AC10);		/* 10 */

ERROR: space prohibited after that open square bracket '['
#502: FILE: john_core/src/MD5_std.c:502:
+	FF (d, a, b, c, x[ 9], S12, AC10);		/* 10 */

WARNING: space prohibited between function name and open parenthesis '('
#503: FILE: john_core/src/MD5_std.c:503:
+	FF (c, d, a, b, x[10], S13, AC11);		/* 11 */

WARNING: space prohibited between function name and open parenthesis '('
#504: FILE: john_core/src/MD5_std.c:504:
+	FF (b, c, d, a, x[11], S14, AC12);		/* 12 */

WARNING: space prohibited between function name and open parenthesis '('
#505: FILE: john_core/src/MD5_std.c:505:
+	FF (a, b, c, d, x[12], S11, AC13);		/* 13 */

WARNING: space prohibited between function name and open parenthesis '('
#506: FILE: john_core/src/MD5_std.c:506:
+	FF (d, a, b, c, x[13], S12, AC14);		/* 14 */

WARNING: space prohibited between function name and open parenthesis '('
#507: FILE: john_core/src/MD5_std.c:507:
+	FF (c, d, a, b, x[14], S13, AC15);		/* 15 */

WARNING: space prohibited between function name and open parenthesis '('
#508: FILE: john_core/src/MD5_std.c:508:
+	b += F (c, d, a) + AC16;

WARNING: space prohibited between function name and open parenthesis '('
#509: FILE: john_core/src/MD5_std.c:509:
+	ROTATE_LEFT (b, S14); b += c;			/* 16 */

WARNING: space prohibited between function name and open parenthesis '('
#512: FILE: john_core/src/MD5_std.c:512:
+	GG (a, b, c, d, x[ 1], S21, AC17);		/* 17 */

ERROR: space prohibited after that open square bracket '['
#512: FILE: john_core/src/MD5_std.c:512:
+	GG (a, b, c, d, x[ 1], S21, AC17);		/* 17 */

WARNING: space prohibited between function name and open parenthesis '('
#513: FILE: john_core/src/MD5_std.c:513:
+	GG (d, a, b, c, x[ 6], S22, AC18);		/* 18 */

ERROR: space prohibited after that open square bracket '['
#513: FILE: john_core/src/MD5_std.c:513:
+	GG (d, a, b, c, x[ 6], S22, AC18);		/* 18 */

WARNING: space prohibited between function name and open parenthesis '('
#514: FILE: john_core/src/MD5_std.c:514:
+	GG (c, d, a, b, x[11], S23, AC19);		/* 19 */

WARNING: space prohibited between function name and open parenthesis '('
#515: FILE: john_core/src/MD5_std.c:515:
+	GG (b, c, d, a, x[ 0], S24, AC20);		/* 20 */

ERROR: space prohibited after that open square bracket '['
#515: FILE: john_core/src/MD5_std.c:515:
+	GG (b, c, d, a, x[ 0], S24, AC20);		/* 20 */

WARNING: space prohibited between function name and open parenthesis '('
#516: FILE: john_core/src/MD5_std.c:516:
+	GG (a, b, c, d, x[ 5], S21, AC21);		/* 21 */

ERROR: space prohibited after that open square bracket '['
#516: FILE: john_core/src/MD5_std.c:516:
+	GG (a, b, c, d, x[ 5], S21, AC21);		/* 21 */

WARNING: space prohibited between function name and open parenthesis '('
#517: FILE: john_core/src/MD5_std.c:517:
+	GG (d, a, b, c, x[10], S22, AC22);		/* 22 */

WARNING: space prohibited between function name and open parenthesis '('
#518: FILE: john_core/src/MD5_std.c:518:
+	c += G (d, a, b) + AC23;

WARNING: space prohibited between function name and open parenthesis '('
#519: FILE: john_core/src/MD5_std.c:519:
+	ROTATE_LEFT (c, S23); c += d;			/* 23 */

WARNING: space prohibited between function name and open parenthesis '('
#520: FILE: john_core/src/MD5_std.c:520:
+	GG (b, c, d, a, x[ 4], S24, AC24);		/* 24 */

ERROR: space prohibited after that open square bracket '['
#520: FILE: john_core/src/MD5_std.c:520:
+	GG (b, c, d, a, x[ 4], S24, AC24);		/* 24 */

WARNING: space prohibited between function name and open parenthesis '('
#521: FILE: john_core/src/MD5_std.c:521:
+	GG (a, b, c, d, x[ 9], S21, AC25);		/* 25 */

ERROR: space prohibited after that open square bracket '['
#521: FILE: john_core/src/MD5_std.c:521:
+	GG (a, b, c, d, x[ 9], S21, AC25);		/* 25 */

WARNING: space prohibited between function name and open parenthesis '('
#522: FILE: john_core/src/MD5_std.c:522:
+	GG (d, a, b, c, x[14], S22, AC26);		/* 26 */

WARNING: space prohibited between function name and open parenthesis '('
#523: FILE: john_core/src/MD5_std.c:523:
+	GG (c, d, a, b, x[ 3], S23, AC27);		/* 27 */

ERROR: space prohibited after that open square bracket '['
#523: FILE: john_core/src/MD5_std.c:523:
+	GG (c, d, a, b, x[ 3], S23, AC27);		/* 27 */

WARNING: space prohibited between function name and open parenthesis '('
#524: FILE: john_core/src/MD5_std.c:524:
+	GG (b, c, d, a, x[ 8], S24, AC28);		/* 28 */

ERROR: space prohibited after that open square bracket '['
#524: FILE: john_core/src/MD5_std.c:524:
+	GG (b, c, d, a, x[ 8], S24, AC28);		/* 28 */

WARNING: space prohibited between function name and open parenthesis '('
#525: FILE: john_core/src/MD5_std.c:525:
+	GG (a, b, c, d, x[13], S21, AC29);		/* 29 */

WARNING: space prohibited between function name and open parenthesis '('
#526: FILE: john_core/src/MD5_std.c:526:
+	GG (d, a, b, c, x[ 2], S22, AC30);		/* 30 */

ERROR: space prohibited after that open square bracket '['
#526: FILE: john_core/src/MD5_std.c:526:
+	GG (d, a, b, c, x[ 2], S22, AC30);		/* 30 */

WARNING: space prohibited between function name and open parenthesis '('
#527: FILE: john_core/src/MD5_std.c:527:
+	GG (c, d, a, b, x[ 7], S23, AC31);		/* 31 */

ERROR: space prohibited after that open square bracket '['
#527: FILE: john_core/src/MD5_std.c:527:
+	GG (c, d, a, b, x[ 7], S23, AC31);		/* 31 */

WARNING: space prohibited between function name and open parenthesis '('
#528: FILE: john_core/src/MD5_std.c:528:
+	GG (b, c, d, a, x[12], S24, AC32);		/* 32 */

WARNING: space prohibited between function name and open parenthesis '('
#531: FILE: john_core/src/MD5_std.c:531:
+	HH (a, b, c, d, x[ 5], S31, AC33);		/* 33 */

ERROR: space prohibited after that open square bracket '['
#531: FILE: john_core/src/MD5_std.c:531:
+	HH (a, b, c, d, x[ 5], S31, AC33);		/* 33 */

WARNING: space prohibited between function name and open parenthesis '('
#532: FILE: john_core/src/MD5_std.c:532:
+	HH (d, a, b, c, x[ 8], S32, AC34);		/* 34 */

ERROR: space prohibited after that open square bracket '['
#532: FILE: john_core/src/MD5_std.c:532:
+	HH (d, a, b, c, x[ 8], S32, AC34);		/* 34 */

WARNING: space prohibited between function name and open parenthesis '('
#533: FILE: john_core/src/MD5_std.c:533:
+	HH (c, d, a, b, x[11], S33, AC35);		/* 35 */

WARNING: space prohibited between function name and open parenthesis '('
#534: FILE: john_core/src/MD5_std.c:534:
+	HH (b, c, d, a, x[14], S34, AC36);		/* 36 */

WARNING: space prohibited between function name and open parenthesis '('
#535: FILE: john_core/src/MD5_std.c:535:
+	HH (a, b, c, d, x[ 1], S31, AC37);		/* 37 */

ERROR: space prohibited after that open square bracket '['
#535: FILE: john_core/src/MD5_std.c:535:
+	HH (a, b, c, d, x[ 1], S31, AC37);		/* 37 */

WARNING: space prohibited between function name and open parenthesis '('
#536: FILE: john_core/src/MD5_std.c:536:
+	HH (d, a, b, c, x[ 4], S32, AC38);		/* 38 */

ERROR: space prohibited after that open square bracket '['
#536: FILE: john_core/src/MD5_std.c:536:
+	HH (d, a, b, c, x[ 4], S32, AC38);		/* 38 */

WARNING: space prohibited between function name and open parenthesis '('
#537: FILE: john_core/src/MD5_std.c:537:
+	HH (c, d, a, b, x[ 7], S33, AC39);		/* 39 */

ERROR: space prohibited after that open square bracket '['
#537: FILE: john_core/src/MD5_std.c:537:
+	HH (c, d, a, b, x[ 7], S33, AC39);		/* 39 */

WARNING: space prohibited between function name and open parenthesis '('
#538: FILE: john_core/src/MD5_std.c:538:
+	HH (b, c, d, a, x[10], S34, AC40);		/* 40 */

WARNING: space prohibited between function name and open parenthesis '('
#539: FILE: john_core/src/MD5_std.c:539:
+	HH (a, b, c, d, x[13], S31, AC41);		/* 41 */

WARNING: space prohibited between function name and open parenthesis '('
#540: FILE: john_core/src/MD5_std.c:540:
+	HH (d, a, b, c, x[ 0], S32, AC42);		/* 42 */

ERROR: space prohibited after that open square bracket '['
#540: FILE: john_core/src/MD5_std.c:540:
+	HH (d, a, b, c, x[ 0], S32, AC42);		/* 42 */

WARNING: space prohibited between function name and open parenthesis '('
#541: FILE: john_core/src/MD5_std.c:541:
+	HH (c, d, a, b, x[ 3], S33, AC43);		/* 43 */

ERROR: space prohibited after that open square bracket '['
#541: FILE: john_core/src/MD5_std.c:541:
+	HH (c, d, a, b, x[ 3], S33, AC43);		/* 43 */

WARNING: space prohibited between function name and open parenthesis '('
#542: FILE: john_core/src/MD5_std.c:542:
+	HH (b, c, d, a, x[ 6], S34, AC44);		/* 44 */

ERROR: space prohibited after that open square bracket '['
#542: FILE: john_core/src/MD5_std.c:542:
+	HH (b, c, d, a, x[ 6], S34, AC44);		/* 44 */

WARNING: space prohibited between function name and open parenthesis '('
#543: FILE: john_core/src/MD5_std.c:543:
+	HH (a, b, c, d, x[ 9], S31, AC45);		/* 45 */

ERROR: space prohibited after that open square bracket '['
#543: FILE: john_core/src/MD5_std.c:543:
+	HH (a, b, c, d, x[ 9], S31, AC45);		/* 45 */

WARNING: space prohibited between function name and open parenthesis '('
#544: FILE: john_core/src/MD5_std.c:544:
+	HH (d, a, b, c, x[12], S32, AC46);		/* 46 */

WARNING: space prohibited between function name and open parenthesis '('
#545: FILE: john_core/src/MD5_std.c:545:
+	c += H (d, a, b) + AC47;

WARNING: space prohibited between function name and open parenthesis '('
#546: FILE: john_core/src/MD5_std.c:546:
+	ROTATE_LEFT (c, S33); c += d;			/* 47 */

WARNING: space prohibited between function name and open parenthesis '('
#547: FILE: john_core/src/MD5_std.c:547:
+	HH (b, c, d, a, x[ 2], S34, AC48);		/* 48 */

ERROR: space prohibited after that open square bracket '['
#547: FILE: john_core/src/MD5_std.c:547:
+	HH (b, c, d, a, x[ 2], S34, AC48);		/* 48 */

WARNING: space prohibited between function name and open parenthesis '('
#550: FILE: john_core/src/MD5_std.c:550:
+	II (a, b, c, d, x[ 0], S41, AC49);		/* 49 */

ERROR: space prohibited after that open square bracket '['
#550: FILE: john_core/src/MD5_std.c:550:
+	II (a, b, c, d, x[ 0], S41, AC49);		/* 49 */

WARNING: space prohibited between function name and open parenthesis '('
#551: FILE: john_core/src/MD5_std.c:551:
+	II (d, a, b, c, x[ 7], S42, AC50);		/* 50 */

ERROR: space prohibited after that open square bracket '['
#551: FILE: john_core/src/MD5_std.c:551:
+	II (d, a, b, c, x[ 7], S42, AC50);		/* 50 */

WARNING: space prohibited between function name and open parenthesis '('
#552: FILE: john_core/src/MD5_std.c:552:
+	II (c, d, a, b, x[14], S43, AC51);		/* 51 */

WARNING: space prohibited between function name and open parenthesis '('
#553: FILE: john_core/src/MD5_std.c:553:
+	II (b, c, d, a, x[ 5], S44, AC52);		/* 52 */

ERROR: space prohibited after that open square bracket '['
#553: FILE: john_core/src/MD5_std.c:553:
+	II (b, c, d, a, x[ 5], S44, AC52);		/* 52 */

WARNING: space prohibited between function name and open parenthesis '('
#554: FILE: john_core/src/MD5_std.c:554:
+	II (a, b, c, d, x[12], S41, AC53);		/* 53 */

WARNING: space prohibited between function name and open parenthesis '('
#555: FILE: john_core/src/MD5_std.c:555:
+	II (d, a, b, c, x[ 3], S42, AC54);		/* 54 */

ERROR: space prohibited after that open square bracket '['
#555: FILE: john_core/src/MD5_std.c:555:
+	II (d, a, b, c, x[ 3], S42, AC54);		/* 54 */

WARNING: space prohibited between function name and open parenthesis '('
#556: FILE: john_core/src/MD5_std.c:556:
+	II (c, d, a, b, x[10], S43, AC55);		/* 55 */

WARNING: space prohibited between function name and open parenthesis '('
#557: FILE: john_core/src/MD5_std.c:557:
+	II (b, c, d, a, x[ 1], S44, AC56);		/* 56 */

ERROR: space prohibited after that open square bracket '['
#557: FILE: john_core/src/MD5_std.c:557:
+	II (b, c, d, a, x[ 1], S44, AC56);		/* 56 */

WARNING: space prohibited between function name and open parenthesis '('
#558: FILE: john_core/src/MD5_std.c:558:
+	II (a, b, c, d, x[ 8], S41, AC57);		/* 57 */

ERROR: space prohibited after that open square bracket '['
#558: FILE: john_core/src/MD5_std.c:558:
+	II (a, b, c, d, x[ 8], S41, AC57);		/* 57 */

WARNING: space prohibited between function name and open parenthesis '('
#559: FILE: john_core/src/MD5_std.c:559:
+	d += I (a, b, c) + AC58;

WARNING: space prohibited between function name and open parenthesis '('
#560: FILE: john_core/src/MD5_std.c:560:
+	ROTATE_LEFT (d, S42); d += a;			/* 58 */

WARNING: space prohibited between function name and open parenthesis '('
#561: FILE: john_core/src/MD5_std.c:561:
+	II (c, d, a, b, x[ 6], S43, AC59);		/* 59 */

ERROR: space prohibited after that open square bracket '['
#561: FILE: john_core/src/MD5_std.c:561:
+	II (c, d, a, b, x[ 6], S43, AC59);		/* 59 */

WARNING: space prohibited between function name and open parenthesis '('
#562: FILE: john_core/src/MD5_std.c:562:
+	II (b, c, d, a, x[13], S44, AC60);		/* 60 */

WARNING: space prohibited between function name and open parenthesis '('
#563: FILE: john_core/src/MD5_std.c:563:
+	II (a, b, c, d, x[ 4], S41, AC61);		/* 61 */

ERROR: space prohibited after that open square bracket '['
#563: FILE: john_core/src/MD5_std.c:563:
+	II (a, b, c, d, x[ 4], S41, AC61);		/* 61 */

WARNING: space prohibited between function name and open parenthesis '('
#564: FILE: john_core/src/MD5_std.c:564:
+	II (d, a, b, c, x[11], S42, AC62);		/* 62 */

WARNING: space prohibited between function name and open parenthesis '('
#565: FILE: john_core/src/MD5_std.c:565:
+	II (c, d, a, b, x[ 2], S43, AC63);		/* 63 */

ERROR: space prohibited after that open square bracket '['
#565: FILE: john_core/src/MD5_std.c:565:
+	II (c, d, a, b, x[ 2], S43, AC63);		/* 63 */

WARNING: space prohibited between function name and open parenthesis '('
#566: FILE: john_core/src/MD5_std.c:566:
+	II (b, c, d, a, x[ 9], S44, AC64);		/* 64 */

ERROR: space prohibited after that open square bracket '['
#566: FILE: john_core/src/MD5_std.c:566:
+	II (b, c, d, a, x[ 9], S44, AC64);		/* 64 */

WARNING: space prohibited between function name and open parenthesis '('
#593: FILE: john_core/src/MD5_std.c:593:
+	ROTATE_LEFT (a0, S11); a0 += b0;		/* 1 */

WARNING: space prohibited between function name and open parenthesis '('
#595: FILE: john_core/src/MD5_std.c:595:
+	ROTATE_LEFT (a1, S11); a1 += b0;		/* 1 */

WARNING: space prohibited between function name and open parenthesis '('
#597: FILE: john_core/src/MD5_std.c:597:
+	ROTATE_LEFT (d0, S12); d0 += a0;		/* 2 */

WARNING: space prohibited between function name and open parenthesis '('
#599: FILE: john_core/src/MD5_std.c:599:
+	ROTATE_LEFT (d1, S12); d1 += a1;		/* 2 */

WARNING: space prohibited between function name and open parenthesis '('
#608: FILE: john_core/src/MD5_std.c:608:
+	FF (a0, b0, c0, d0, x0[ 4], S11, (u = AC5));	/* 5 */

ERROR: space prohibited after that open square bracket '['
#608: FILE: john_core/src/MD5_std.c:608:
+	FF (a0, b0, c0, d0, x0[ 4], S11, (u = AC5));	/* 5 */

WARNING: space prohibited between function name and open parenthesis '('
#609: FILE: john_core/src/MD5_std.c:609:
+	FF (a1, b1, c1, d1, x1[ 4], S11, u);		/* 5 */

ERROR: space prohibited after that open square bracket '['
#609: FILE: john_core/src/MD5_std.c:609:
+	FF (a1, b1, c1, d1, x1[ 4], S11, u);		/* 5 */

WARNING: space prohibited between function name and open parenthesis '('
#610: FILE: john_core/src/MD5_std.c:610:
+	FF (d0, a0, b0, c0, x0[ 5], S12, (u = AC6));	/* 6 */

ERROR: space prohibited after that open square bracket '['
#610: FILE: john_core/src/MD5_std.c:610:
+	FF (d0, a0, b0, c0, x0[ 5], S12, (u = AC6));	/* 6 */

WARNING: space prohibited between function name and open parenthesis '('
#611: FILE: john_core/src/MD5_std.c:611:
+	FF (d1, a1, b1, c1, x1[ 5], S12, u);		/* 6 */

ERROR: space prohibited after that open square bracket '['
#611: FILE: john_core/src/MD5_std.c:611:
+	FF (d1, a1, b1, c1, x1[ 5], S12, u);		/* 6 */

WARNING: space prohibited between function name and open parenthesis '('
#612: FILE: john_core/src/MD5_std.c:612:
+	FF (c0, d0, a0, b0, x0[ 6], S13, (u = AC7));	/* 7 */

ERROR: space prohibited after that open square bracket '['
#612: FILE: john_core/src/MD5_std.c:612:
+	FF (c0, d0, a0, b0, x0[ 6], S13, (u = AC7));	/* 7 */

WARNING: space prohibited between function name and open parenthesis '('
#613: FILE: john_core/src/MD5_std.c:613:
+	FF (c1, d1, a1, b1, x1[ 6], S13, u);		/* 7 */

ERROR: space prohibited after that open square bracket '['
#613: FILE: john_core/src/MD5_std.c:613:
+	FF (c1, d1, a1, b1, x1[ 6], S13, u);		/* 7 */

WARNING: space prohibited between function name and open parenthesis '('
#614: FILE: john_core/src/MD5_std.c:614:
+	FF (b0, c0, d0, a0, x0[ 7], S14, (u = AC8));	/* 8 */

ERROR: space prohibited after that open square bracket '['
#614: FILE: john_core/src/MD5_std.c:614:
+	FF (b0, c0, d0, a0, x0[ 7], S14, (u = AC8));	/* 8 */

WARNING: space prohibited between function name and open parenthesis '('
#615: FILE: john_core/src/MD5_std.c:615:
+	FF (b1, c1, d1, a1, x1[ 7], S14, u);		/* 8 */

ERROR: space prohibited after that open square bracket '['
#615: FILE: john_core/src/MD5_std.c:615:
+	FF (b1, c1, d1, a1, x1[ 7], S14, u);		/* 8 */

WARNING: space prohibited between function name and open parenthesis '('
#616: FILE: john_core/src/MD5_std.c:616:
+	FF (a0, b0, c0, d0, x0[ 8], S11, (u = AC9));	/* 9 */

ERROR: space prohibited after that open square bracket '['
#616: FILE: john_core/src/MD5_std.c:616:
+	FF (a0, b0, c0, d0, x0[ 8], S11, (u = AC9));	/* 9 */

WARNING: space prohibited between function name and open parenthesis '('
#617: FILE: john_core/src/MD5_std.c:617:
+	FF (a1, b1, c1, d1, x1[ 8], S11, u);		/* 9 */

ERROR: space prohibited after that open square bracket '['
#617: FILE: john_core/src/MD5_std.c:617:
+	FF (a1, b1, c1, d1, x1[ 8], S11, u);		/* 9 */

WARNING: space prohibited between function name and open parenthesis '('
#618: FILE: john_core/src/MD5_std.c:618:
+	FF (d0, a0, b0, c0, x0[ 9], S12, (u = AC10));	/* 10 */

ERROR: space prohibited after that open square bracket '['
#618: FILE: john_core/src/MD5_std.c:618:
+	FF (d0, a0, b0, c0, x0[ 9], S12, (u = AC10));	/* 10 */

WARNING: space prohibited between function name and open parenthesis '('
#619: FILE: john_core/src/MD5_std.c:619:
+	FF (d1, a1, b1, c1, x1[ 9], S12, u);		/* 10 */

ERROR: space prohibited after that open square bracket '['
#619: FILE: john_core/src/MD5_std.c:619:
+	FF (d1, a1, b1, c1, x1[ 9], S12, u);		/* 10 */

WARNING: space prohibited between function name and open parenthesis '('
#620: FILE: john_core/src/MD5_std.c:620:
+	FF (c0, d0, a0, b0, x0[10], S13, (u = AC11));	/* 11 */

WARNING: space prohibited between function name and open parenthesis '('
#621: FILE: john_core/src/MD5_std.c:621:
+	FF (c1, d1, a1, b1, x1[10], S13, u);		/* 11 */

WARNING: space prohibited between function name and open parenthesis '('
#622: FILE: john_core/src/MD5_std.c:622:
+	FF (b0, c0, d0, a0, x0[11], S14, (u = AC12));	/* 12 */

WARNING: space prohibited between function name and open parenthesis '('
#623: FILE: john_core/src/MD5_std.c:623:
+	FF (b1, c1, d1, a1, x1[11], S14, u);		/* 12 */

WARNING: space prohibited between function name and open parenthesis '('
#624: FILE: john_core/src/MD5_std.c:624:
+	FF (a0, b0, c0, d0, x0[12], S11, (u = AC13));	/* 13 */

WARNING: space prohibited between function name and open parenthesis '('
#625: FILE: john_core/src/MD5_std.c:625:
+	FF (a1, b1, c1, d1, x1[12], S11, u);		/* 13 */

WARNING: space prohibited between function name and open parenthesis '('
#626: FILE: john_core/src/MD5_std.c:626:
+	FF (d0, a0, b0, c0, x0[13], S12, (u = AC14));	/* 14 */

WARNING: space prohibited between function name and open parenthesis '('
#627: FILE: john_core/src/MD5_std.c:627:
+	FF (d1, a1, b1, c1, x1[13], S12, u);		/* 14 */

WARNING: space prohibited between function name and open parenthesis '('
#628: FILE: john_core/src/MD5_std.c:628:
+	FF (c0, d0, a0, b0, x0[14], S13, (u = AC15));	/* 15 */

WARNING: space prohibited between function name and open parenthesis '('
#629: FILE: john_core/src/MD5_std.c:629:
+	FF (c1, d1, a1, b1, x1[14], S13, u);		/* 15 */

WARNING: space prohibited between function name and open parenthesis '('
#630: FILE: john_core/src/MD5_std.c:630:
+	b0 += F (c0, d0, a0) + (u = AC16);

WARNING: space prohibited between function name and open parenthesis '('
#631: FILE: john_core/src/MD5_std.c:631:
+	ROTATE_LEFT (b0, S14); b0 += c0;		/* 16 */

WARNING: space prohibited between function name and open parenthesis '('
#632: FILE: john_core/src/MD5_std.c:632:
+	b1 += F (c1, d1, a1) + u;

WARNING: space prohibited between function name and open parenthesis '('
#633: FILE: john_core/src/MD5_std.c:633:
+	ROTATE_LEFT (b1, S14); b1 += c1;		/* 16 */

WARNING: space prohibited between function name and open parenthesis '('
#636: FILE: john_core/src/MD5_std.c:636:
+	GG (a0, b0, c0, d0, x0[ 1], S21, (u = AC17));	/* 17 */

ERROR: space prohibited after that open square bracket '['
#636: FILE: john_core/src/MD5_std.c:636:
+	GG (a0, b0, c0, d0, x0[ 1], S21, (u = AC17));	/* 17 */

WARNING: space prohibited between function name and open parenthesis '('
#637: FILE: john_core/src/MD5_std.c:637:
+	GG (a1, b1, c1, d1, x1[ 1], S21, u);		/* 17 */

ERROR: space prohibited after that open square bracket '['
#637: FILE: john_core/src/MD5_std.c:637:
+	GG (a1, b1, c1, d1, x1[ 1], S21, u);		/* 17 */

WARNING: space prohibited between function name and open parenthesis '('
#638: FILE: john_core/src/MD5_std.c:638:
+	GG (d0, a0, b0, c0, x0[ 6], S22, (u = AC18));	/* 18 */

ERROR: space prohibited after that open square bracket '['
#638: FILE: john_core/src/MD5_std.c:638:
+	GG (d0, a0, b0, c0, x0[ 6], S22, (u = AC18));	/* 18 */

WARNING: space prohibited between function name and open parenthesis '('
#639: FILE: john_core/src/MD5_std.c:639:
+	GG (d1, a1, b1, c1, x1[ 6], S22, u);		/* 18 */

ERROR: space prohibited after that open square bracket '['
#639: FILE: john_core/src/MD5_std.c:639:
+	GG (d1, a1, b1, c1, x1[ 6], S22, u);		/* 18 */

WARNING: space prohibited between function name and open parenthesis '('
#640: FILE: john_core/src/MD5_std.c:640:
+	GG (c0, d0, a0, b0, x0[11], S23, (u = AC19));	/* 19 */

WARNING: space prohibited between function name and open parenthesis '('
#641: FILE: john_core/src/MD5_std.c:641:
+	GG (c1, d1, a1, b1, x1[11], S23, u);		/* 19 */

WARNING: space prohibited between function name and open parenthesis '('
#642: FILE: john_core/src/MD5_std.c:642:
+	GG (b0, c0, d0, a0, x0[ 0], S24, (u = AC20));	/* 20 */

ERROR: space prohibited after that open square bracket '['
#642: FILE: john_core/src/MD5_std.c:642:
+	GG (b0, c0, d0, a0, x0[ 0], S24, (u = AC20));	/* 20 */

WARNING: space prohibited between function name and open parenthesis '('
#643: FILE: john_core/src/MD5_std.c:643:
+	GG (b1, c1, d1, a1, x1[ 0], S24, u);		/* 20 */

ERROR: space prohibited after that open square bracket '['
#643: FILE: john_core/src/MD5_std.c:643:
+	GG (b1, c1, d1, a1, x1[ 0], S24, u);		/* 20 */

WARNING: space prohibited between function name and open parenthesis '('
#644: FILE: john_core/src/MD5_std.c:644:
+	GG (a0, b0, c0, d0, x0[ 5], S21, (u = AC21));	/* 21 */

ERROR: space prohibited after that open square bracket '['
#644: FILE: john_core/src/MD5_std.c:644:
+	GG (a0, b0, c0, d0, x0[ 5], S21, (u = AC21));	/* 21 */

WARNING: space prohibited between function name and open parenthesis '('
#645: FILE: john_core/src/MD5_std.c:645:
+	GG (a1, b1, c1, d1, x1[ 5], S21, u);		/* 21 */

ERROR: space prohibited after that open square bracket '['
#645: FILE: john_core/src/MD5_std.c:645:
+	GG (a1, b1, c1, d1, x1[ 5], S21, u);		/* 21 */

WARNING: space prohibited between function name and open parenthesis '('
#646: FILE: john_core/src/MD5_std.c:646:
+	GG (d0, a0, b0, c0, x0[10], S22, (u = AC22));	/* 22 */

WARNING: space prohibited between function name and open parenthesis '('
#647: FILE: john_core/src/MD5_std.c:647:
+	GG (d1, a1, b1, c1, x1[10], S22, u);		/* 22 */

WARNING: space prohibited between function name and open parenthesis '('
#648: FILE: john_core/src/MD5_std.c:648:
+	c0 += G (d0, a0, b0) + (u = AC23);

WARNING: space prohibited between function name and open parenthesis '('
#649: FILE: john_core/src/MD5_std.c:649:
+	ROTATE_LEFT (c0, S23); c0 += d0;		/* 23 */

WARNING: space prohibited between function name and open parenthesis '('
#650: FILE: john_core/src/MD5_std.c:650:
+	c1 += G (d1, a1, b1) + u;

WARNING: space prohibited between function name and open parenthesis '('
#651: FILE: john_core/src/MD5_std.c:651:
+	ROTATE_LEFT (c1, S23); c1 += d1;		/* 23 */

WARNING: space prohibited between function name and open parenthesis '('
#652: FILE: john_core/src/MD5_std.c:652:
+	GG (b0, c0, d0, a0, x0[ 4], S24, (u = AC24));	/* 24 */

ERROR: space prohibited after that open square bracket '['
#652: FILE: john_core/src/MD5_std.c:652:
+	GG (b0, c0, d0, a0, x0[ 4], S24, (u = AC24));	/* 24 */

WARNING: space prohibited between function name and open parenthesis '('
#653: FILE: john_core/src/MD5_std.c:653:
+	GG (b1, c1, d1, a1, x1[ 4], S24, u);		/* 24 */

ERROR: space prohibited after that open square bracket '['
#653: FILE: john_core/src/MD5_std.c:653:
+	GG (b1, c1, d1, a1, x1[ 4], S24, u);		/* 24 */

WARNING: space prohibited between function name and open parenthesis '('
#654: FILE: john_core/src/MD5_std.c:654:
+	GG (a0, b0, c0, d0, x0[ 9], S21, (u = AC25));	/* 25 */

ERROR: space prohibited after that open square bracket '['
#654: FILE: john_core/src/MD5_std.c:654:
+	GG (a0, b0, c0, d0, x0[ 9], S21, (u = AC25));	/* 25 */

WARNING: space prohibited between function name and open parenthesis '('
#655: FILE: john_core/src/MD5_std.c:655:
+	GG (a1, b1, c1, d1, x1[ 9], S21, u);		/* 25 */

ERROR: space prohibited after that open square bracket '['
#655: FILE: john_core/src/MD5_std.c:655:
+	GG (a1, b1, c1, d1, x1[ 9], S21, u);		/* 25 */

WARNING: space prohibited between function name and open parenthesis '('
#656: FILE: john_core/src/MD5_std.c:656:
+	GG (d0, a0, b0, c0, x0[14], S22, (u = AC26));	/* 26 */

WARNING: space prohibited between function name and open parenthesis '('
#657: FILE: john_core/src/MD5_std.c:657:
+	GG (d1, a1, b1, c1, x1[14], S22, u);		/* 26 */

WARNING: space prohibited between function name and open parenthesis '('
#658: FILE: john_core/src/MD5_std.c:658:
+	GG (c0, d0, a0, b0, x0[ 3], S23, (u = AC27));	/* 27 */

ERROR: space prohibited after that open square bracket '['
#658: FILE: john_core/src/MD5_std.c:658:
+	GG (c0, d0, a0, b0, x0[ 3], S23, (u = AC27));	/* 27 */

WARNING: space prohibited between function name and open parenthesis '('
#659: FILE: john_core/src/MD5_std.c:659:
+	GG (c1, d1, a1, b1, x1[ 3], S23, u);		/* 27 */

ERROR: space prohibited after that open square bracket '['
#659: FILE: john_core/src/MD5_std.c:659:
+	GG (c1, d1, a1, b1, x1[ 3], S23, u);		/* 27 */

WARNING: space prohibited between function name and open parenthesis '('
#660: FILE: john_core/src/MD5_std.c:660:
+	GG (b0, c0, d0, a0, x0[ 8], S24, (u = AC28));	/* 28 */

ERROR: space prohibited after that open square bracket '['
#660: FILE: john_core/src/MD5_std.c:660:
+	GG (b0, c0, d0, a0, x0[ 8], S24, (u = AC28));	/* 28 */

WARNING: space prohibited between function name and open parenthesis '('
#661: FILE: john_core/src/MD5_std.c:661:
+	GG (b1, c1, d1, a1, x1[ 8], S24, u);		/* 28 */

ERROR: space prohibited after that open square bracket '['
#661: FILE: john_core/src/MD5_std.c:661:
+	GG (b1, c1, d1, a1, x1[ 8], S24, u);		/* 28 */

WARNING: space prohibited between function name and open parenthesis '('
#662: FILE: john_core/src/MD5_std.c:662:
+	GG (a0, b0, c0, d0, x0[13], S21, (u = AC29));	/* 29 */

WARNING: space prohibited between function name and open parenthesis '('
#663: FILE: john_core/src/MD5_std.c:663:
+	GG (a1, b1, c1, d1, x1[13], S21, u);		/* 29 */

WARNING: space prohibited between function name and open parenthesis '('
#664: FILE: john_core/src/MD5_std.c:664:
+	GG (d0, a0, b0, c0, x0[ 2], S22, (u = AC30));	/* 30 */

ERROR: space prohibited after that open square bracket '['
#664: FILE: john_core/src/MD5_std.c:664:
+	GG (d0, a0, b0, c0, x0[ 2], S22, (u = AC30));	/* 30 */

WARNING: space prohibited between function name and open parenthesis '('
#665: FILE: john_core/src/MD5_std.c:665:
+	GG (d1, a1, b1, c1, x1[ 2], S22, u);		/* 30 */

ERROR: space prohibited after that open square bracket '['
#665: FILE: john_core/src/MD5_std.c:665:
+	GG (d1, a1, b1, c1, x1[ 2], S22, u);		/* 30 */

WARNING: space prohibited between function name and open parenthesis '('
#666: FILE: john_core/src/MD5_std.c:666:
+	GG (c0, d0, a0, b0, x0[ 7], S23, (u = AC31));	/* 31 */

ERROR: space prohibited after that open square bracket '['
#666: FILE: john_core/src/MD5_std.c:666:
+	GG (c0, d0, a0, b0, x0[ 7], S23, (u = AC31));	/* 31 */

WARNING: space prohibited between function name and open parenthesis '('
#667: FILE: john_core/src/MD5_std.c:667:
+	GG (c1, d1, a1, b1, x1[ 7], S23, u);		/* 31 */

ERROR: space prohibited after that open square bracket '['
#667: FILE: john_core/src/MD5_std.c:667:
+	GG (c1, d1, a1, b1, x1[ 7], S23, u);		/* 31 */

WARNING: space prohibited between function name and open parenthesis '('
#668: FILE: john_core/src/MD5_std.c:668:
+	GG (b0, c0, d0, a0, x0[12], S24, (u = AC32));	/* 32 */

WARNING: space prohibited between function name and open parenthesis '('
#669: FILE: john_core/src/MD5_std.c:669:
+	GG (b1, c1, d1, a1, x1[12], S24, u);		/* 32 */

WARNING: space prohibited between function name and open parenthesis '('
#672: FILE: john_core/src/MD5_std.c:672:
+	HH (a0, b0, c0, d0, x0[ 5], S31, (u = AC33));	/* 33 */

ERROR: space prohibited after that open square bracket '['
#672: FILE: john_core/src/MD5_std.c:672:
+	HH (a0, b0, c0, d0, x0[ 5], S31, (u = AC33));	/* 33 */

WARNING: space prohibited between function name and open parenthesis '('
#673: FILE: john_core/src/MD5_std.c:673:
+	HH (a1, b1, c1, d1, x1[ 5], S31, u);		/* 33 */

ERROR: space prohibited after that open square bracket '['
#673: FILE: john_core/src/MD5_std.c:673:
+	HH (a1, b1, c1, d1, x1[ 5], S31, u);		/* 33 */

WARNING: space prohibited between function name and open parenthesis '('
#674: FILE: john_core/src/MD5_std.c:674:
+	HH (d0, a0, b0, c0, x0[ 8], S32, (u = AC34));	/* 34 */

ERROR: space prohibited after that open square bracket '['
#674: FILE: john_core/src/MD5_std.c:674:
+	HH (d0, a0, b0, c0, x0[ 8], S32, (u = AC34));	/* 34 */

WARNING: space prohibited between function name and open parenthesis '('
#675: FILE: john_core/src/MD5_std.c:675:
+	HH (d1, a1, b1, c1, x1[ 8], S32, u);		/* 34 */

ERROR: space prohibited after that open square bracket '['
#675: FILE: john_core/src/MD5_std.c:675:
+	HH (d1, a1, b1, c1, x1[ 8], S32, u);		/* 34 */

WARNING: space prohibited between function name and open parenthesis '('
#676: FILE: john_core/src/MD5_std.c:676:
+	HH (c0, d0, a0, b0, x0[11], S33, (u = AC35));	/* 35 */

WARNING: space prohibited between function name and open parenthesis '('
#677: FILE: john_core/src/MD5_std.c:677:
+	HH (c1, d1, a1, b1, x1[11], S33, u);		/* 35 */

WARNING: space prohibited between function name and open parenthesis '('
#678: FILE: john_core/src/MD5_std.c:678:
+	HH (b0, c0, d0, a0, x0[14], S34, (u = AC36));	/* 36 */

WARNING: space prohibited between function name and open parenthesis '('
#679: FILE: john_core/src/MD5_std.c:679:
+	HH (b1, c1, d1, a1, x1[14], S34, u);		/* 36 */

WARNING: space prohibited between function name and open parenthesis '('
#680: FILE: john_core/src/MD5_std.c:680:
+	HH (a0, b0, c0, d0, x0[ 1], S31, (u = AC37));	/* 37 */

ERROR: space prohibited after that open square bracket '['
#680: FILE: john_core/src/MD5_std.c:680:
+	HH (a0, b0, c0, d0, x0[ 1], S31, (u = AC37));	/* 37 */

WARNING: space prohibited between function name and open parenthesis '('
#681: FILE: john_core/src/MD5_std.c:681:
+	HH (a1, b1, c1, d1, x1[ 1], S31, u);		/* 37 */

ERROR: space prohibited after that open square bracket '['
#681: FILE: john_core/src/MD5_std.c:681:
+	HH (a1, b1, c1, d1, x1[ 1], S31, u);		/* 37 */

WARNING: space prohibited between function name and open parenthesis '('
#682: FILE: john_core/src/MD5_std.c:682:
+	HH (d0, a0, b0, c0, x0[ 4], S32, (u = AC38));	/* 38 */

ERROR: space prohibited after that open square bracket '['
#682: FILE: john_core/src/MD5_std.c:682:
+	HH (d0, a0, b0, c0, x0[ 4], S32, (u = AC38));	/* 38 */

WARNING: space prohibited between function name and open parenthesis '('
#683: FILE: john_core/src/MD5_std.c:683:
+	HH (d1, a1, b1, c1, x1[ 4], S32, u);		/* 38 */

ERROR: space prohibited after that open square bracket '['
#683: FILE: john_core/src/MD5_std.c:683:
+	HH (d1, a1, b1, c1, x1[ 4], S32, u);		/* 38 */

WARNING: space prohibited between function name and open parenthesis '('
#684: FILE: john_core/src/MD5_std.c:684:
+	HH (c0, d0, a0, b0, x0[ 7], S33, (u = AC39));	/* 39 */

ERROR: space prohibited after that open square bracket '['
#684: FILE: john_core/src/MD5_std.c:684:
+	HH (c0, d0, a0, b0, x0[ 7], S33, (u = AC39));	/* 39 */

WARNING: space prohibited between function name and open parenthesis '('
#685: FILE: john_core/src/MD5_std.c:685:
+	HH (c1, d1, a1, b1, x1[ 7], S33, u);		/* 39 */

ERROR: space prohibited after that open square bracket '['
#685: FILE: john_core/src/MD5_std.c:685:
+	HH (c1, d1, a1, b1, x1[ 7], S33, u);		/* 39 */

WARNING: space prohibited between function name and open parenthesis '('
#686: FILE: john_core/src/MD5_std.c:686:
+	HH (b0, c0, d0, a0, x0[10], S34, (u = AC40));	/* 40 */

WARNING: space prohibited between function name and open parenthesis '('
#687: FILE: john_core/src/MD5_std.c:687:
+	HH (b1, c1, d1, a1, x1[10], S34, u);		/* 40 */

WARNING: space prohibited between function name and open parenthesis '('
#688: FILE: john_core/src/MD5_std.c:688:
+	HH (a0, b0, c0, d0, x0[13], S31, (u = AC41));	/* 41 */

WARNING: space prohibited between function name and open parenthesis '('
#689: FILE: john_core/src/MD5_std.c:689:
+	HH (a1, b1, c1, d1, x1[13], S31, u);		/* 41 */

WARNING: space prohibited between function name and open parenthesis '('
#690: FILE: john_core/src/MD5_std.c:690:
+	HH (d0, a0, b0, c0, x0[ 0], S32, (u = AC42));	/* 42 */

ERROR: space prohibited after that open square bracket '['
#690: FILE: john_core/src/MD5_std.c:690:
+	HH (d0, a0, b0, c0, x0[ 0], S32, (u = AC42));	/* 42 */

WARNING: space prohibited between function name and open parenthesis '('
#691: FILE: john_core/src/MD5_std.c:691:
+	HH (d1, a1, b1, c1, x1[ 0], S32, u);		/* 42 */

ERROR: space prohibited after that open square bracket '['
#691: FILE: john_core/src/MD5_std.c:691:
+	HH (d1, a1, b1, c1, x1[ 0], S32, u);		/* 42 */

WARNING: space prohibited between function name and open parenthesis '('
#692: FILE: john_core/src/MD5_std.c:692:
+	HH (c0, d0, a0, b0, x0[ 3], S33, (u = AC43));	/* 43 */

ERROR: space prohibited after that open square bracket '['
#692: FILE: john_core/src/MD5_std.c:692:
+	HH (c0, d0, a0, b0, x0[ 3], S33, (u = AC43));	/* 43 */

WARNING: space prohibited between function name and open parenthesis '('
#693: FILE: john_core/src/MD5_std.c:693:
+	HH (c1, d1, a1, b1, x1[ 3], S33, u);		/* 43 */

ERROR: space prohibited after that open square bracket '['
#693: FILE: john_core/src/MD5_std.c:693:
+	HH (c1, d1, a1, b1, x1[ 3], S33, u);		/* 43 */

WARNING: space prohibited between function name and open parenthesis '('
#694: FILE: john_core/src/MD5_std.c:694:
+	HH (b0, c0, d0, a0, x0[ 6], S34, (u = AC44));	/* 44 */

ERROR: space prohibited after that open square bracket '['
#694: FILE: john_core/src/MD5_std.c:694:
+	HH (b0, c0, d0, a0, x0[ 6], S34, (u = AC44));	/* 44 */

WARNING: space prohibited between function name and open parenthesis '('
#695: FILE: john_core/src/MD5_std.c:695:
+	HH (b1, c1, d1, a1, x1[ 6], S34, u);		/* 44 */

ERROR: space prohibited after that open square bracket '['
#695: FILE: john_core/src/MD5_std.c:695:
+	HH (b1, c1, d1, a1, x1[ 6], S34, u);		/* 44 */

WARNING: space prohibited between function name and open parenthesis '('
#696: FILE: john_core/src/MD5_std.c:696:
+	HH (a0, b0, c0, d0, x0[ 9], S31, (u = AC45));	/* 45 */

ERROR: space prohibited after that open square bracket '['
#696: FILE: john_core/src/MD5_std.c:696:
+	HH (a0, b0, c0, d0, x0[ 9], S31, (u = AC45));	/* 45 */

WARNING: space prohibited between function name and open parenthesis '('
#697: FILE: john_core/src/MD5_std.c:697:
+	HH (a1, b1, c1, d1, x1[ 9], S31, u);		/* 45 */

ERROR: space prohibited after that open square bracket '['
#697: FILE: john_core/src/MD5_std.c:697:
+	HH (a1, b1, c1, d1, x1[ 9], S31, u);		/* 45 */

WARNING: space prohibited between function name and open parenthesis '('
#698: FILE: john_core/src/MD5_std.c:698:
+	HH (d0, a0, b0, c0, x0[12], S32, (u = AC46));	/* 46 */

WARNING: space prohibited between function name and open parenthesis '('
#699: FILE: john_core/src/MD5_std.c:699:
+	HH (d1, a1, b1, c1, x1[12], S32, u);		/* 46 */

WARNING: space prohibited between function name and open parenthesis '('
#700: FILE: john_core/src/MD5_std.c:700:
+	c0 += H (d0, a0, b0) + (u = AC47);

WARNING: space prohibited between function name and open parenthesis '('
#701: FILE: john_core/src/MD5_std.c:701:
+	ROTATE_LEFT (c0, S33); c0 += d0;		/* 47 */

WARNING: space prohibited between function name and open parenthesis '('
#702: FILE: john_core/src/MD5_std.c:702:
+	c1 += H (d1, a1, b1) + u;

WARNING: space prohibited between function name and open parenthesis '('
#703: FILE: john_core/src/MD5_std.c:703:
+	ROTATE_LEFT (c1, S33); c1 += d1;		/* 47 */

WARNING: space prohibited between function name and open parenthesis '('
#704: FILE: john_core/src/MD5_std.c:704:
+	HH (b0, c0, d0, a0, x0[ 2], S34, (u = AC48));	/* 48 */

ERROR: space prohibited after that open square bracket '['
#704: FILE: john_core/src/MD5_std.c:704:
+	HH (b0, c0, d0, a0, x0[ 2], S34, (u = AC48));	/* 48 */

WARNING: space prohibited between function name and open parenthesis '('
#705: FILE: john_core/src/MD5_std.c:705:
+	HH (b1, c1, d1, a1, x1[ 2], S34, u);		/* 48 */

ERROR: space prohibited after that open square bracket '['
#705: FILE: john_core/src/MD5_std.c:705:
+	HH (b1, c1, d1, a1, x1[ 2], S34, u);		/* 48 */

WARNING: space prohibited between function name and open parenthesis '('
#708: FILE: john_core/src/MD5_std.c:708:
+	II (a0, b0, c0, d0, x0[ 0], S41, (u = AC49));	/* 49 */

ERROR: space prohibited after that open square bracket '['
#708: FILE: john_core/src/MD5_std.c:708:
+	II (a0, b0, c0, d0, x0[ 0], S41, (u = AC49));	/* 49 */

WARNING: space prohibited between function name and open parenthesis '('
#709: FILE: john_core/src/MD5_std.c:709:
+	II (a1, b1, c1, d1, x1[ 0], S41, u);		/* 49 */

ERROR: space prohibited after that open square bracket '['
#709: FILE: john_core/src/MD5_std.c:709:
+	II (a1, b1, c1, d1, x1[ 0], S41, u);		/* 49 */

WARNING: space prohibited between function name and open parenthesis '('
#710: FILE: john_core/src/MD5_std.c:710:
+	II (d0, a0, b0, c0, x0[ 7], S42, (u = AC50));	/* 50 */

ERROR: space prohibited after that open square bracket '['
#710: FILE: john_core/src/MD5_std.c:710:
+	II (d0, a0, b0, c0, x0[ 7], S42, (u = AC50));	/* 50 */

WARNING: space prohibited between function name and open parenthesis '('
#711: FILE: john_core/src/MD5_std.c:711:
+	II (d1, a1, b1, c1, x1[ 7], S42, u);		/* 50 */

ERROR: space prohibited after that open square bracket '['
#711: FILE: john_core/src/MD5_std.c:711:
+	II (d1, a1, b1, c1, x1[ 7], S42, u);		/* 50 */

WARNING: space prohibited between function name and open parenthesis '('
#712: FILE: john_core/src/MD5_std.c:712:
+	II (c0, d0, a0, b0, x0[14], S43, (u = AC51));	/* 51 */

WARNING: space prohibited between function name and open parenthesis '('
#713: FILE: john_core/src/MD5_std.c:713:
+	II (c1, d1, a1, b1, x1[14], S43, u);		/* 51 */

WARNING: space prohibited between function name and open parenthesis '('
#714: FILE: john_core/src/MD5_std.c:714:
+	II (b0, c0, d0, a0, x0[ 5], S44, (u = AC52));	/* 52 */

ERROR: space prohibited after that open square bracket '['
#714: FILE: john_core/src/MD5_std.c:714:
+	II (b0, c0, d0, a0, x0[ 5], S44, (u = AC52));	/* 52 */

WARNING: space prohibited between function name and open parenthesis '('
#715: FILE: john_core/src/MD5_std.c:715:
+	II (b1, c1, d1, a1, x1[ 5], S44, u);		/* 52 */

ERROR: space prohibited after that open square bracket '['
#715: FILE: john_core/src/MD5_std.c:715:
+	II (b1, c1, d1, a1, x1[ 5], S44, u);		/* 52 */

WARNING: space prohibited between function name and open parenthesis '('
#716: FILE: john_core/src/MD5_std.c:716:
+	II (a0, b0, c0, d0, x0[12], S41, (u = AC53));	/* 53 */

WARNING: space prohibited between function name and open parenthesis '('
#717: FILE: john_core/src/MD5_std.c:717:
+	II (a1, b1, c1, d1, x1[12], S41, u);		/* 53 */

WARNING: space prohibited between function name and open parenthesis '('
#718: FILE: john_core/src/MD5_std.c:718:
+	II (d0, a0, b0, c0, x0[ 3], S42, (u = AC54));	/* 54 */

ERROR: space prohibited after that open square bracket '['
#718: FILE: john_core/src/MD5_std.c:718:
+	II (d0, a0, b0, c0, x0[ 3], S42, (u = AC54));	/* 54 */

WARNING: space prohibited between function name and open parenthesis '('
#719: FILE: john_core/src/MD5_std.c:719:
+	II (d1, a1, b1, c1, x1[ 3], S42, u);		/* 54 */

ERROR: space prohibited after that open square bracket '['
#719: FILE: john_core/src/MD5_std.c:719:
+	II (d1, a1, b1, c1, x1[ 3], S42, u);		/* 54 */

WARNING: space prohibited between function name and open parenthesis '('
#720: FILE: john_core/src/MD5_std.c:720:
+	II (c0, d0, a0, b0, x0[10], S43, (u = AC55));	/* 55 */

WARNING: space prohibited between function name and open parenthesis '('
#721: FILE: john_core/src/MD5_std.c:721:
+	II (c1, d1, a1, b1, x1[10], S43, u);		/* 55 */

WARNING: space prohibited between function name and open parenthesis '('
#722: FILE: john_core/src/MD5_std.c:722:
+	II (b0, c0, d0, a0, x0[ 1], S44, (u = AC56));	/* 56 */

ERROR: space prohibited after that open square bracket '['
#722: FILE: john_core/src/MD5_std.c:722:
+	II (b0, c0, d0, a0, x0[ 1], S44, (u = AC56));	/* 56 */

WARNING: space prohibited between function name and open parenthesis '('
#723: FILE: john_core/src/MD5_std.c:723:
+	II (b1, c1, d1, a1, x1[ 1], S44, u);		/* 56 */

ERROR: space prohibited after that open square bracket '['
#723: FILE: john_core/src/MD5_std.c:723:
+	II (b1, c1, d1, a1, x1[ 1], S44, u);		/* 56 */

WARNING: space prohibited between function name and open parenthesis '('
#724: FILE: john_core/src/MD5_std.c:724:
+	II (a0, b0, c0, d0, x0[ 8], S41, (u = AC57));	/* 57 */

ERROR: space prohibited after that open square bracket '['
#724: FILE: john_core/src/MD5_std.c:724:
+	II (a0, b0, c0, d0, x0[ 8], S41, (u = AC57));	/* 57 */

WARNING: space prohibited between function name and open parenthesis '('
#725: FILE: john_core/src/MD5_std.c:725:
+	II (a1, b1, c1, d1, x1[ 8], S41, u);		/* 57 */

ERROR: space prohibited after that open square bracket '['
#725: FILE: john_core/src/MD5_std.c:725:
+	II (a1, b1, c1, d1, x1[ 8], S41, u);		/* 57 */

WARNING: space prohibited between function name and open parenthesis '('
#726: FILE: john_core/src/MD5_std.c:726:
+	d0 += I (a0, b0, c0) + (u = AC58);

WARNING: space prohibited between function name and open parenthesis '('
#727: FILE: john_core/src/MD5_std.c:727:
+	ROTATE_LEFT (d0, S42); d0 += a0;		/* 58 */

WARNING: space prohibited between function name and open parenthesis '('
#728: FILE: john_core/src/MD5_std.c:728:
+	d1 += I (a1, b1, c1) + u;

WARNING: space prohibited between function name and open parenthesis '('
#729: FILE: john_core/src/MD5_std.c:729:
+	ROTATE_LEFT (d1, S42); d1 += a1;		/* 58 */

WARNING: space prohibited between function name and open parenthesis '('
#730: FILE: john_core/src/MD5_std.c:730:
+	II (c0, d0, a0, b0, x0[ 6], S43, (u = AC59));	/* 59 */

ERROR: space prohibited after that open square bracket '['
#730: FILE: john_core/src/MD5_std.c:730:
+	II (c0, d0, a0, b0, x0[ 6], S43, (u = AC59));	/* 59 */

WARNING: space prohibited between function name and open parenthesis '('
#731: FILE: john_core/src/MD5_std.c:731:
+	II (c1, d1, a1, b1, x1[ 6], S43, u);		/* 59 */

ERROR: space prohibited after that open square bracket '['
#731: FILE: john_core/src/MD5_std.c:731:
+	II (c1, d1, a1, b1, x1[ 6], S43, u);		/* 59 */

WARNING: space prohibited between function name and open parenthesis '('
#732: FILE: john_core/src/MD5_std.c:732:
+	II (b0, c0, d0, a0, x0[13], S44, (u = AC60));	/* 60 */

WARNING: space prohibited between function name and open parenthesis '('
#733: FILE: john_core/src/MD5_std.c:733:
+	II (b1, c1, d1, a1, x1[13], S44, u);		/* 60 */

WARNING: space prohibited between function name and open parenthesis '('
#734: FILE: john_core/src/MD5_std.c:734:
+	II (a0, b0, c0, d0, x0[ 4], S41, (u = AC61));	/* 61 */

ERROR: space prohibited after that open square bracket '['
#734: FILE: john_core/src/MD5_std.c:734:
+	II (a0, b0, c0, d0, x0[ 4], S41, (u = AC61));	/* 61 */

WARNING: space prohibited between function name and open parenthesis '('
#735: FILE: john_core/src/MD5_std.c:735:
+	II (a1, b1, c1, d1, x1[ 4], S41, u);		/* 61 */

ERROR: space prohibited after that open square bracket '['
#735: FILE: john_core/src/MD5_std.c:735:
+	II (a1, b1, c1, d1, x1[ 4], S41, u);		/* 61 */

WARNING: space prohibited between function name and open parenthesis '('
#736: FILE: john_core/src/MD5_std.c:736:
+	II (d0, a0, b0, c0, x0[11], S42, (u = AC62));	/* 62 */

WARNING: space prohibited between function name and open parenthesis '('
#737: FILE: john_core/src/MD5_std.c:737:
+	II (d1, a1, b1, c1, x1[11], S42, u);		/* 62 */

WARNING: space prohibited between function name and open parenthesis '('
#738: FILE: john_core/src/MD5_std.c:738:
+	II (c0, d0, a0, b0, x0[ 2], S43, (u = AC63));	/* 63 */

ERROR: space prohibited after that open square bracket '['
#738: FILE: john_core/src/MD5_std.c:738:
+	II (c0, d0, a0, b0, x0[ 2], S43, (u = AC63));	/* 63 */

WARNING: space prohibited between function name and open parenthesis '('
#739: FILE: john_core/src/MD5_std.c:739:
+	II (c1, d1, a1, b1, x1[ 2], S43, u);		/* 63 */

ERROR: space prohibited after that open square bracket '['
#739: FILE: john_core/src/MD5_std.c:739:
+	II (c1, d1, a1, b1, x1[ 2], S43, u);		/* 63 */

WARNING: space prohibited between function name and open parenthesis '('
#740: FILE: john_core/src/MD5_std.c:740:
+	II (b0, c0, d0, a0, x0[ 9], S44, (u = AC64));	/* 64 */

ERROR: space prohibited after that open square bracket '['
#740: FILE: john_core/src/MD5_std.c:740:
+	II (b0, c0, d0, a0, x0[ 9], S44, (u = AC64));	/* 64 */

WARNING: space prohibited between function name and open parenthesis '('
#741: FILE: john_core/src/MD5_std.c:741:
+	II (b1, c1, d1, a1, x1[ 9], S44, u);		/* 64 */

ERROR: space prohibited after that open square bracket '['
#741: FILE: john_core/src/MD5_std.c:741:
+	II (b1, c1, d1, a1, x1[ 9], S44, u);		/* 64 */

WARNING: suspect code indent for conditional statements (16, 16)
#851: FILE: john_core/src/MD5_std.c:851:
+		if ((mask = key->l.p))
+		do {

ERROR: do not use assignment in if condition
#851: FILE: john_core/src/MD5_std.c:851:
+		if ((mask = key->l.p))

ERROR: do not use assignment in if condition
#905: FILE: john_core/src/MD5_std.c:905:
+		if ((line += 2) > &order[20][MD5_N - 1]) line = order[0];

ERROR: trailing statements should be on next line
#905: FILE: john_core/src/MD5_std.c:905:
+		if ((line += 2) > &order[20][MD5_N - 1]) line = order[0];

ERROR: trailing statements should be on next line
#908: FILE: john_core/src/MD5_std.c:908:
+		if (++line > &order[20][0]) line = order[0];

ERROR: do not use assignment in if condition
#929: FILE: john_core/src/MD5_std.c:929:
+		if ((line += 2) > &order[20][MD5_N - 1]) line = order[0];

ERROR: trailing statements should be on next line
#929: FILE: john_core/src/MD5_std.c:929:
+		if ((line += 2) > &order[20][MD5_N - 1]) line = order[0];

ERROR: trailing statements should be on next line
#933: FILE: john_core/src/MD5_std.c:933:
+		if (++line > &order[20][0]) line = order[0];

WARNING: line over 80 characters
#953: FILE: john_core/src/MD5_std.c:953:
+#pragma omp parallel for default(none) private(t) shared(n, salt_changed, saved_salt)

WARNING: suspect code indent for conditional statements (8, 0)
#955: FILE: john_core/src/MD5_std.c:955:
+	for_each_t(n) {
+/*

ERROR: do not use assignment in if condition
#977: FILE: john_core/src/MD5_std.c:977:
+	if ((out[8] = !strncmp(ciphertext, "$apr1$", 6)))

WARNING: macros should not use a trailing semicolon
#989: FILE: john_core/src/MD5_std.c:989:
+#define TO_BINARY(b1, b2, b3) \
+	value = \
+		(MD5_word)atoi64[ARCH_INDEX(pos[0])] | \
+		((MD5_word)atoi64[ARCH_INDEX(pos[1])] << 6) | \
+		((MD5_word)atoi64[ARCH_INDEX(pos[2])] << 12) | \
+		((MD5_word)atoi64[ARCH_INDEX(pos[3])] << 18); \
+	pos += 4; \
+	out.b[b1] = value >> 16; \
+	out.b[b2] = value >> 8; \
+	out.b[b3] = value;

ERROR: trailing statements should be on next line
#1013: FILE: john_core/src/MD5_std.c:1013:
+	while (*pos++ != '$');

total: 124 errors, 217 warnings, 1030 lines checked

john_core/src/MD5_std.c has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
ERROR: trailing statements should be on next line
#26: FILE: john_core/src/memory.c:26:
+	if (!size) return NULL;

ERROR: do not use assignment in if condition
#28: FILE: john_core/src/memory.c:28:
+	if (!(res = malloc(size))) {

ERROR: do not initialise statics to 0 or NULL
#38: FILE: john_core/src/memory.c:38:
+	static char *buffer = NULL;

ERROR: do not initialise statics to 0 or NULL
#39: FILE: john_core/src/memory.c:39:
+	static size_t bufree = 0;

ERROR: trailing statements should be on next line
#87: FILE: john_core/src/memory.c:87:
+	if (!src) return "";

ERROR: trailing statements should be on next line
#88: FILE: john_core/src/memory.c:88:
+	if (!*src) return "";

total: 6 errors, 0 warnings, 92 lines checked

john_core/src/memory.c has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
ERROR: trailing statements should be on next line
#54: FILE: john_core/src/misc.c:54:
+			if (errno == EINTR) continue;

ERROR: do not use assignment in if condition
#71: FILE: john_core/src/misc.c:71:
+	if ((res = fgets(s, size, stream))) {

ERROR: trailing statements should be on next line
#72: FILE: john_core/src/misc.c:72:
+		if (!*res) return res;

WARNING: suspect code indent for conditional statements (24, 24)
#77: FILE: john_core/src/misc.c:77:
+			if (pos > res)
+			if (*--pos == '\r') *pos = 0;

ERROR: trailing statements should be on next line
#78: FILE: john_core/src/misc.c:78:
+			if (*--pos == '\r') *pos = 0;

ERROR: do not use assignment in if condition
#80: FILE: john_core/src/misc.c:80:
+		if ((c = getc(stream)) == '\n') {

ERROR: trailing statements should be on next line
#81: FILE: john_core/src/misc.c:81:
+			if (*pos == '\r') *pos = 0;

ERROR: do not use assignment in if condition
#96: FILE: john_core/src/misc.c:96:
+		if (!(*dptr++ = *sptr++)) break;

ERROR: trailing statements should be on next line
#96: FILE: john_core/src/misc.c:96:
+		if (!(*dptr++ = *sptr++)) break;

ERROR: do not use assignment in if condition
#108: FILE: john_core/src/misc.c:108:
+			if (!(*dptr++ = *sptr++)) break;

ERROR: trailing statements should be on next line
#108: FILE: john_core/src/misc.c:108:
+			if (!(*dptr++ = *sptr++)) break;

Powered by blists - more mailing lists

Your e-mail address:

Powered by Openwall GNU/*/Linux - Powered by OpenVZ