Openwall GNU/*/Linux - a small security-enhanced Linux distro for servers
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 25 Nov 2013 07:46:48 +0100
From: magnum <john.magnum@...hmail.com>
To: john-dev@...ts.openwall.com
Subject: Re: md5crypt-opencl

On 2013-11-24 23:08, Lukas Odzioba wrote:
> 2013/11/24 magnum <john.magnum@...hmail.com>:
>> Could you please post a fixed WIP so I can play around with it. Fixing the
>> obvious bugs give me a FAILED (get_hash[0](0)) so I probably miss something.
>
> That's exactly how bug I fixed manifested. What obvious bugs do you mind?

The ones the compiler warned about: char* vs int* in a couple of places. 
PUTCHAR need an int* destination and a char source. Obviously if both 
are aligned it's much faster to copy *dst++ = *src++ with both being ints.

>> But I see room for improvement unless things are more unaligned than I
>> think.
>
> Code attached, obvious things to do now is get rid of ctx (use ctxs[0]
> instead) and remove this redundant copy after md5_digest.

Thanks, I'll have a look between today's boring stuff.

magnum


Powered by blists - more mailing lists

Your e-mail address:

Powered by Openwall GNU/*/Linux - Powered by OpenVZ