popa3d-users - Re: New to popa3d, SMTP-after-POP-patch

Openwall GNU/*/Linux - a small security-enhanced Linux distro for servers
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Tue, 18 Feb 2003 21:22:52 +0100
From: Georg Horn <horn@...lenz-net.de>
To: popa3d-users@...ts.openwall.com
Subject: Re: New to popa3d, SMTP-after-POP-patch

On Tue, Feb 18, 2003 at 04:47:08AM +0300, Solar Designer wrote:
> On Mon, Feb 10, 2003 at 05:19:40PM +0100, Georg Horn wrote:
> 
> > I have added my SMTP-after-POP solution for sendmail, that i used with
> > qpopper for years, to popa3d, perhaps this is useful for someone... It can
> > be downloaded from http://www.koblenz-net.de/~horn/smtp_after_pop/
> > [...]

> I think I'll add this to the contributed patches list (even though it
> will be the third alternative popa3d patch to do POP-before-SMTP),

Well, but it's the most elegant one (that is i think so ;-)), as it works
without installing additional software or hacking the sendmail configuration.
At least if the access.db-Feature is already installed...
And it works with the current version of popa3d.

> 1. The patch file name.  I generally prefer them to include a patch
> version number such that people may see when a patch is updated.
> Something like popa3d-0.5.1-smtp_after_pop-1.diff would be better

Ok, i uploaded the new patch that also contains your other suggestions
to the address above.

> 2. You're changing some settings in params.h not related to the added
> functionality.  I don't think these should be in the same patch file.
> I think that only your setting of POP_STANDALONE is relevant (because
> you don't implement support for non-standalone).
> 
> 3. You've added the #define SMTP_AFTER_POP below the settings which
> aren't normally edited by someone not hacking on popa3d.  I suggest
> that you move it up in the file, to be right above the comment which
> marks the end of settings which are reasonable to edit.

Yes, i played around with some parameters, that of course must not
neccessarily be changed for my patch. I set these back to the
original values and moved the #define SMTP_AFTER_POP to the
suggested place.

Thanks for listening ;-)
Georg