Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 18 Feb 2003 04:47:08 +0300
From: Solar Designer <solar@...nwall.com>
To: popa3d-users@...ts.openwall.com
Subject: Re: New to popa3d, SMTP-after-POP-patch

On Mon, Feb 10, 2003 at 05:19:40PM +0100, Georg Horn wrote:

Hi,

> i'm new to the popa3d dawemon an this list. I just switched from
> Qualcoms qpopper to popa3d and want to thank you for this nice peace
> of software.

You're welcome.

> I have added my SMTP-after-POP solution for sendmail, that i used with qpopper
> for years, to popa3d, perhaps this is useful for someone... It can be
> downloaded from http://www.koblenz-net.de/~horn/smtp_after_pop/
> 
> This solution follows a slightly modified approach than others. The pop3 daemon
> directly inserts the IP-address of the client into sendmails access.db
> database. So you need no sendmail hack or syslog parsers, but, you need a small
> program that removes addresses again from access.db. You can find all this at
> the address given above.

Thank you for sharing this with me and others.

I think I'll add this to the contributed patches list (even though it
will be the third alternative popa3d patch to do POP-before-SMTP), but
you may want to correct a few things first:

1. The patch file name.  I generally prefer them to include a patch
version number such that people may see when a patch is updated.
Something like popa3d-0.5.1-smtp_after_pop-1.diff would be better
(I've added the "-1").

2. You're changing some settings in params.h not related to the added
functionality.  I don't think these should be in the same patch file.
I think that only your setting of POP_STANDALONE is relevant (because
you don't implement support for non-standalone).

3. You've added the #define SMTP_AFTER_POP below the settings which
aren't normally edited by someone not hacking on popa3d.  I suggest
that you move it up in the file, to be right above the comment which
marks the end of settings which are reasonable to edit.

-- 
/sd

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.