Openwall GNU/*/Linux - a small security-enhanced Linux distro for servers
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sun, 22 Apr 2012 23:49:35 +0400
From: Solar Designer <solar@...nwall.com>
To: owl-dev@...ts.openwall.com
Cc: lav@...s.free.net
Subject: Re: lftp update

On Mon, Apr 16, 2012 at 06:00:01AM +0300, Mesut Can G?rle wrote:
> -lftp-4.3.3-tmprec.patch
> 
> This patch is about "Inaccurate timestamps" (
> https://bugzilla.redhat.com/show_bug.cgi?id=666580). This situation occurs
> always. So I want to add this patch into the package.

Yes, but that patch is a dirty hack, which will have side-effects: the
time_fmt string doesn't have to consist solely of format specifiers, it
may also contain arbitrary text, so with that patch behavior might
differ depending on whether e.g. an English word contains one of the
letters matching the format specifiers being checked for or not.

The patch proposed by JW on the bug entry above makes more sense to me:
it fixes only one aspect of the issue (adds "%s"), but at least it
doesn't make things worse in any other aspect (as far as I am aware).

JW suggests that lftp should keep the maximum possible timestamp
precision in all cases, which sounds right to me, but I don't know why
that need_exact_time thing exists in lftp in the first place (nor did I
try to find out why).  There ought to be a reason for that, so simply
patching it to "need_exact_time=true;" without figuring that out would
also be wrong.  (I guess this might have to do with extra round-trips
being needed to request the exact time with certain protocols - e.g.,
the usual ls-like listings via FTP vs. the MDTM command.  So maybe the
protocol in use should be taken into consideration.)

Thus, if we're not to spend a lot of time on this, we may either not
patch this issue at all or include JW's trivial patch.  Anything else is
either time consuming (work on a proper fix for upstream, which we can't
do without knowing upstream's opinion) or not obviously better. ;-)

Alexander

Powered by blists - more mailing lists

Your e-mail address:

Powered by Openwall GNU/*/Linux - Powered by OpenVZ