Openwall GNU/*/Linux - a small security-enhanced Linux distro for servers
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 6 Dec 2017 15:28:22 -0800
From: Linus Torvalds <torvalds@...ux-foundation.org>
To: Kees Cook <keescook@...omium.org>
Cc: David Laight <David.Laight@...lab.com>, David Miller <davem@...emloft.net>, 
	"geert@...ux-m68k.org" <geert@...ux-m68k.org>, "me@...in.cc" <me@...in.cc>, 
	"kernel-hardening@...ts.openwall.com" <kernel-hardening@...ts.openwall.com>, "Jason@...c4.com" <Jason@...c4.com>, 
	"tytso@....edu" <tytso@....edu>, "pbonzini@...hat.com" <pbonzini@...hat.com>, "tycho@...ho.ws" <tycho@...ho.ws>, 
	"william.c.roberts@...el.com" <william.c.roberts@...el.com>, "tj@...nel.org" <tj@...nel.org>, 
	"Golden_Miller83@...tonmail.ch" <Golden_Miller83@...tonmail.ch>, 
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>, "pmladek@...e.com" <pmladek@...e.com>, 
	"joe@...ches.com" <joe@...ches.com>, "ijc@...lion.org.uk" <ijc@...lion.org.uk>, 
	"sergey.senozhatsky@...il.com" <sergey.senozhatsky@...il.com>, 
	"catalin.marinas@....com" <catalin.marinas@....com>, "wilal.deacon@....com" <wilal.deacon@....com>, 
	"rostedt@...dmis.org" <rostedt@...dmis.org>, "cfries@...gle.com" <cfries@...gle.com>, 
	"olorin@...gle.com" <olorin@...gle.com>, "danielmicay@...il.com" <danielmicay@...il.com>, 
	"tixxdz@...il.com" <tixxdz@...il.com>, "rkrcmar@...hat.com" <rkrcmar@...hat.com>, 
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, 
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>, "sfr@...b.auug.org.au" <sfr@...b.auug.org.au>, 
	"aryabinin@...tuozzo.com" <aryabinin@...tuozzo.com>, "glider@...gle.com" <glider@...gle.com>, 
	"dvyukov@...gle.com" <dvyukov@...gle.com>, 
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>, 
	"sergei.shtylyov@...entembedded.com" <sergei.shtylyov@...entembedded.com>
Subject: Re: [PATCH V11 3/5] printk: hash addresses printed with %p

On Wed, Dec 6, 2017 at 3:21 PM, Kees Cook <keescook@...omium.org> wrote:
> On Wed, Dec 6, 2017 at 2:31 AM, David Laight <David.Laight@...lab.com> wrote:
>>
>> I can also image issues where you want to know whether 2 pointers point
>> into the same structure (like an skb).
>
> This is already retained due to the hashing. i.e. the same pointer
> value will produce the same hash value, so that kind of direct
> comparison still works.

DavidL isn't talking about the _same_ pointer, he's talking about it
being offset from the same base.

But realistically, I don't think we ever hash things like that anyway.

Things like that do show up in register dumps etc during oopses, but
those aren't hashed.

            Linus

Powered by blists - more mailing lists

Your e-mail address:

Powered by Openwall GNU/*/Linux - Powered by OpenVZ