Openwall GNU/*/Linux - a small security-enhanced Linux distro for servers
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 23 Sep 2015 23:12:08 +0200
From: Agnieszka Bielec <bielecagnieszka8@...il.com>
To: john-dev@...ts.openwall.com
Subject: Re: Agnieszka's GSoC formats

2015-09-22 1:57 GMT+02:00 magnum <john.magnum@...hmail.com>:
> On 22/09/15 01:14, Agnieszka Bielec wrote:
>>
>> 2015-09-13 21:04 GMT+02:00 Agnieszka Bielec <bielecagnieszka8@...il.com>:
>>>
>>> I did PR but it's not ideal.
>>> additionally Lyra2-opencl using new computations of gws and lws
>>> doesn't work on 960m
>>
>>
>> repaired, wasn't working also on super, but on test on github
>> lyra2-opencl fails, can I got an access to this opencl-device?
>
>
> That build-bot is using the CPU device of an fglrx driver. Super's device 3
> should be the same, did you try that?

lyra2 is ok on super

> I see the bots have some weird failures in your branch:
> https://circleci.com/gh/magnumripper/JohnTheRipper/1041
> https://travis-ci.org/magnumripper/JohnTheRipper/jobs/81490986
> https://travis-ci.org/magnumripper/JohnTheRipper/jobs/81490987
>
> There are totally unrelated formats (eg. non-opencl pwsafe) that fail, and
> they only fail in your branch...

tests fails for formats which have "PBKDF2-SHA256" in []  after I
added sha256_plug.c and sha256.h and I think that lyra2-opencl is
another problem

>
> The bots also spell out some problems for you:
>
> opencl_yescrypt_fmt_plug.c:546:9: warning: comparison of constant
>       2251799813685247 with expression of type 'uint32_t' (aka 'unsigned
> int')
>       is always false [-Wtautological-constant-out-of-range-compare]
>                 if (p > SIZE_MAX / Sbytes) {
>                     ~ ^ ~~~~~~~~~~~~~~~~~
> 1 warning generated.
> yescrypt_fmt_plug.c:344:9: warning: comparison of constant 2251799813685247
> with
>       expression of type 'uint32_t' (aka 'unsigned int') is always false
>       [-Wtautological-constant-out-of-range-compare]
>                 if (p > SIZE_MAX / Sbytes) {
>                     ~ ^ ~~~~~~~~~~~~~~~~~
> 1 warning generated.
> In file included from yescrypt-best_plug.c:2:
> ./yescrypt-simd.c:1093:9: warning: comparison of constant 2251799813685247
> with
>       expression of type 'uint32_t' (aka 'unsigned int') is always false
>       [-Wtautological-constant-out-of-range-compare]
>                 if (p > SIZE_MAX / Sbytes) {
>                     ~ ^ ~~~~~~~~~~~~~~~~~
> 1 warning generated.

I was wondering whether remove these lines or not, I decided to not to
remove because these values can theoretically be changed.
these warnings are not generated on my laptop neither on super

Powered by blists - more mailing lists

Your e-mail address:

Powered by Openwall GNU/*/Linux - Powered by OpenVZ