Openwall GNU/*/Linux - a small security-enhanced Linux distro for servers
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date: Wed, 22 Apr 2015 14:24:36 +0300
From: Shinnok <admin@...nnok.com>
To: john-dev@...ts.openwall.com
Subject: [GSoC][Johnny] Translation task review

Mathieu,

I have new comments for your latest translation work on Github. Overall, I think your submission is quite good. After we polish the rough edges I'd like to merge it and move on to the next thing.

Aleksey,
I have a question in there for you too, can you see them or chip in otherwise? I can't seem to find out how I can invite you to a pull request discussion:
https://github.com/shinnok/johnny/pull/3

I'd also like confirmation that we all agree on following the coding style rules mentioned in the Roadmap, since confusion on this aspect will yield bad overall code aesthetics for a team of 3:
	• Follow the coding style outlined at http://doc.qt.digia.com/qtcreator-extending/coding-style.html <http://doc.qt.digia.com/qtcreator-extending/coding-style.html>
With one amendment, placing the opening curly brace on the next line for any case. That's what I used for the last couple years and I think fits well when doing C++ and Qt.

Johnny's code is still incipient enough that we can enforce a common style, so it would be good if we can do that early on.

Shinnok
[ CONTENT OF TYPE text/html SKIPPED ]

Powered by blists - more mailing lists

Your e-mail address:

Powered by Openwall GNU/*/Linux - Powered by OpenVZ