Openwall GNU/*/Linux - a small security-enhanced Linux distro for servers
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Mon, 23 Sep 2013 23:44:16 +0400
From: Solar Designer <solar@...nwall.com>
To: john-dev@...ts.openwall.com
Subject: Re: Rafael's weekly report #14

Rafael,

On Mon, Sep 23, 2013 at 11:32:31PM +0400, Solar Designer wrote:
> On Mon, Sep 23, 2013 at 01:00:41PM +0200, Rafael Waldo Delgado Doblas wrote:
> > 2013/9/21 Solar Designer <solar@...nwall.com>
> > > 5. You're still not using any macros in the .S file.  Do you have some
> > > non-committed version that does use macros (but is buggy, as you
> > > mentioned)?  Is the committed asm code supposed to be in a working
> > > state, then (but is just slow)?
> > 
> > Yes it is. As GSoC it's about to finish I commited a working version but I
> > have another one with macros but still buggy.
> 
> Where is this other version?  May I take a look?  You attached some
> version to this message (that I am replying to), but it does not use
> macros and it is unclear what you attached it for.

I took a closer look at this one.  You do mention macros in comments -
but you don't actually have any macros in there.  I find this puzzling.
You have several functions (and the associated function call/return
overhead).  It is unclear to me what the purpose of writing this code
is.  It does not appear to be a step towards the two versions I asked
you to produce: one with most extensive reasonable use of macros and the
other with larger macros and/or with lighter use of macros as required to
implement instruction scheduling.  This version is neither, and like I
said it doesn't look like a step towards either.  So, even if it worked
correctly, its purpose is unclear.

Perhaps there's some misunderstanding between us on this task.

Can you please take another look at Katja's parallella_e_bcrypt.S?  You
may also take a look at some .S files in the core JtR tree, such as
alpha.S.  Katja's parallella_e_bcrypt.S uses a mix of assembler macros
(for pieces of code) and cpp macros (for giving descriptive names to
registers).  alpha.S uses cpp macros only (for both purposes).  You can
use either approach.

Alexander

Powered by blists - more mailing lists

Your e-mail address:

Powered by Openwall GNU/*/Linux - Powered by OpenVZ