john-dev - Re: Daniel's reports #13, #14

Openwall GNU/*/Linux - a small security-enhanced Linux distro for servers

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 23 Sep 2013 10:31:02 +0200
From: magnum <john.magnum@...hmail.com>
To: john-dev@...ts.openwall.com
Subject: Re: Daniel's reports #13, #14

On 23 sep 2013, at 04:07, Dániel Bali <balijanosdaniel@...il.com> wrote:
> I changed the binary_hash and get_hash functions to fmt_default_binary_hash and fmt_default_get_hash, but I still have an error when cmp_exact is called. It tries to compare 0xaaaaaaaa to 0x00000000, so the indexes are not correct. Unfortunately I don't have much experience with writing formats for john and it goes slow.
> 
> Here is the code in its current state:
> https://gist.github.com/balidani/74908e41ee3749742705

You seem to have "partial hashes" with a size of 32 bits so they are not partial. You should not need res_hashes and cmp_exact should just return 1:

cmp_exact()
{
	return 1;
}

...because cmp_one() actually made a full compare.

magnum