[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Mon, 06 Aug 2012 00:32:30 +0200
From: magnum <john.magnum@...hmail.com>
To: john-dev@...ts.openwall.com
Subject: Re: Use of clear_keys() for SIMD buffer clearing (was:
Re: opencl_mscash2_fmt.c: clear_keys())
On 2012-08-05 18:35, jfoug@....net wrote:
>> On 2012-07-12 17:28, jfoug wrote:
>>> Actually, some of the 'fat' SSE formats should use clear_keys().
>>> The logic I was using to reset the keyspace on dynamic was
>>> mimicked from other formats. Within set_key, if index is 0, they
>>> memset buffers. This logic should be put into clear_keys().
>>
>> I just tried this in hmacMD5 and mssql-old and it does not work. I
>> see clear_keys is not called before first batch of keys (maybe we
>> should change that?) so I copied the hmac memsets to init() too but
>> this did not fix it. It appears clear_keys() is not called when I
>> expected it - perhaps a self-test only problem? Or is it not
>> supposed to be called any time one set of keys are done with (and
>> only then)?
>
> This is a self test problem. I thought I submitted a patch for
> this, but it may have been rolled back.
>
The cracker code seems fine, and the benchmark one too. The enclosed
patch seems to fix all problems I had with self-tests.
magnum
View attachment "self-test-clear_keys.diff" of type "text/x-patch" (810 bytes)
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
