Openwall GNU/*/Linux - a small security-enhanced Linux distro for servers
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date: Sun, 27 May 2012 22:53:45 -0700 (PDT)
From: deepika dutta <deepikadutta_19@...oo.com>
To: "john-dev@...ts.openwall.com" <john-dev@...ts.openwall.com>
Subject: mschap-v2 conversion

>OK, that seems to work. But as long as it breaks the normal builds, I can't commit it. Could you try to get it work for at least linux-x86-sse2?


yaa I have to do it and I want to take it up. Since I am new to SSE programming, I don't exactly know how to work with it but I will try (ofcourse with your help :) ) 


>Speeds before:
>Benchmarking: MSCHAPv2 C/R MD4 DES [mschapv2]... DONE
>Many salts:    2304K c/s real, 2317K c/s virtual
>Only one salt:    1638K c/s real, 1638K c/s virtual

>After:
>Benchmarking: MSCHAPv2 C/R MD4 DES [mschapv2]... DONE
>Many salts:    4861K c/s real, 4861K c/s virtual
>Only one salt:    2466K c/s real, 2466K c/s virtual

good, the changes seems to work  :)

>I think you should change ALGORITHM_NAME to reflect that we are using BS. Maybe you could just use DES_BS_ALGORITHM_NAME?


Ok I will do it.


>BTW, I get these warnings:
>MSCHAPv2_fmt_plug.c: In function ‘generate_output’:
>MSCHAPv2_fmt_plug.c:269:10: warning: pointer targets in assignment differ in signedness [-Wpointer-sign]
>MSCHAPv2_fmt_plug.c: In function ‘mschapv2_set_salt’:
>MSCHAPv2_fmt_plug.c:425:15: warning: unused variable ‘temp’ [-Wunused-variable]


They are due to signed variables and unused temp variable in the code, i will handle them.

>A more serious problem is that you break OMP builds even for generic:


yaa I actually didn't do it.  Just wanted to make everything work for simplest case but I will do it now.


Cheers,
Deepika
Content of type "text/html" skipped

Powered by blists - more mailing lists

Your e-mail address:

Powered by Openwall GNU/*/Linux - Powered by OpenVZ