From 14499348b966cd7b3d72afee15a5cd51cdd0a727 Mon Sep 17 00:00:00 2001 From: Werner Koch Date: Sat, 14 Nov 2026 13:43:00 +0100 Subject: [PATCH] Fix a double free in the status line read code. * src/engine-gpg.c (read_status): Immediately assign the realloced buffer to the context and not just at the end. (read_colon_line): Ditto. -- This fixes a 24 years old bug introduced with Fixes-commit: f12433c1e476f52c92496a885c1ffcd10fa2a322 GnuPG-bug-id: T8557 Reported-by: Johan Carlsson (https://hackerone.com/joaxcar?type=user) --- src/engine-gpg.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/engine-gpg.c b/src/engine-gpg.c index eea97bc7..66e567b0 100644 --- a/src/engine-gpg.c +++ b/src/engine-gpg.c @@ -1494,7 +1494,9 @@ read_status (engine_gpg_t gpg) buffer = realloc (buffer, bufsize); if (!buffer) return gpg_error_from_syserror (); - } + gpg->status.bufsize = bufsize; + gpg->status.buffer = buffer; + } nread = _gpgme_io_read (gpg->status.fd[0], buffer + readpos, bufsize-readpos); @@ -1606,8 +1608,6 @@ read_status (engine_gpg_t gpg) } /* Update the gpg object. */ - gpg->status.bufsize = bufsize; - gpg->status.buffer = buffer; gpg->status.readpos = readpos; return 0; } @@ -1647,6 +1647,8 @@ read_colon_line (engine_gpg_t gpg) buffer = realloc (buffer, bufsize); if (!buffer) return gpg_error_from_syserror (); + gpg->colon.bufsize = bufsize; + gpg->colon.buffer = buffer; } nread = _gpgme_io_read (gpg->colon.fd[0], buffer+readpos, bufsize-readpos); @@ -1726,8 +1728,6 @@ read_colon_line (engine_gpg_t gpg) } /* Update the gpg object. */ - gpg->colon.bufsize = bufsize; - gpg->colon.buffer = buffer; gpg->colon.readpos = readpos; return 0; } -- 2.47.3