Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <78f2c0e6-f6d3-f9a7-61e7-56ac46974303@mirbsd.de>
Date: Fri, 14 Nov 2025 00:09:51 +0100 (CET)
From: Thorsten Glaser <tg@...bsd.de>
To: musl@...ts.openwall.com
cc: Bill Roberts <bill.roberts@....com>
Subject: Re: [PATCH 1/3] dso/aarch64: add PROT_BTI support for mem
 maps

On Thu, 13 Nov 2025, Bill Roberts wrote:

>--- a/ldso/dynlink.c
>+++ b/ldso/dynlink.c
>@@ -693,7 +708,7 @@ static void *map_library(int fd, struct dso *dso)
> 	off_t off_start;
> 	Ehdr *eh;
> 	Phdr *ph, *ph0;
>-	unsigned prot;
>+	unsigned prot, arch_prot, arch_mask;

You might want to zero-initialise these, as you changed
the = to |= below. (Unless there’s already an explicit
=0 in the part that’s not shown, I didn’t check.)

> 	unsigned char *map=MAP_FAILED, *base;
> 	size_t dyn=0;
> 	size_t tls_image=0;

bye,
//mirabilos
-- 
15:41⎜<Lo-lan-do:#fusionforge> Somebody write a testsuite for helloworld :-)

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.