Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date: Tue, 31 Dec 2002 18:07:26 +0100
From: Tim van Erven <tve@...mig.net>
To: Popa3d Users <popa3d-users@...ts.openwall.com>
Subject: '.' and '/' in usernames

Popa3d rejects usernames with dots ('.') in them and I believe it also
rejects usernames containing any slashes ('/'), though I haven't tested
the latter.

AFAICT, rfc 1939 allows usernames consisting of any printable ASCII
characters (and being no longer than 40 characters). Surely '.' and '/'
are printable characters.

Fixing this might not be worth the additional complexity and room for
errors, but perhaps a note in the DESIGN file is in order?

For your reference from virtual.c:

static int is_valid_user(char *user)
{
        unsigned char *p;

/* This is pretty liberal, but we're going to use direct syscalls only,
 * and they have to accept all the printable characters */
        for (p = (unsigned char *)user; *p; p++)
                if (*p < ' ' || *p > 0x7E || *p == '.' || *p == '/') return 0;

        if (p - (unsigned char *)user > NAME_MAX) return 0;

        return 1;
}

-- 
Tim van Erven <tve@...mig.net>
OpenPGP Key ID: 712CB811        Fingerprint: F6C9 61EE 242C C012 36D5
WWW: http://www.science.uva.nl/~talerven/    BBF8 6310 D557 712C B811

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.