Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sat, 10 Jan 2015 23:49:19 +0300
From: "Dmitry V. Levin" <ldv@...linux.org>
To: owl-dev@...ts.openwall.com
Subject: Re: Re: [owl-cvs] Owl/packages/strace

Hi,

On Fri, Oct 10, 2014 at 11:30:13AM +0400, (GalaxyMaster) wrote:
> Dmitry,
> 
> Have you tried to build that updated version against our current kernel
> headers?  I am asking since I'm getting the following compilation error:
> ===
> gcc -DHAVE_CONFIG_H -I.  -I./linux/x86_64 -I./linux -I./linux  -Wall -Wwrite-strings -pipe -O2 -fomit-frame-pointer -MT strace-fanotify.o -MD -MP -MF .deps/strace-fanotify.Tpo -c -o strace-fanotify.o `test -f 'fanotify.c' || echo './'`fanot
> ify.c
> In file included from fanotify.c:2:0:
> ./linux/fanotify.h:89:2: error: unknown type name '__aligned_u64'
> make[3]: *** [strace-fanotify.o] Error 1
> ===
> 
> AFAICT, __aligned_u64 was introduced in 2.6.36 by the following commit:
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=79b5dc0c64d88cda3da23b2e22a5cec0964372ac
> ===
> commit 79b5dc0c64d88cda3da23b2e22a5cec0964372ac
> Author: Eric Paris <eparis@...hat.com>
> Date:   Fri Oct 15 14:34:14 2010 -0700
> 
>     types.h: define __aligned_u64 and expose to userspace
>     
>     We currently have a kernel internal type called aligned_u64 which aligns
>     __u64's on 8 bytes boundaries even on systems which would normally align
>     them on 4 byte boundaries.  This patch creates a new type __aligned_u64
>     which does the same thing but which is exposed to userspace rather than
>     being kernel internal.
>     
>     [akpm: merge early as both the net and audit trees want this]
> ===
> 
> and I think it was not backported to the 2.6.18 branch we are currently using.
> 
> Therefore, my question is how should we fix this if there is an issue?  For
> example, we can just apply that patch since it's a very trivial patch to our
> kernel package (this way strace will build on both old and new kernels).

Just for the record, there is a patch that should fix this issue as well:
http://sourceforge.net/p/strace/code/ci/75d62047ad2abf5c2509567aeb9c241c04acbfe6

I haven't tested it on 2.6.18-ish kernel headers, though.


-- 
ldv

Content of type "application/pgp-signature" skipped

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.