Openwall GNU/*/Linux - a small security-enhanced Linux distro for servers
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Mon, 14 Jul 2014 16:11:35 +0400
From: Vasily Kulikov <segoon@...nwall.com>
To: owl-dev@...ts.openwall.com
Subject: Re: ping sockets

Solar,

On Thu, Jul 10, 2014 at 15:48 +0400, Solar Designer wrote:
> Vasily,
> 
> I've just dropped the following lines from ping_v4_unhash() since they
> had no effect:
> 
> 	struct ve_struct *env = sk->owner_env;
> [...]
> 		struct hlist_head *hslot;
> 
> 		hslot = ping_hashslot(&ping_table, env, isk->num);
> 
> Were these lines included on error, or were they meant to have effect
> (but then you forgot to write more code to make use of them)?

AFAICS, the former.  The code was initially supposed to remove the sk
from a 'hslot' list manually in some way, but it was changed to use
sk_del_node_init() instead.  The first version I've posted already
contains sk_del_node_init().  So indeed this is a useless code.

Btw, it looks like sk_del_node_init() can be replaced with
sk_del_node() which is a bit faster.

Thanks,

-- 
Vasily Kulikov
http://www.openwall.com - bringing security into open computing environments

Powered by blists - more mailing lists

Your e-mail address:

Powered by Openwall GNU/*/Linux - Powered by OpenVZ