Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 1 Jun 2018 02:30:50 +0200
From: Szabolcs Nagy <nsz@...t70.net>
To: musl@...ts.openwall.com
Subject: Re: Re: [PATCH] scanf: handle the L modifier for integers

* Rich Felker <dalias@...c.org> [2018-05-31 19:44:36 -0400]:
> On Thu, May 31, 2018 at 10:44:42PM +0200, Natanael Copa wrote:
> > Also many developers seems to think that
> > Linux == glibc so they only read the GNU manuals, so yeah, implement
> > glibc behavior here seems like a good idea, unless someone else has a
> > brilliant idea how to catch this at compile time.
> 
> Aside from fixing gcc at compile time, this has come up before (with
> regard to printf, not scanf), and my leaning then and now was to
> detect the UB at runtime by crashing rather than reporting an error as
> we do now, since (1) it's UB, so an application can't reasonably
> expect an error, and (2) applications seem to be ignoring errors
> anyway.
> 
> We should also get the man page fixed. The printf man page is clear
> that L with integer specifiers is a nonstandard extension and should
> not be used (they're not documented under L, only as a note at the
> end) but it seems whoever fixed this overlooked changing scanf at the
> same time.
> 

also note that adding extensions to printf this way can break
forward compatibility, because the standard can introduce %Ld
with a different meaning, this happend before: in glibc scanf
%a was used for 'allocation modifier' then later iso c introduced
it for hex floats, now scanf behaves differently based on CFLAGS
(standard conform mode uses different scanf), this involves hacks
in glibc which nobody wants to repeat so nowadays new extensions
are only added once they are expected to be standardized.

(if musl aimed for full glibc compatibility then it would have
to copy the messy %a behaviour too, fortunately that's not in
widespread use just like the %Ld extension..)

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.