Openwall GNU/*/Linux - a small security-enhanced Linux distro for servers
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 9 Jan 2018 19:58:51 +0100
From: Jens Gustedt <jens.gustedt@...ia.fr>
To: musl@...ts.openwall.com
Subject: Re: [PATCH 5/7] use the new lock algorithm for malloc

Hello Rich,

On Tue, 9 Jan 2018 12:42:34 -0500 Rich Felker <dalias@...c.org> wrote:

> On Wed, Jan 03, 2018 at 02:17:12PM +0100, Jens Gustedt wrote:
> > Malloc used a specialized lock implementation in many places. Now
> > that we have a generic lock that has the desired properties, we
> > should just use this, instead of this multitude of very similar
> > lock mechanisms. ---
> >  src/malloc/malloc.c | 38 +++++++++++++-------------------------
> >  1 file changed, 13 insertions(+), 25 deletions(-)
> > 
> > diff --git a/src/malloc/malloc.c b/src/malloc/malloc.c
> > index 9e05e1d6..6c667a5a 100644
> > --- a/src/malloc/malloc.c
> > +++ b/src/malloc/malloc.c
> > @@ -13,6 +13,8 @@
> >  #define inline inline __attribute__((always_inline))
> >  #endif
> >  
> > +#include "__lock.h"
> > +  
> 
> Ah, I see -- maybe you deemed malloc to be the only place where
> inlining for the sake of speed made sense? That's probably true.

Yes, and also I was trying to be conservative. Previously, the lock
functions for malloc resided in the same TU, so they were probably
inlined most of the time.

Jens

-- 
:: INRIA Nancy Grand Est ::: Camus ::::::: ICube/ICPS :::
:: ::::::::::::::: office Strasbourg : +33 368854536   ::
:: :::::::::::::::::::::: gsm France : +33 651400183   ::
:: ::::::::::::::: gsm international : +49 15737185122 ::
:: http://icube-icps.unistra.fr/index.php/Jens_Gustedt ::

Content of type "application/pgp-signature" skipped

Powered by blists - more mailing lists

Your e-mail address:

Powered by Openwall GNU/*/Linux - Powered by OpenVZ