Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 28 Sep 2017 12:56:24 -0400
From: Rich Felker <dalias@...c.org>
To: musl@...ts.openwall.com
Subject: Re: [PATCH] fix missing forward declaration of memset in
 sched.h

On Thu, Sep 28, 2017 at 02:44:51PM +0200, Jörg Krause wrote:
> Hi,
> 
> On Fri, 2017-09-08 at 11:39 +0200, Jörg Krause wrote:
> > Fixes build issue when using the macro `CPU_EQUAL()`, e.g. in Boost [1]:
> > 
> > ```
> > libs/fiber/src/numa/linux/pin_thread.cpp:31:5: error: 'memset' was not declared in this scope
> >      CPU_ZERO( & set);
> >      ^
> > ```
> > 
> > [1] https://github.com/boostorg/fiber/pull/142
> > 
> > Reported-by: Oliver Kowalke <oliver.kowalke@...il.com>
> > Signed-off-by: Jörg Krause <joerg.krause@...edded.rocks>
> > ---
> >  include/sched.h | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/include/sched.h b/include/sched.h
> > index d1cccb70..05d40b1e 100644
> > --- a/include/sched.h
> > +++ b/include/sched.h
> > @@ -72,6 +72,7 @@ int setns(int, int);
> >  
> >  void *memcpy(void *__restrict, const void *__restrict, size_t);
> >  int memcmp(const void *, const void *, size_t);
> > +void *memset (void *, int, size_t);
> >  void *calloc(size_t, size_t);
> >  void free(void *);
> >  
> 
> Any feedback on this?

It looks fine. Thanks and sorry for not replying sooner.

Rich

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.