Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 08 Sep 2017 11:26:38 +0200
From: Jörg Krause <joerg.krause@...edded.rocks>
To: musl@...ts.openwall.com
Subject: Re: Missing include of <string.h> in sched.h?

On Fri, 2017-09-08 at 09:46 +0200, Jörg Krause wrote:
> Hi,
> 
> latest Boost 1.65.1 fails to compile with a musl toolchain [1].
> 
> The issue is that Boost uses the `CPU_ZERO` macro which expands to
> `memset()` [2].
> 
> The Linux Programmer's Manual state that memset() is defined in
> string.h [3].
> 
> Therefore, shouldn't shed.h include string.h?
> 
> [1] https://github.com/boostorg/fiber/pull/142
> [2] https://git.musl-libc.org/cgit/musl/tree/include/sched.h#n110
> [3] http://man7.org/linux/man-pages/man3/memset.3.html

On second thought, the forward declaration for memset() is missing [4].
Note, that there is a forward declaration for memcpy(), but it is never
used in sched.h.

[4] https://github.com/boostorg/fiber/pull/142#issuecomment-328043778

Best regards,
Jörg Krause

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.