Openwall GNU/*/Linux - a small security-enhanced Linux distro for servers
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 14 Jul 2017 16:02:11 +0200
From: Szabolcs Nagy <nsz@...t70.net>
To: musl@...ts.openwall.com
Cc: Jukka Jylänki <jujjyl@...il.com>
Subject: Re: Typo in include/pthreads.h

* Jukka Jylänki <jujjyl@...il.com> [2017-07-14 16:39:52 +0300]:
> a contributor to Emscripten noticed that in include/pthreads.h, there

you mean c11 include/threads.h, not posix pthread.h

> are two lines
> 
> #define __NEED_cnd_t
> #define __NEED_mtx_t
> 
> that look like they should be
> 
> #define __NEED_pthread_cond_t
> #define __NEED_pthread_mutex_t
> 

no, the code in musl is correct.
pthread_ types would violate c11 namespace rules here.

> The first two names appear nowhere else in the musl repository. The
> effect of this is that including <threads.h> as the first include
> directive (or in practice, before other threading related headers)
> fails to parse. See https://github.com/kripken/emscripten/pull/5363

does not fail for me: mtx_t is defined for all supported targets
in bits/alltypes.h.in as far as i can see

Powered by blists - more mailing lists

Your e-mail address:

Powered by Openwall GNU/*/Linux - Powered by OpenVZ