[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Fri, 16 Dec 2016 23:12:26 -0500
From: Rich Felker <dalias@...c.org>
To: musl@...ts.openwall.com
Subject: Re: [PATCH] features.h: define __inline to empty for pre-c99
non-gcc compilers
On Mon, Dec 12, 2016 at 09:01:26PM +0100, Quentin Rameau wrote:
> ---
>
> After what we have discussed on IRC, I'm posting this one here so you
> have it at hand!
>
> ---
> include/features.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/features.h b/include/features.h
> index 3cc3e57..f4d651e 100644
> --- a/include/features.h
> +++ b/include/features.h
> @@ -24,6 +24,8 @@
>
> #if __STDC_VERSION__ >= 199901L || defined(__cplusplus)
> #define __inline inline
> +#elif !defined(__GNUC__)
> +#define __inline
> #endif
>
> #if __STDC_VERSION__ >= 201112L
> --
> 2.10.2
Thanks. The patch is fine, but the commit message should describe the
purpose/effect rather than paraphrasing the content of the patch in
English. I'll change it to:
"in public headers, don't assume pre-C99 compilers have __inline keyword"
Rich
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
