Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date: Fri, 24 Jun 2016 17:18:23 -0700
From: "Zhao, Weiming" <weimingz@...eaurora.org>
To: musl@...ts.openwall.com
Subject: Fix warnings when build with clang

Clang gives warnings about the missing parentheses for bitwise ops.

It's not functional but just code readability.

musl-m3/include/endian.h:32:25: warning: '&' within '|' 
[-Wbitwise-op-parentheses]
         return __x>>24 | __x>>8&0xff00 | __x<<8&0xff0000 | __x<<24;
                        ~ ~~~~~~^~~~~~~


musl-m3/include/endian.h:37:23: warning: operator '<<' has lower 
precedence than '+'; '+' will be evaluated first [-Wshift-op-parentheses]
         return __bswap32(__x)+0ULL<<32 | __bswap32(__x>>32);
                ~~~~~~~~~~~~~~^~~~~~~


Thanks,
Weiming

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation


View attachment "musl.patch" of type "text/plain" (589 bytes)

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.