Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 14 Apr 2016 15:42:13 +0200
From: Szabolcs Nagy <nsz@...t70.net>
To: musl@...ts.openwall.com
Subject: Re: [PATCH v2] add powerpc64 port

* Bobby Bingham <koorogi@...rogi.info> [2016-04-14 03:01:38 -0500]:
> On Thu, Apr 14, 2016 at 01:05:07AM +0200, Szabolcs Nagy wrote:
> > * Bobby Bingham <koorogi@...rogi.info> [2016-04-04 00:26:11 -0500]:
> > > +++ b/arch/powerpc64/bits/setjmp.h
> > > @@ -0,0 +1 @@
> > > +typedef unsigned long long __jmp_buf[66];
> > 
> > hm glibc seems to use long[64] with 16byte alignment,
> > is the size diff because of alignment?
> 
> Yes.  Though apparently the glibc setjmp asm has code to detect a
> misaligned jmp_buf, but its handling of that case ends up overflowing
> the jmp_buf.
> 
> I can make some changes to get our jmp_buf down to 65, but the only ways
> to get it down to 64 are either with 16 byte alignment, or to have setjmp
> spill vector registers to the stack first so it can copy them from there
> to the jmp_buf through a gpr.
> 
> How important is it to match glibc here?
> 

i think we don't care about abi compat
(but it might be interesting to check how much abi
difference there is between glibc and musl, i can
do this if i can build a musl+glibc toolchain)

i just wanted to make sure we understand the
cause of the difference.

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.