Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 21 Apr 2015 01:00:10 +0300 (MSK)
From: Alexander Monakov <amonakov@...ras.ru>
To: musl@...ts.openwall.com
Subject: Re: x86_64 and x32 fail to build

Building x32 with --enable-warnings uncovers one leftover unused variable:

diff --git a/arch/x32/syscall_arch.h b/arch/x32/syscall_arch.h
index af67fe3..a3abcf5 100644
--- a/arch/x32/syscall_arch.h
+++ b/arch/x32/syscall_arch.h
@@ -45,7 +45,6 @@ static __inline long __syscall1(long long n, long long a1)
 static __inline long __syscall2(long long n, long long a1, long long a2)
 {
        unsigned long ret;
-       struct __timespec *ts2 = 0;
        switch (n) {
                __fixup_case_2;
        }


When building without --enable-warnings, there are many false positives from
-Wpointer-to-int-cast about x32 __scc(); at least from 4.5 onwards GCC enables
this warning by default, so perhaps if musl really wants to silence it, it
should test the corresponding -Wno-... flag outside of x$warnings == xyes
test?

Thanks.
Alexander

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.