[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 02 Dec 2014 20:23:18 +0100
From: Jens Gustedt <jens.gustedt@...ia.fr>
To: musl@...ts.openwall.com
Subject: Re: [PATCH 4/4] fix a minor bug for the definition of
WINT_MIN
Am Dienstag, den 02.12.2014, 13:06 -0500 schrieb Rich Felker:
> On Tue, Nov 25, 2014 at 03:50:17PM +0100, Jens Gustedt wrote:
> > This must be an unsigned value.
> > ---
> > include/stdint.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/stdint.h b/include/stdint.h
> > index 8b91163..8b81ca0 100644
> > --- a/include/stdint.h
> > +++ b/include/stdint.h
> > @@ -78,7 +78,7 @@ typedef uint64_t uint_least64_t;
> > #define INTMAX_MAX INT64_MAX
> > #define UINTMAX_MAX UINT64_MAX
> >
> > -#define WINT_MIN 0
> > +#define WINT_MIN (+_UINTEGER_C(uint32_t, 0))
> > #define WINT_MAX UINT32_MAX
>
> Indeed, but 0U would be a much nicer way of writing it.
But this would be wrong on platforms with 16 bit int, no?
> Also I'm wondering why I have wint_t in the arch-specific
> alltypes.h.in files if stdint.h is assuming the type is
> unsigned/32-bit, and it actually is for all archs. Perhaps we should
> move it into the shared part of alltypes.h.in?
don't we have archs with 16 bit int?
but right, even then we could move it up and define it as uint32_t
Jens
--
:: INRIA Nancy Grand Est ::: AlGorille ::: ICube/ICPS :::
:: ::::::::::::::: office Strasbourg : +33 368854536 ::
:: :::::::::::::::::::::: gsm France : +33 651400183 ::
:: ::::::::::::::: gsm international : +49 15737185122 ::
:: http://icube-icps.unistra.fr/index.php/Jens_Gustedt ::
Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
