Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 29 Aug 2014 20:44:09 +0200
From: Felix Janda <felix.janda@...teo.de>
To: musl@...ts.openwall.com
Subject: Re: Add login_tty

Felix Janda wrote:
> Rich Felker wrote:
> [..]
> > I don't have any fundamental objection to this. It might be nice to
> > review the forkpty code for errors it should be checking and make
> > these improvements at the same time, though.
> 
> Ok, attached a proposed patch.

Any comments?

login_tty() fails if and only if the ioctl fails. This is what I have
read in online man pages of other implementations.

It might be desirable to make forkpty() fail when login_tty() fails
in the child.

Felix

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.