[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 09 Jul 2013 19:29:12 -0700
From: Nathan McSween <nwmcsween@...il.com>
To: musl@...ts.openwall.com
Subject: Re: endian.h warnings
On Tuesday, July 09, 2013 7:21:58 PM, Andre Renaud wrote:
> Hi,
> When using musl with -Wparentheses enabled, I get the following warnings:
> ../include/endian.h: In function '__bswap32':
> ../include/endian.h:32:2: warning: suggest parentheses around
> arithmetic in operand of '|' [-Wparentheses]
> ../include/endian.h:32:2: warning: suggest parentheses around
> arithmetic in operand of '|' [-Wparentheses]
> ../include/endian.h: In function '__bswap64':
> ../include/endian.h:37:2: warning: suggest parentheses around '+'
> inside '<<' [-Wparentheses]
>
> I appreciate that these aren't bugs, and are just gcc being over
> enthusiastic in it's warnings (which I've asked it to be on the
> command line), however would it be worth sticking some parentheses
> into the code simply to avoid this kind of noise being visible for
> users?
>
> Regards,
> Andres
Try with -Wall -Wextra -Wpedantic. GCC will spam warnings for nearly
anything, struct padding warnings are extremely annoying. Somewhat
(maybe?) concerning warnings are signed / unsigned comparisons in math/*
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
