Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 27 May 2013 23:05:37 +0900
From: plan9assembler <plan9assembler@...il.com>
To: musl@...ts.openwall.com
Subject: Re: util-linux-2.23 mount segmentation fault error

util-linux-2.23 mount segfault error seems to be solved.
no more segfault error, when i test mount binary.

i modified follow macros in musl /include/bits/ioctl.h and musl libc
reinstalled.

- #define _IOR(a,b,c) _IOC(2,(a),(b),sizeof(c))
- #define _IOWR(a,b,c) _IOC(3,(a),(b),sizeof(c))

+ #define _IOR(a,b,c) _IOC(2U,(a),(b),sizeof(c))
+ #define _IOWR(a,b,c) _IOC(3U,(a),(b),sizeof(c))

other points just removed some warings.
ex)
 , ino);  to  , (uintmax_t) ino); // etc

build log attached.

TIA



On Sun, May 26, 2013 at 8:22 PM, plan9assembler <plan9assembler@...il.com>wrote:

> 1,2 was fixed, but still gets segfault. 2 trivial, cmp(t,x,y) to
> cmp(x,y,t), (thunk,a,b) to (a,b,thunk) etc.
> 1. _IOR macro for ioctl should use 2U<<30 instead of 2<<30
> 2. your qsort_r seem to have the wrong prototype
>
> 3 is fine by me.
> 3. settimeofday should follow the bsd declaration
>
> other points need to be checked, i will look at these.
> TIA
>
>
> On Sun, May 26, 2013 at 6:14 PM, Szabolcs Nagy <nsz@...t70.net> wrote:
>
>> * plan9assembler <plan9assembler@...il.com> [2013-05-26 06:34:12 +0900]:
>> > Hi, i attached build log, and
>>
>> there were some minor musl issues:
>> _IOR macro for ioctl should use 2U<<30 instead of 2<<30
>> settimeofday should follow the bsd declaration
>> x86_64 posix types should be long instead of long long
>>
>> (glibc is not entirely consistent on x86_64:
>> the types in user.h use long long)
>>
>> (i can prepare patches for these)
>>
>> your qsort_r seem to have the wrong prototype
>> (does not match cmp_t)
>>
>> there are some other problems as well, i'm not sure
>> which one trips mount, maybe you should recompile
>> musl and util-linux with -O0 -g3 and get a backtrace
>> from the crash
>>
>
>

Content of type "text/html" skipped

Download attachment "build.log" of type "application/octet-stream" (15923 bytes)

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.