Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 08 Feb 2013 20:53:51 +0100
From: Jens Gustedt <jens.gustedt@...ia.fr>
To: musl@...ts.openwall.com
Subject: Re: guard bug for strerror_r

Hello

Am Freitag, den 08.02.2013, 13:59 -0500 schrieb Rich Felker:
> > #if defined(__GLIBC__) && defined(__USE_GNU)

the __GLIBC__ thing seems to work for my case, now. strerror_r seems
to be the only interface where they use the same name with a different
interface, so I'll bug something around that.

> I would simply avoid _ever_ using strerror_r on GNU systems. On any
> modern GNU or POSIX 2008 conforming system, you have the vastly
> superior strerror_l function. It does not require you to provide a
> buffer, and it's thread-safe (the buffer returned is either immutable
> static or thread-local). The logic I'd recommend is:
> 
> #if _POSIX_VERSION >= 200809L || defined(__GLIBC__)
> /* use strerror_l */
> #else
> /* use strerror_r and assume POSIX version of it */
> #endif

Hm, I have a relatively recent system (ubuntu) and there is no trace
of strerror_l in the documentation, even in their "POSIX" man page.

And I actually use this in P99 to provide the C11 Annex K interface
strerror_s, which is much closer to strerror_r than strerror_l. Well,
we now have

strerror    C, POSIX
strerror_r  POSIX
strerror_l  POSIX
strerror_s  C

superbe. Again a case where a liaison between the C committee and the
POSIX could have helped.

Jens


-- 
:: INRIA Nancy Grand Est :: http://www.loria.fr/~gustedt/   ::
:: AlGorille ::::::::::::::: office Nancy : +33 383593090   ::
:: ICube :::::::::::::: office Strasbourg : +33 368854536   ::
:: ::::::::::::::::::::::::::: gsm France : +33 651400183   ::
:: :::::::::::::::::::: gsm international : +49 15737185122 ::



Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.