Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sat, 20 Oct 2012 19:49:48 -0400
From: Rich Felker <dalias@...ifal.cx>
To: musl@...ts.openwall.com
Subject: Re: [PATCH 1/4] Build system: give ability to install
 lib/crt*.o files separately

On Sat, Oct 20, 2012 at 10:15:42PM +0200, Abdoulaye Walsimou Gaye wrote:
> This will allow toolchain build systems using 3-stages gcc build
> to not fail at second stage (which needs lib/crt*.o file).

Could you explain what you mean? If a gcc for the target exists at
this stage, then it should be possible to build the entire libc. If it
doesn't exist, then the Makefile will not work to build the start
files, even though it would be possible to build them by invoking the
assembler directly.

I'm not opposed to this patch but I'd like to understand how it helps.

> Signed-off-by: Abdoulaye Walsimou Gaye <awg@...toolkit.org>
> ---
>  Makefile |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Makefile b/Makefile
> index 3c55c8f..ee9f14d 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -139,6 +139,7 @@ install-headers: $(ALL_INCLUDES:include/%=$(DESTDIR)$(includedir)/%)
>  
>  install-tools: $(ALL_TOOLS:tools/%=$(DESTDIR)$(bindir)/%)
>  
> +install-startfiles: $(CRT_LIBS:lib/%=$(DESTDIR)$(libdir)/%)

If this patch is adopted, this target should be added to .PHONY and I
think the duplicate rule under install-libs should be replaced with a
dependency on install-startfiles, no?

Rich

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.