[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 6 Jun 2011 20:31:15 +0200
From: Szabolcs Nagy <nsz@...t70.net>
To: musl@...ts.openwall.com
Subject: Re: Cleanup patches
* Rich Felker <dalias@...ifal.cx> [2011-06-06 13:32:10 -0400]:
> On Mon, Jun 06, 2011 at 07:13:18PM +0200, Szabolcs Nagy wrote:
> > %.o: $(ARCH)/%.s
> > - $(CC) $(CFLAGS) $(INC) -c -o $@ $<
> > + $(CC) -c -o $@ $<
> >
> > this could be $(AS) -o $@ $<
>
> Is there a reason this is necessary or beneficial?
>
the c compiler may use different asm syntax than you do?
so $(AS) can be something that knows your .s syntax
> > and wcsspn arguments must be const qualified
>
> This is wrong. A non-const-qualified pointer always implicitly
> converts to the const-qualified version.
>
true
> > Subject: [PATCH 6/6] You can't weak alias a static function or variable
> >
> > you can, at least gcc/ld allows it, it just does not make much sense
>
> It does make sense to allow it, but I can see how it might be a little
> more work for the compiler and the compiler might not want to support
> it.
>
what's the difference between
static int f() { stuff(); }
int g() __attribute__((weak, alias("f")));
and
int g() { stuff(); }
?
in the later case local f calls must be replaced by g calls
but other than that is there a difference?
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
