[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date: Mon, 6 Jun 2011 10:48:08 +0200
From: Igmar Palsenberg <musl@...senberg.com>
To: musl@...ts.openwall.com
Subject: Musl git 0d......455eee8 and recent compilers
Hi,
I was using Musle as a test for investigating a (completely unrelated) clang-analyser problem, and I've stumbled upon a couple of issues
1) The struct dirent in include/dirent.h uses a 1 byte array for d_name. In reality, it's larger : We allocate more space than the struct. Since muscle requires a C99 compiler anyway, what's keeping use from using d_name[0] or d_name[] ? If a C89 compiler includes dirent.h, we're screwed anyway :). That will probably silence GCC 4.5 and clang, and severely reduce the warnings it gives in similar cases.
2) The NULL pointer dereference in src/time/__asctime.c won't work with clang : It removes it. I suggest using either __builtin_trap() or an abort(). If you get to that point, you're in trouble anyway.
3) Clang does't seem to grasp the weak_alias thingy. It need to check if those parts actually are correct
4) Is there a muscl testsuite somewhere ?
regards,
Igmar
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
