[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 25 Jun 2018 16:53:11 -0700
From: Thomas Garnier <thgarnie@...gle.com>
To: Randy Dunlap <rdunlap@...radead.org>
Cc: Kernel Hardening <kernel-hardening@...ts.openwall.com>,
Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>, "H . Peter Anvin" <hpa@...or.com>,
"the arch/x86 maintainers" <x86@...nel.org>, Josh Poimboeuf <jpoimboe@...hat.com>,
Philippe Ombredanne <pombredanne@...b.com>, Kate Stewart <kstewart@...uxfoundation.org>,
Greg KH <gregkh@...uxfoundation.org>,
Francis Deslauriers <francis.deslauriers@...icios.com>, "H . J . Lu" <hjl.tools@...il.com>,
LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v5 23/27] x86/modules: Adapt module loading for PIE support
On Mon, Jun 25, 2018 at 4:51 PM Randy Dunlap <rdunlap@...radead.org> wrote:
>
> On 06/25/18 15:39, Thomas Garnier wrote:
> > Adapt module loading to support PIE relocations. Generate dynamic GOT if
> > a symbol requires it but no entry exists in the kernel GOT.
>
> Hi,
>
> This patch description (and a few others with the same sentence) is a little
> confusing to me:
>
> > Position Independent Executable (PIE) support will allow to extend the
> > KASLR randomization range 0xffffffff80000000.
>
> Is there a word missing after "range"? May "below"?
> As is, it seems to imply "range by 0xffffffff80000000."
Yes, below. I will fix this on all patch descriptions on next iteration. Thanks!
>
>
> thanks.
>
> >
> > Signed-off-by: Thomas Garnier <thgarnie@...gle.com>
> > ---
> > arch/x86/Makefile | 4 +
> > arch/x86/include/asm/module.h | 11 ++
> > arch/x86/include/asm/sections.h | 4 +
> > arch/x86/kernel/module.c | 181 +++++++++++++++++++++++++++++++-
> > arch/x86/kernel/module.lds | 3 +
> > 5 files changed, 198 insertions(+), 5 deletions(-)
> > create mode 100644 arch/x86/kernel/module.lds
>
>
> --
> ~Randy
--
Thomas
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
