Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 23 May 2018 15:01:38 -0700
From: Thomas Garnier <thgarnie@...gle.com>
To: Randy Dunlap <rdunlap@...radead.org>
Cc: Herbert Xu <herbert@...dor.apana.org.au>, "David S . Miller" <davem@...emloft.net>, 
	Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>, "H . Peter Anvin" <hpa@...or.com>, 
	Peter Zijlstra <peterz@...radead.org>, Josh Poimboeuf <jpoimboe@...hat.com>, 
	Greg KH <gregkh@...uxfoundation.org>, Philippe Ombredanne <pombredanne@...b.com>, 
	Kate Stewart <kstewart@...uxfoundation.org>, Arnaldo Carvalho de Melo <acme@...hat.com>, 
	Yonghong Song <yhs@...com>, Andrey Ryabinin <aryabinin@...tuozzo.com>, Kees Cook <keescook@...omium.org>, 
	Tom Lendacky <thomas.lendacky@....com>, 
	"Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>, Andy Lutomirski <luto@...nel.org>, 
	Dominik Brodowski <linux@...inikbrodowski.net>, Borislav Petkov <bp@...en8.de>, Borislav Petkov <bp@...e.de>, 
	"Rafael J. Wysocki" <rjw@...ysocki.net>, Len Brown <len.brown@...el.com>, Pavel Machek <pavel@....cz>, 
	Juergen Gross <jgross@...e.com>, Alok Kataria <akataria@...are.com>, 
	Steven Rostedt <rostedt@...dmis.org>, Jan Kiszka <jan.kiszka@...mens.com>, Tejun Heo <tj@...nel.org>, 
	Christoph Lameter <cl@...ux.com>, Dennis Zhou <dennisszhou@...il.com>, 
	Boris Ostrovsky <boris.ostrovsky@...cle.com>, Alexey Dobriyan <adobriyan@...il.com>, 
	Masami Hiramatsu <mhiramat@...nel.org>, Cao jin <caoj.fnst@...fujitsu.com>, 
	Francis Deslauriers <francis.deslauriers@...icios.com>, 
	"Paul E . McKenney" <paulmck@...ux.vnet.ibm.com>, Nicolas Pitre <nicolas.pitre@...aro.org>, 
	Andrew Morton <akpm@...ux-foundation.org>, "Luis R . Rodriguez" <mcgrof@...nel.org>, 
	Arnd Bergmann <arnd@...db.de>, Christopher Li <sparse@...isli.org>, Jason Baron <jbaron@...mai.com>, 
	Mika Westerberg <mika.westerberg@...ux.intel.com>, Lukas Wunner <lukas@...ner.de>, 
	Dou Liyang <douly.fnst@...fujitsu.com>, 
	Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>, Petr Mladek <pmladek@...e.com>, 
	Masahiro Yamada <yamada.masahiro@...ionext.com>, Ingo Molnar <mingo@...nel.org>, 
	Nicholas Piggin <npiggin@...il.com>, "H . J . Lu" <hjl.tools@...il.com>, 
	Paolo Bonzini <pbonzini@...hat.com>, Radim Krčmář <rkrcmar@...hat.com>, 
	Joerg Roedel <joro@...tes.org>, David Woodhouse <dwmw@...zon.co.uk>, 
	Dave Hansen <dave.hansen@...ux.intel.com>, Rik van Riel <riel@...hat.com>, 
	Jia Zhang <qianyue.zj@...baba-inc.com>, 
	Ricardo Neri <ricardo.neri-calderon@...ux.intel.com>, Jonathan Corbet <corbet@....net>, 
	Jan Beulich <JBeulich@...e.com>, Matthias Kaehlcke <mka@...omium.org>, Baoquan He <bhe@...hat.com>, 
	Jan H . Schönherr <jschoenh@...zon.de>, 
	Daniel Micay <danielmicay@...il.com>, "the arch/x86 maintainers" <x86@...nel.org>, 
	Linux Crypto Mailing List <linux-crypto@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>, 
	Linux PM list <linux-pm@...r.kernel.org>, virtualization@...ts.linux-foundation.org, 
	xen-devel <xen-devel@...ts.xenproject.org>, linux-arch <linux-arch@...r.kernel.org>, 
	Sparse Mailing-list <linux-sparse@...r.kernel.org>, kvm list <kvm@...r.kernel.org>, 
	Linux Doc Mailing List <linux-doc@...r.kernel.org>, 
	Kernel Hardening <kernel-hardening@...ts.openwall.com>
Subject: Re: [PATCH v3 23/27] x86/modules: Adapt module loading for PIE support

On Wed, May 23, 2018 at 2:27 PM Randy Dunlap <rdunlap@...radead.org> wrote:

> Hi,

> (for several patches in this series:)
> The commit message is confusing.  See below.

Thanks for the edits, I will change the different commit messages.



> On 05/23/2018 12:54 PM, Thomas Garnier wrote:
> > Adapt module loading to support PIE relocations. Generate dynamic GOT if
> > a symbol requires it but no entry exist in the kernel GOT.

>                                      exists

> >
> > Position Independent Executable (PIE) support will allow to extended the

>                                                  will allow us to extend
the

> > KASLR randomization range below the -2G memory limit.

> Does that say "below th negative 2G memory limit"?
> I don't get it.

Yes, below 0xffffffff80000000 basically. I think I will just say that.



> >
> > Signed-off-by: Thomas Garnier <thgarnie@...gle.com>
> > ---
> >  arch/x86/Makefile               |   4 +
> >  arch/x86/include/asm/module.h   |  11 ++
> >  arch/x86/include/asm/sections.h |   4 +
> >  arch/x86/kernel/module.c        | 181 +++++++++++++++++++++++++++++++-
> >  arch/x86/kernel/module.lds      |   3 +
> >  5 files changed, 198 insertions(+), 5 deletions(-)
> >  create mode 100644 arch/x86/kernel/module.lds


> Thanks,
> --
> ~Randy



-- 
Thomas

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.