Date: Tue, 13 Mar 2018 21:18:45 -0400 From: Daniel Micay <danielmicay@...il.com> To: David Laight <David.Laight@...lab.com> Cc: Arend van Spriel <arend.vanspriel@...adcom.com>, Andreas Christoforou <andreaschristofo@...il.com>, Kees Cook <keescook@...omium.org>, Kernel Hardening <kernel-hardening@...ts.openwall.com>, QCA ath9k Development <ath9k-devel@....qualcomm.com>, Kalle Valo <kvalo@...eaurora.org>, "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>, Netdev <netdev@...r.kernel.org>, kernel list <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] drivers: net: wireless: ath: ath9: dfs: remove VLA usage No, it's undefined behavior to write to a const variable. The `static` and `const` on the variable both change the code generation in the real world as permitted / encouraged by the standard. It's placed in read-only memory. Trying to write to it will break. It's not "implemented defined" to write to it, it's "undefined behavior" i.e. it's considered incorrect. There a clear distinction between those in the standard. You're confusing having a real `const` for a variable with having it applied to a pointer. It's well-defined to cast away const from a pointer and write to what it points at if it's not actually const. If it is const, that's broken. There's nothing implementation defined about either case. The C standard could have considered `static const` variables to work as constant expressions just like the C++ standard. They borrowed it from there but made it less useful than const in what became the C++ standard. They also used stricter rules for the permitted implicit conversions of const pointers which made those much less usable, i.e. converting `int **` to `const int *const *` wasn't permitted like C++. I don't think the difference between C and C++ const pointer conversions, it's a quirk of them being standardized on different timelines and ending up with different versions of the same thing. On the other hand, they might have left out having ever so slightly more useful constant expressions on purpose since people can use #define.
Powered by blists - more mailing lists
Powered by Openwall GNU/*/Linux - Powered by OpenVZ