kernel-hardening - Re: [PATCH v2] staging: vchiq

Follow @Openwall on Twitter for new release announcements and other news

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 12 Mar 2018 06:58:04 +0100 (CET)
From: Stefan Wahren <stefan.wahren@...e.com>
To: Eric Anholt <eric@...olt.net>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"Tobin C. Harding" <me@...in.cc>
Cc: Tycho Andersen <tycho@...ho.ws>, driverdev-devel@...uxdriverproject.org,
	Kees Cook <keescook@...omium.org>,
	kernel-hardening@...ts.openwall.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] staging: vchiq_arm: Clear VLA warning

Hi Tobin,

> "Tobin C. Harding" <me@...in.cc> hat am 12. März 2018 um 06:46 geschrieben:
> 
> 
> On Mon, Mar 12, 2018 at 12:37:53PM +1100, Tobin C. Harding wrote:
> > The kernel would like to have all stack VLA usage removed[1].  The array
> > here is fixed (declared with a const variable) but it appears like a VLA
> > to the compiler.  Also, currently we are putting 768 bytes on the
> > stack.  This function is only called on the error path so performance is
> > not critical, let's just allocate the memory instead of using the
> > stack.  This saves stack space and removes the VLA build warning.
> > 
> > kmalloc a buffer for dumping state instead of using the stack.
> > 
> > [1]: https://lkml.org/lkml/2018/3/7/621
> > 
> > Signed-off-by: Tobin C. Harding <me@...in.cc>
> > ---
> 
> Drop this please, leaks memory.

except from the leak, did you test this patch on a RPi?

Thanks
Stefan

> 
> thanks,
> Tobin.

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.