Date: Mon, 12 Feb 2018 13:43:11 +0200 From: Mike Rapoport <rppt@...ux.vnet.ibm.com> To: Igor Stoppa <igor.stoppa@...wei.com> Cc: willy@...radead.org, rdunlap@...radead.org, corbet@....net, keescook@...omium.org, mhocko@...nel.org, labbott@...hat.com, jglisse@...hat.com, hch@...radead.org, cl@...ux.com, linux-security-module@...r.kernel.org, linux-mm@...ck.org, linux-kernel@...r.kernel.org, kernel-hardening@...ts.openwall.com Subject: Re: [PATCH 4/6] Protectable Memory On Mon, Feb 12, 2018 at 01:26:28PM +0200, Igor Stoppa wrote: > On 11/02/18 14:37, Mike Rapoport wrote: > > On Sun, Feb 11, 2018 at 05:19:18AM +0200, Igor Stoppa wrote: > > >> + * Return: 0 if the object does not belong to pmalloc, 1 if it belongs to > >> + * pmalloc, -1 if it partially overlaps pmalloc meory, but incorectly. > > > > typo: ^ memory > > thanks :-( > > [...] > > >> +/** > >> + * When the sysfs is ready to receive registrations, connect all the > >> + * pools previously created. Also enable further pools to be connected > >> + * right away. > >> + */ > > > > This does not seem as kernel-doc comment. Please either remove the second * > > from the opening comment mark or reformat the comment. > > For this too, I thought I had caught them all, but I was wrong ... > > I didn't find any mention of automated checking for comments. > Is there such tool? I don't know if there is a tool. I couldn't find anything in scripts, maybe somebody have such tool out of tree. For now, I've added mm-api.rst that includes all mm .c files and run 'make htmldocs' which spits plenty of warnings and errors. > -- > thanks, igor > -- Sincerely yours, Mike.
Powered by blists - more mailing lists
Powered by Openwall GNU/*/Linux - Powered by OpenVZ