[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Fri, 31 Mar 2017 23:19:35 +0200
From: Mickaël Salaün <mic@...ikod.net>
To: Julia Lawall <julia.lawall@...6.fr>
Cc: linux-kernel@...r.kernel.org, Alexei Starovoitov <ast@...nel.org>,
Andy Lutomirski <luto@...capital.net>,
Arnaldo Carvalho de Melo <acme@...nel.org>,
Casey Schaufler <casey@...aufler-ca.com>,
Daniel Borkmann <daniel@...earbox.net>,
David Drysdale
<drysdale@...gle.com>,
"David S . Miller" <davem@...emloft.net>,
"Eric W . Biederman" <ebiederm@...ssion.com>,
James Morris <james.l.morris@...cle.com>, Jann Horn <jann@...jh.net>,
Jonathan Corbet <corbet@....net>,
Matthew Garrett <mjg59@...f.ucam.org>,
Michael Kerrisk <mtk.manpages@...il.com>,
Kees Cook <keescook@...omium.org>, Paul Moore <paul@...l-moore.com>,
Sargun Dhillon <sargun@...gun.me>,
"Serge E . Hallyn" <serge@...lyn.com>, Shuah Khan <shuah@...nel.org>,
Tejun Heo <tj@...nel.org>, Thomas Graf <tgraf@...g.ch>,
Will Drewry <wad@...omium.org>, kernel-hardening@...ts.openwall.com,
linux-api@...r.kernel.org, linux-security-module@...r.kernel.org,
netdev@...r.kernel.org, kbuild-all@...org
Subject: Re: [PATCH net-next v6 01/11] bpf: Add eBPF program subtype and
is_valid_subtype() verifier (fwd)
Good catch, thanks again Julia!
Mickaël
On 29/03/2017 17:14, Julia Lawall wrote:
> Size is unsigned, so not negative.
>
> julia
>
> ---------- Forwarded message ----------
> Date: Wed, 29 Mar 2017 23:06:01 +0800
> From: kbuild test robot <fengguang.wu@...el.com>
> To: kbuild@...org
> Cc: Julia Lawall <julia.lawall@...6.fr>
> Subject: Re: [PATCH net-next v6 01/11] bpf: Add eBPF program subtype and
> is_valid_subtype() verifier
>
> In-Reply-To: <20170328234650.19695-2-mic@...ikod.net>
> TO: "Mickaël Salaün" <mic@...ikod.net>
>
> Hi Mickaël,
>
> [auto build test WARNING on net-next/master]
>
> url: https://github.com/0day-ci/linux/commits/Micka-l-Sala-n/Landlock-LSM-Toward-unprivileged-sandboxing/20170329-211258
> :::::: branch date: 2 hours ago
> :::::: commit date: 2 hours ago
>
>>> kernel/bpf/syscall.c:1041:5-9: WARNING: Unsigned expression compared with zero: size < 0
>
> git remote add linux-review https://github.com/0day-ci/linux
> git remote update linux-review
> git checkout 07d282aef4f60235407284c0be81d01e352e040b
> vim +1041 kernel/bpf/syscall.c
>
> f4324551 Daniel Mack 2016-11-23 1025 return -EINVAL;
> f4324551 Daniel Mack 2016-11-23 1026 }
> f4324551 Daniel Mack 2016-11-23 1027
> 7f677633 Alexei Starovoitov 2017-02-10 1028 return ret;
> f4324551 Daniel Mack 2016-11-23 1029 }
> f4324551 Daniel Mack 2016-11-23 1030 #endif /* CONFIG_CGROUP_BPF */
> f4324551 Daniel Mack 2016-11-23 1031
> 99c55f7d Alexei Starovoitov 2014-09-26 1032 SYSCALL_DEFINE3(bpf, int, cmd, union bpf_attr __user *, uattr, unsigned int, size)
> 99c55f7d Alexei Starovoitov 2014-09-26 1033 {
> 99c55f7d Alexei Starovoitov 2014-09-26 1034 union bpf_attr attr = {};
> 99c55f7d Alexei Starovoitov 2014-09-26 1035 int err;
> 99c55f7d Alexei Starovoitov 2014-09-26 1036
> 1be7f75d Alexei Starovoitov 2015-10-07 1037 if (!capable(CAP_SYS_ADMIN) && sysctl_unprivileged_bpf_disabled)
> 99c55f7d Alexei Starovoitov 2014-09-26 1038 return -EPERM;
> 99c55f7d Alexei Starovoitov 2014-09-26 1039
> 07d282ae Mickaël Salaün 2017-03-29 1040 size = check_user_buf((void __user *)uattr, size, sizeof(attr));
> 07d282ae Mickaël Salaün 2017-03-29 @1041 if (size < 0)
> 07d282ae Mickaël Salaün 2017-03-29 1042 return size;
> 99c55f7d Alexei Starovoitov 2014-09-26 1043
> 99c55f7d Alexei Starovoitov 2014-09-26 1044 /* copy attributes from user space, may be less than sizeof(bpf_attr) */
> 99c55f7d Alexei Starovoitov 2014-09-26 1045 if (copy_from_user(&attr, uattr, size) != 0)
> 99c55f7d Alexei Starovoitov 2014-09-26 1046 return -EFAULT;
> 99c55f7d Alexei Starovoitov 2014-09-26 1047
> 99c55f7d Alexei Starovoitov 2014-09-26 1048 switch (cmd) {
> 99c55f7d Alexei Starovoitov 2014-09-26 1049 case BPF_MAP_CREATE:
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all Intel Corporation
>
Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
